Re: [DISCUSS] FLIP-481: Introduce Event Reporting

2024-12-06 Thread Piotr Nowojski
Thanks for the comments! I will open the voting thread later today!. Best, Piotrek śr., 4 gru 2024 o 22:56 Roman Khachatryan napisał(a): > Thanks for updating the FLIP and clarifying. > > > That might have been a good idea, however this is consistent with the > ? already pre-existing traces/`Sp

Re: [DISCUSS] FLIP-481: Introduce Event Reporting

2024-12-04 Thread Roman Khachatryan
Thanks for updating the FLIP and clarifying. > That might have been a good idea, however this is consistent with the ? already pre-existing traces/`SpanBuilder`. > I'm not sure what you would propose in this context? Make those two places > inconsistent? Good point, I think consistency is more im

Re: [DISCUSS] FLIP-481: Introduce Event Reporting

2024-12-03 Thread Piotr Nowojski
Hi Roman! > 1. Should it list the events that would be emitted in the first version? > If not as part of the proposed change, then maybe as examples I've added a brief list of events that will be added in the first version. > 2. Interface Event - Scope > It's scope is explicitly tied to a Class

Re: [DISCUSS] FLIP-481: Introduce Event Reporting

2024-11-14 Thread Roman Khachatryan
Hi Piotr, thanks for the proposal! I think this would be a very valuable addition to Flink as it would simplify operations a lot (disclaimer: we already use it in our internal Flink version) I have a couple of remarks regarding the FLIP: 1. Should it list the events that would be emitted in the