Hi. Yubin.
Thanks for your update. LGTM.
Best,
Hang
Yubin Li 于2024年3月20日周三 11:56写道：
> Hi Hang,
>
> I have updated FLIP as you suggested, thanks for your valuable feedback!
>
> Best,
> Yubin
>
> On Wed, Mar 20, 2024 at 11:15 AM Hang Ruan wrote:
> >
> > Hi, Yubin,
> >
> > I found a little mista
Hi Hang,
I have updated FLIP as you suggested, thanks for your valuable feedback!
Best,
Yubin
On Wed, Mar 20, 2024 at 11:15 AM Hang Ruan wrote:
>
> Hi, Yubin,
>
> I found a little mistake in FLIP.
> `ALTER CATALOG catalog_name RESET (key1=val1, key2=val2, ...)` should be
> changed as `ALTER CAT
Hi, Yubin,
I found a little mistake in FLIP.
`ALTER CATALOG catalog_name RESET (key1=val1, key2=val2, ...)` should be
changed as `ALTER CATALOG catalog_name RESET (key1, key2, ...)`, right?
Best,
Hang
Lincoln Lee 于2024年3月20日周三 10:04写道：
> Hi Yubin,
>
> Sorry, please ignore my last reply (wrong
Hi Yubin,
Sorry, please ignore my last reply (wrong context).
I also asked Leonard, your proposal to extend the `CatalogDescriptor`
should be okay.
Thank you for your update : ) !
Best,
Lincoln Lee
Lincoln Lee 于2024年3月20日周三 09:35写道：
> Hi Yubin,
>
> Thank you for detailed explaination! I ove
Hi Yubin,
Thank you for detailed explaination! I overlooked `CatalogBaseTable`, in
fact
there is already a `String getComment();` interface similar to `database`
and `table`.
Can we continue the work on FLINK-21665 and complete its implementation? It
seems to be very close.
Best,
Lincoln Lee
Y
Hi Lincoln,
Thanks for your detailed comments!
Supporting comments for `Catalog` is a really helpful feature, I agree
with you to make it introduced in this FLIP, thank you for pointing
that out :)
Concerning the implementation, I propose to introduce `getComment()`
method in `CatalogDescriptor`
Hi Yubin,
Thanks for your quickly response!
It would be better to support comments just like create `database` and
`table` with comment.
That is, add `String getComment();` to the current `Catalog` interface.
WDYT?
Best,
Lincoln Lee
Yubin Li 于2024年3月19日周二 21:44写道：
> Hi Lincoln,
>
> Good catc
Hi Lincoln,
Good catch. Thanks for your suggestions.
I found that the creation statements of database and table both
support specifying "if not exists". For the sake of syntactic
consistency and user practicality, We could introduce the '[if not
exists]' clause to the 'create catalog' statement.
Hi Yubin,
Big +1 for completing the catalog api!
There's a minor addition[1] which does not affect the vote could also be
considered.
[1] https://issues.apache.org/jira/browse/FLINK-21665
Best,
Lincoln Lee
Yubin Li 于2024年3月18日周一 17:44写道：
> Hi Jark,
>
> Thanks for your response, I have updat
Hi Jark,
Thanks for your response, I have updated FLIP-436: Introduce
Catalog-related Syntax [1] as you suggested.
If there are no more comments within 24 hours, I will start a vote for
this, thanks :)
Best,
Yubin
[1]
https://cwiki.apache.org/confluence/display/FLINK/FLIP-436%3A+Introduce+Cata
Hi Yubin,
Thanks for the quick response. The suggestion sounds good to me!
Best,
Jark
On Mon, 18 Mar 2024 at 13:06, Yubin Li wrote:
> Hi Jark,
>
> Good pointing! Thanks for your reply, there are some details to align :)
>
> 1. I think the purpose of DESCRIBE CATALOG is to display metadata
> >
Hi Jark,
Good pointing! Thanks for your reply, there are some details to align :)
1. I think the purpose of DESCRIBE CATALOG is to display metadata
> information including catalog name,
> catalog comment (may be introduced in the future), catalog type, and
> catalog properties (for example [1])
Hi Yubin,
Thanks for updating the FLIP. The updated version looks good in general.
I only have 2 minor comments.
1. I think the purpose of DESCRIBE CATALOG is to display metadata
information including catalog name,
catalog comment (may be introduced in the future), catalog type, and
catalog prope
Hi Xuyang,
Thank you for pointing this out, The parser part of `describe catalog`
syntax
has indeed been implemented in FLIP-69, and it is not actually available.
we can complete the syntax in this FLIP [1]. I have updated the doc :)
Best,
Yubin
[1]
https://cwiki.apache.org/confluence/display/F
Hi folks,
Thank you all for your input, it really makes sense to introduce missing
catalog-related SQL syntaxes under this FLIP, and I have changed the
title of doc to "FLIP-436: Introduce Catalog-related Syntax".
After comprehensive consideration, the following syntaxes should be
introduced, mor
Hi Yubin,
Thanks for driving the discussion, generally +1 for the FLIP, big +1 to
finalize the whole catalog syntax story in one FLIP,
thus I want to jump into the discussion again after you completed the whole
catalog syntax story.
Best,
Leonard
> 2024年3月14日 下午8:39，Roc Marshal 写道：
>
> Hi
Hi, Yubin
Thank you for initiating this discussion! +1 for the proposal.
Best,
Yuepeng Pan
At 2024-03-14 18:57:35, "Ferenc Csaky" wrote:
>Hi Yubin,
>
>Thank you for initiating this discussion! +1 for the proposal.
>
>I also think it makes sense to group the missing catalog related
Hi, Yubin.
Thanks for leading the discussion. +1 for the FLIP.
Best,
Zhongqiang Gong
Ferenc Csaky 于2024年3月14日周四 18:58写道：
> Hi Yubin,
>
> Thank you for initiating this discussion! +1 for the proposal.
>
> I also think it makes sense to group the missing catalog related
> SQL syntaxes under th
Hi Yubin,
Thank you for initiating this discussion! +1 for the proposal.
I also think it makes sense to group the missing catalog related
SQL syntaxes under this FLIP.
Looking forward to these features!
Best,
Ferenc
On Thursday, March 14th, 2024 at 08:31, Jane Chan wrote:
>
>
> Hi Yubin
+1 for the FLIP, thanks Yubin for driving it.
Also +1 to complete the whole story about Catalog in this FLIP as Jark
and Jane said above.
Jane Chan 于2024年3月14日周四 15:33写道：
>
> Hi Yubin,
>
> Thanks for leading the discussion. I'm +1 for the FLIP.
>
> As Jark said, it's a good opportunity to enhanc
Hi Yubin,
Thanks for leading the discussion. I'm +1 for the FLIP.
As Jark said, it's a good opportunity to enhance the syntax for Catalog
from a more comprehensive perspective. So, I suggest expanding the scope of
this FLIP by focusing on the mechanism instead of one use case to enhance
the overa
Hi, Yubin.
Thanks for the FLIP. +1 for it.
Best,
Hang
Yubin Li 于2024年3月14日周四 10:15写道：
> Hi Jingsong, Feng, and Jeyhun
>
> Thanks for your support and feedback!
>
> > However, could we add a new method `getCatalogDescriptor()` to
> > CatalogManager instead of directly exposing CatalogStore?
>
>
Thank you Yubin,
+1 for the proposal. We have been lacking catalog related syntax to operate
catalogs.
It's a good chance to complete the syntax as we have introduced
CatalogStore.
>From what I can see, some useful commands are still missing for catalogs,
such as, alter catalog, describe catalog.
Hi Jingsong, Feng, and Jeyhun
Thanks for your support and feedback!
> However, could we add a new method `getCatalogDescriptor()` to
> CatalogManager instead of directly exposing CatalogStore?
Good point, Besides the audit tracking issue, The proposed feature
only requires `getCatalogDescriptor(
Hi Yubin,
Thanks for the proposal. +1 for it.
I have one comment:
I would like to see the SQL syntax for the proposed statement. Showing the
SQL parser implementation in the FLIP
for the SQL syntax might be a bit confusing. Also, the formal definition is
missing for this SQL clause.
Maybe someth
Hi Yubin
Thank you for initiating this FLIP.
I have just one minor question:
I noticed that we added a new function `getCatalogStore` to expose
CatalogStore, and it seems fine.
However, could we add a new method `getCatalogDescriptor()` to
CatalogManager instead of directly exposing CatalogStore
+1 for this.
We are missing a series of catalog related syntaxes.
Especially after the introduction of catalog store. [1]
[1]
https://cwiki.apache.org/confluence/display/FLINK/FLIP-295%3A+Support+lazy+initialization+of+catalogs+and+persistence+of+catalog+configurations
Best,
Jingsong
On Wed, M
27 matches
Mail list logo
