> > > is
> > > > > > not
> > > > > > > a hard guarantee.
> > > > > > >
> > > > > > >
> > > > > > > Best,
> > > > > > >
> > > > > > > Xintong
>
edly,
> > this
> > > is
> > > > > not
> > > > > > a hard guarantee.
> > > > > >
> > > > > >
> > > > > > Best,
> > > > > >
> > > > > > Xintong
> > > > > >
> > > > > >
> > > > > >
> &
> > Matt Wang,
> > > > > >
> > > > > > I think the currently exposed info is all that is available
> through
> > > > > > GarbageCollectorMXBean. This FLIP does not aim to introduce a new
> > > more
> > > > > >
t; > > > > new mechanism and may be a breaking change.
> > > > >
> > > > > We basically want to simply extend the current reporting here with
> > the
> > > > rate
> > > > > metrics and the total metrics.
> > > > >
> > >
metrics and the total metrics.
> > > >
> > > > Gyula
> > > >
> > > > On Wed, Sep 6, 2023 at 9:24 AM Matt Wang wrote:
> > > >
> > > > > Hi Gyula,
> > > > >
> > > > > +1 for this proposal.
> > > &
t; On Wed, Sep 6, 2023 at 9:24 AM Matt Wang wrote:
> > >
> > > > Hi Gyula,
> > > >
> > > > +1 for this proposal.
> > > >
> > > > Do we need to add a metric to record the count of different
> > > > collectors? Now there is only a total count.
t; > > +1 for this proposal.
> > >
> > > Do we need to add a metric to record the count of different
> > > collectors? Now there is only a total count. For example,
> > > for G1, there is no way to distinguish whether it is the
> > > young generation or the old generation.
> > &
l count. For example,
> > for G1, there is no way to distinguish whether it is the
> > young generation or the old generation.
> >
> >
> >
> > --
> >
> > Best,
> > Matt Wang
> >
> >
> > Replied Message
> > | From
count. For example,
> for G1, there is no way to distinguish whether it is the
> young generation or the old generation.
>
>
>
> --
>
> Best,
> Matt Wang
>
>
> Replied Message
> | From | Gyula Fóra |
> | Date | 09/6/2023 15:03 |
> | To | |
>
> | Date | 09/6/2023 15:03 |
> | To | |
> | Subject | Re: [DISCUSS] FLIP-361: Improve GC Metrics |
> Thanks Xintong!
>
> Just so I understand correctly, do you suggest adding a metric for
> delta(Time) / delta(Count) since the last reporting ?
> .TimePerGc or .AverageTime would
| From | Gyula Fóra |
| Date | 09/6/2023 15:03 |
| To | |
| Subject | Re: [DISCUSS] FLIP-361: Improve GC Metrics |
Thanks Xintong!
Just so I understand correctly, do you suggest adding a metric for
delta(Time) / delta(Count) since the last reporting ?
.TimePerGc or .AverageTime would make
Thanks Xintong!
Just so I understand correctly, do you suggest adding a metric for
delta(Time) / delta(Count) since the last reporting ?
.TimePerGc or .AverageTime would make sense.
AverageTime may be a bit nicer :)
My only concern is how useful this will be in reality. If there are only
(or seve
Thanks for bringing this up, Gyula.
The proposed changes make sense to me. +1 for them.
In addition to the proposed changes, I wonder if we should also add
something like timePerGc? This would help understand whether there are long
pauses, due to GC STW, that may lead to rpc unresponsiveness and
Thanks for the clarification!
By default the meterview measures for 1 minute sounds good to me!
+1 for this proposal.
Best,
Rui
On Wed, Sep 6, 2023 at 1:27 PM Gyula Fóra wrote:
> Thanks for the feedback Rui,
>
> The rates would be computed using the MeterView class (like for any other
> rate
Thanks for the feedback Rui,
The rates would be computed using the MeterView class (like for any other
rate metric), just because we report the value per second it doesn't mean
that we measure in a second granularity.
By default the meterview measures for 1 minute and then we calculate the
per sec
Hi Gyula,
+1 for this proposal. The current GC metric is really unfriendly.
I have a concern with your proposed rate metric: the rate is perSecond
instead of per minute. I'm unsure whether it's suitable for GC metric.
There are two reasons why I suspect perSecond may not be well
compatible with
Hi Gyula,
+1 The proposed changes make sense and are in line with what is
available for other metrics, e.g. number of records processed.
-Max
On Tue, Sep 5, 2023 at 2:43 PM Gyula Fóra wrote:
>
> Hi Devs,
>
> I would like to start a discussion on FLIP-361: Improve GC Metrics [1].
>
> The current
17 matches
Mail list logo
