Re: [DISCUSS] Drop connectors for Elasticsearch 2.x and 5.x

2020-02-20 Thread Robert Metzger
Thank you all. I have proposed a PR to upgrade the ES5 connector: https://github.com/apache/flink/pull/11162 On Wed, Feb 19, 2020 at 3:02 PM Till Rohrmann wrote: > +1 for removing ES2 and updating ES5 in 1.11. > > +1 for revisiting the removal of ES5 for 1.12. > > Cheers, > Till > > On Tue, Feb

Re: [DISCUSS] Drop connectors for Elasticsearch 2.x and 5.x

2020-02-19 Thread Till Rohrmann
+1 for removing ES2 and updating ES5 in 1.11. +1 for revisiting the removal of ES5 for 1.12. Cheers, Till On Tue, Feb 18, 2020 at 1:28 PM Chesnay Schepler wrote: > Since one of the reasons for dropping ES2 was that it blocks some > critical updates for the ES5 connector I'd prefer to keep ES5

Re: [DISCUSS] Drop connectors for Elasticsearch 2.x and 5.x

2020-02-18 Thread Chesnay Schepler
Since one of the reasons for dropping ES2 was that it blocks some critical updates for the ES5 connector I'd prefer to keep ES5 around for 1.11, and revisit this discussion for 1.12 . On 18/02/2020 13:03, Aljoscha Krettek wrote: Wouldn't removing the ES 2.x connector be enough because we can th

Re: [DISCUSS] Drop connectors for Elasticsearch 2.x and 5.x

2020-02-18 Thread Aljoscha Krettek
Wouldn't removing the ES 2.x connector be enough because we can then update the ES 5.x connector? It seems there are some users that still want to use that one. Best, Aljoscha On 18.02.20 10:42, Robert Metzger wrote: The ES5 connector is causing some problems on the CI system. It would be nic

Re: [DISCUSS] Drop connectors for Elasticsearch 2.x and 5.x

2020-02-18 Thread Robert Metzger
The ES5 connector is causing some problems on the CI system. It would be nice if we could make a decision here soon. I don't want to invest time into fixing it, if we are going to remove it. I'm still in favor of removing it. If we see that there's demand for the 5.x connector after the 1.11 relea

Re: [DISCUSS] Drop connectors for Elasticsearch 2.x and 5.x

2020-02-13 Thread Dawid Wysakowicz
Sorry for late reply, @all I think there is a general consensus that we want to drop ES 2.x support. I created https://issues.apache.org/jira/browse/FLINK-16046 to track it. @Stephan @Chesnay @Itamar In our connectors we use Java High Level Rest Client. ES promises to maintain compatibility of i

Re: [DISCUSS] Drop connectors for Elasticsearch 2.x and 5.x

2020-02-11 Thread Chesnay Schepler
I suppose the downside in an HTTP ES sink is that you don't get _any_ form of high-level API from ES, and we'd have to manually build an HTTP request that matches the ES format. Of course you also lose any client-side verification that the clients did, if there is any (but I guess the API itsel

Re: [DISCUSS] Drop connectors for Elasticsearch 2.x and 5.x

2020-02-11 Thread Stephan Ewen
+1 to drop ES 2.x - unsure about 5.x (makes sense to get more user input for that one). @Itamar - if you would be interested in contributing a "universal" or "cross version" ES connector, that could be very interesting. Do you know if there are known performance issues or feature restrictions with

Re: [DISCUSS] Drop connectors for Elasticsearch 2.x and 5.x

2020-02-10 Thread Danny Chan
5.x seems to have a lot of users, is the 6.x completely compatible with 5.x ~ Best, Danny Chan 在 2020年2月10日 +0800 PM9:45,Dawid Wysakowicz ,写道: > Hi all, > > As described in this https://issues.apache.org/jira/browse/FLINK-11720 > ticket our elasticsearch 5.x connector does not work out of the box

Re: [DISCUSS] Drop connectors for Elasticsearch 2.x and 5.x

2020-02-10 Thread Itamar Syn-Hershko
+1 from dropping old versions because of jar hells etc. However, in the wild there are still a lot of 2.x clusters and definitely 5.x clusters that are having a hard time upgrading. We know because we assist those on a daily basis. It is very easy to create an HTTP based connector that works with

Re: [DISCUSS] Drop connectors for Elasticsearch 2.x and 5.x

2020-02-10 Thread Aljoscha Krettek
+1 for dropping them, this stuff is quite old by now. On 10.02.20 15:04, Benchao Li wrote: +1 for dropping 2.x - 5.x. FYI currently only 6.x and 7.x ES Connectors are supported by table api. Flavio Pompermaier 于2020年2月10日周一 下午10:03写道: +1 for dropping all Elasticsearch connectors < 6.x On M

Re: [DISCUSS] Drop connectors for Elasticsearch 2.x and 5.x

2020-02-10 Thread Benchao Li
+1 for dropping 2.x - 5.x. FYI currently only 6.x and 7.x ES Connectors are supported by table api. Flavio Pompermaier 于2020年2月10日周一 下午10:03写道: > +1 for dropping all Elasticsearch connectors < 6.x > > On Mon, Feb 10, 2020 at 2:45 PM Dawid Wysakowicz > wrote: > > > Hi all, > > > > As described

Re: [DISCUSS] Drop connectors for Elasticsearch 2.x and 5.x

2020-02-10 Thread Flavio Pompermaier
+1 for dropping all Elasticsearch connectors < 6.x On Mon, Feb 10, 2020 at 2:45 PM Dawid Wysakowicz wrote: > Hi all, > > As described in this https://issues.apache.org/jira/browse/FLINK-11720 > ticket our elasticsearch 5.x connector does not work out of the box on > some systems and requires a v

Re: [DISCUSS] Drop connectors for Elasticsearch 2.x and 5.x

2020-02-10 Thread Robert Metzger
Thanks for starting this discussion! +1 to drop both On Mon, Feb 10, 2020 at 2:45 PM Dawid Wysakowicz wrote: > Hi all, > > As described in this https://issues.apache.org/jira/browse/FLINK-11720 > ticket our elasticsearch 5.x connector does not work out of the box on > some systems and requires