Chesnay Schepler created FLINK-4159:
---
Summary: Quickstart poms exclude unused dependencies
Key: FLINK-4159
URL: https://issues.apache.org/jira/browse/FLINK-4159
Project: Flink
Issue Type
On 19 Jun 2015, at 10:19, Maximilian Michels wrote:
> @Robert @Stephan Thanks for clarifying! Of course it would be better to
> have a concise quickstart pom.xml but the necessary workarounds justify the
> current state.
+1
@Robert @Stephan Thanks for clarifying! Of course it would be better to
have a concise quickstart pom.xml but the necessary workarounds justify the
current state.
On Thu, Jun 18, 2015 at 11:48 PM, Stephan Ewen wrote:
> I remember we had a similar discussion a while back.
>
> The current solution
On Thursday, June 18, 2015, Robert Metzger wrote:
> Hi,
>
> I'm against cancelling a release for something that is not nice ;) It has
> to be at least broken to cancel :)
See vote thread +1. This was not about canceling but clearification. ;)
> I agree that the pom looks complicated and I wou
I remember we had a similar discussion a while back.
The current solution is the best out-of-the-box experience for the
quickstarts across Eclipse, IntelliJ, and command-line Maven. This is more
important that nice and compact POM files, IMHO.
On Thu, Jun 18, 2015 at 11:26 AM, Robert Metzger
w
Hi,
I'm against cancelling a release for something that is not nice ;) It has
to be at least broken to cancel :)
I agree that the pom looks complicated and I would love to do it better,
but in my opinion the current approach is giving our users the best out of
the box experience.
The right appro
Is it okay when the user runs the built jar in LocalEnvironment? (Just run with
`java -jar` command.)
I know that it is special case but it is a possible scenario for local testing.
If we change Quickstart POM to use provided scope for dependencies, we should
add a guide about this into document
I'm also for simplification but let's hear what those who put the build-jar
profile there have to say about it.?
On Thu, 18 Jun 2015 at 17:25 Ufuk Celebi wrote:
>
> On 18 Jun 2015, at 16:58, Fabian Hueske wrote:
>
> > Why?
> >
> > mvn package
> >
> > builds the program correctly, no?
>
> Yes, b
On 18 Jun 2015, at 16:58, Fabian Hueske wrote:
> Why?
>
> mvn package
>
> builds the program correctly, no?
Yes, but:
- Dependencies not specified by the user may be included (Metrics, javaassist)
- Dependencies specified by the user may be excluded
- If you use the build-jar profile you hav
Why?
mvn package
builds the program correctly, no?
On Jun 18, 2015 16:53, "Ufuk Celebi" wrote:
>
> On 18 Jun 2015, at 16:49, Fabian Hueske wrote:
>
> > I don't think that many users care about the internals of the quickstart
> > pom file and are just happy if it works.
>
> I agree with this. T
On 18 Jun 2015, at 16:49, Fabian Hueske wrote:
> I don't think that many users care about the internals of the quickstart
> pom file and are just happy if it works.
I agree with this. That's exactly why I think it's better to keep it clean;
with the current pom you actually do have to worry ab
I don't think that many users care about the internals of the quickstart
pom file and are just happy if it works.
I would not cancel the ongoing vote for that.
We might fix it if the vote is canceled, but it has no priority, IMO.
2015-06-18 15:32 GMT+02:00 Ufuk Celebi :
> Hey all,
>
> looking at
Hey all,
looking at the quickstarts for the upcoming release, I am a little confused:
We use the shade plugin to build a fat jar and exclude some of Flink's
dependencies (actual and transitive). Then we have a build profile (build-jar),
which sets the Flink dependencies to provided.
1. Is ther
13 matches
Mail list logo
