Re: Frontend classpath issue

2017-03-13 Thread Stephan Ewen
I think we need to get away from the dynamic class loading as much as possible. It breaks way to soon and causes easily class leaks. I would be in favor if understanding how to fix this on the Flink side, i.e., either: - Having flags for disabling it optionally - Having an option of "user cod

Re: Frontend classpath issue

2017-03-13 Thread Robert Metzger
I think the change reduces the chances to run into classloading issues in case there's a bug in Flink (= it is using the wrong CL) I've filed a JIRA for the problem: https://issues.apache.org/jira/browse/FLINK-6031 On Fri, Feb 24, 2017 at 9:29 PM, Gyula Fóra wrote: > Hi, > I am wondering whethe

Re: Frontend classpath issue

2017-02-24 Thread Gyula Fóra
Hi, I am wondering whether there is any scenario where the new way makes anything better under normal circumstances. I can only see how it will break things in subtle ways. If you think there is any real benefit to the current approach I dont mind having it as a default, otherwise I am in favor o

Re: Frontend classpath issue

2017-02-24 Thread Robert Metzger
The JIRA (https://issues.apache.org/jira/browse/FLINK-4913) doesn't mention any particular user or use case. I honestly care so much if we enable or disable it by default. But since its the new default behavior of Flink 1.2. I'm against changing that in Flink 1.2.1, that's why I proposed to add a

Re: Frontend classpath issue

2017-02-24 Thread Aljoscha Krettek
Did any user have problems with the Flink 1.1 behaviour? If not, we could disable it again, by default, and add a flag for adding the user jar to all the classpaths. On Fri, 24 Feb 2017 at 14:50 Robert Metzger wrote: > I agree with you Gyula, this change is dangerous. I have seen another case >

Re: Frontend classpath issue

2017-02-24 Thread Robert Metzger
I agree with you Gyula, this change is dangerous. I have seen another case from a user with Hadoop dependencies that crashed in Flink 1.2.0 that didn't in 1.1.x I wonder if we should introduce a config flag for Flink 1.2.1 to disable the behavior if needed. On Fri, Feb 24, 2017 at 2:27 PM, Ufuk C

Re: Frontend classpath issue

2017-02-24 Thread Gyula Fóra
Hi Robert, I was not aware of this big change (I know it's my fault) but I am not sure if I agree with the rationale. I read through the JIRA and it seems that this is mostly a convenience change that we dont need to copy jars and mess with the classloading that much. On the other hand if user j