Hi Greg,
Not sure if you followed the whole thread. The "main" problem discussed
here is, that Eclipse does show an compile error for some tests that
actually compile via maven.
The tests uses a ParentClass and ChildClass and call
fromElements(ParentClass.class, new ParentClass(), new ChildClass
Matthias,
Won't this be a compile-time error as long as the user is parameterizing
the return type since .fromElements(OUT...) returns DataStreamSource
and will bind to the nearest common superclass? The new
.fromElements(Class, OUT...) does give the user the choice of common
superclass.
Greg
O
Maybe.
As we cannot change the interface anyway and is does what the user
expects (even if only "by accident") I would just leave it as is... And
for "mixed" types, specifying the common base class is acceptable
"overhead" for the user IMHO.
Nevertheless, the Eclipse problem is still not solved.
I don't know whether it is that difficult to find out the nearest common
super type. At least the Java compiler does the same when calling the pure
var arg method. I think, we should be able to do something similar. Also
throwing out the pure var arg implementation is not ideal in my opinion,
becau
I guess, removing .fromElements(Object..) would fix the problem. Not
sure so, if we can remove the method due to API stability...
I don't see any other good solution (even if the current implementation
gives a nice behavior by accident...):
If you have a complex class hierarchy, it would be quite
You’re completely right Mathias. The compiler shouldn’t allow something
like env.fromElements(SubClass.class, new ParentClass()) if it weren’t for
the overloaded method. Thus, the test case is somewhat bogus.
I’m actually wondering why the initial problem
https://issues.apache.org/jira/browse/FLIN
Hi Till,
but StreamExecutionEnvironmentTest.fromElementWithBaseTypeTest2 does not
test was you describe -- even if it is intended to test it.
It would test your describe scenario, if fromElements(Class, X...)
would be called, But this call is not possible because X is defined a
type Subclass and
Thanks for looking into this problem Mathias. I think the Scala test should
be fixed as you've proposed.
Concerning the StreamExecutionEnvironmentTest.fromElementWithBaseTypeTest2,
I think it shouldn't be changed. The reason is that the class defines the
common base class of the elements. And the
Even if the fix works, I still have two issues in my Eclipse build...
In
flink-scala/src/test/scala/org/apache/flink/api/scala/extensions/base/AcceptPFTestBase.scala
Eclipse cannot infer the integer type. It could be fixed if you make the
type explicit (as this is only a test, it might be nice t
Cool, thank you for working on this!
On Mon, Apr 25, 2016 at 1:37 PM, Matthias J. Sax wrote:
> I can confirm that the SO answer works.
>
> I will add a note to the Eclipse setup guide at the web site.
>
> -Matthias
>
>
> On 04/25/2016 11:33 AM, Robert Metzger wrote:
> > It seems that the user re
I can confirm that the SO answer works.
I will add a note to the Eclipse setup guide at the web site.
-Matthias
On 04/25/2016 11:33 AM, Robert Metzger wrote:
> It seems that the user resolved the issue on SO, right?
>
> On Mon, Apr 25, 2016 at 11:31 AM, Ufuk Celebi wrote:
>
>> On Mon, Apr 25
It seems that the user resolved the issue on SO, right?
On Mon, Apr 25, 2016 at 11:31 AM, Ufuk Celebi wrote:
> On Mon, Apr 25, 2016 at 12:14 AM, Matthias J. Sax
> wrote:
> > What do you think about this?
>
> Hey Matthias!
>
> Thanks for bringing this up.
>
> I think it is very desirable to keep
On Mon, Apr 25, 2016 at 12:14 AM, Matthias J. Sax wrote:
> What do you think about this?
Hey Matthias!
Thanks for bringing this up.
I think it is very desirable to keep support for Eclipse. It's quite a
high barrier for new contributors to enforce a specific IDE (although
IntelliJ is gaining qu
Hi,
someone put this question on SO:
https://stackoverflow.com/questions/36824684/eclipse-imported-maven-project-cannot-resolve-symbols-in-other-imported-maven-pr
I can only confirm that Eclipse does not build Flink anymore. It shows
"103 Errors" in my case. Not sure how many Eclipse users are st
14 matches
Mail list logo
