Even if the fix works, I still have two issues in my Eclipse build... In
flink-scala/src/test/scala/org/apache/flink/api/scala/extensions/base/AcceptPFTestBase.scala
Eclipse cannot infer the integer type. It could be fixed if you make the
type explicit (as this is only a test, it might be nice to fix this --
let me know if I can push this or not)
> diff --git
> a/flink-scala/src/test/scala/org/apache/flink/api/scala/extensions/base/AcceptPFTestBase.scala
>
> b/flink-scala/src/test/scala/org/apache/flink/api/scala/extensions/base/AcceptPFTestBase.scala
> index c2e13fe..f9ce3b8 100644
> ---
> a/flink-scala/src/test/scala/org/apache/flink/api/scala/extensions/base/AcceptPFTestBase.scala
> +++
> b/flink-scala/src/test/scala/org/apache/flink/api/scala/extensions/base/AcceptPFTestBase.scala
> @@ -29,7 +29,7 @@ private[extensions] abstract class AcceptPFTestBase extends
> TestLogger with JUni
>
> private val env = ExecutionEnvironment.getExecutionEnvironment
>
> - protected val tuples = env.fromElements(1 -> "hello", 2 -> "world")
> + protected val tuples = env.fromElements(new Integer(1) -> "hello", new
> Integer(2) -> "world")
> protected val caseObjects = env.fromElements(KeyValuePair(1, "hello"),
> KeyValuePair(2, "world"))
>
> protected val groupedTuples = tuples.groupBy(_._1)
Furthermore, in
flink-java/src/test/java/org/apache/flink/api/java/io/FromElementsTest.java
> @Test
> public void fromElementsWithBaseTypeTest1() {
> ExecutionEnvironment executionEnvironment =
> ExecutionEnvironment.getExecutionEnvironment();
> executionEnvironment.fromElements(ParentType.class, new SubType(1,
> "Java"), new ParentType(1, "hello"));
> }
and in
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/StreamExecutionEnvironmentTest.java
> @Test
> public void fromElementsWithBaseTypeTest1() {
> StreamExecutionEnvironment env =
> StreamExecutionEnvironment.getExecutionEnvironment();
> env.fromElements(ParentClass.class, new SubClass(1, "Java"), new
> ParentClass(1, "hello"));
> }
In both cases, I get the error:
The method .fromElements(Object[]) is ambiguous
No clue how to fix this, and why Eclipse does not bind to
.fromElements(Class<X>, X). Any ideas?
I also digger a little bit and for both test-classes there is a second
test method called "fromElementsWithBaseTypeTest2". If I understand this
test correctly, it also tries to bind to .fromElements(Class<X>, X), but
this does not happen and .fromElemenst(Object[]) is called. Even if
there is still an exception, I got the impression that this test does
not what the intention was.
If might be good to change fromElementsWithBaseTypeTest2 to
> env.fromElements(new SubClass(1, "Java"), new ParentClass(1, "hello"));
(ie, remove the first Class parameter). Any comments on this?
-Matthias
On 04/25/2016 01:42 PM, Robert Metzger wrote:
> Cool, thank you for working on this!
>
> On Mon, Apr 25, 2016 at 1:37 PM, Matthias J. Sax <mj...@apache.org> wrote:
>
>> I can confirm that the SO answer works.
>>
>> I will add a note to the Eclipse setup guide at the web site.
>>
>> -Matthias
>>
>>
>> On 04/25/2016 11:33 AM, Robert Metzger wrote:
>>> It seems that the user resolved the issue on SO, right?
>>>
>>> On Mon, Apr 25, 2016 at 11:31 AM, Ufuk Celebi <u...@apache.org> wrote:
>>>
>>>> On Mon, Apr 25, 2016 at 12:14 AM, Matthias J. Sax <mj...@apache.org>
>>>> wrote:
>>>>> What do you think about this?
>>>>
>>>> Hey Matthias!
>>>>
>>>> Thanks for bringing this up.
>>>>
>>>> I think it is very desirable to keep support for Eclipse. It's quite a
>>>> high barrier for new contributors to enforce a specific IDE (although
>>>> IntelliJ is gaining quite the user base I think :P).
>>>>
>>>> Do you have time to look into this?
>>>>
>>>> – Ufuk
>>>>
>>>
>>
>>
>
signature.asc
Description: OpenPGP digital signature
