[RESULT] [VOTE] Release flink-shaded 7.0, release candidate #3

2019-05-29 Thread jincheng sun
Hi all, I'm happy to announce that we have unanimously approved this release. There are 6 approving votes, 3 of which are binding: * Chesnay * Timo * Hequn * Till * Nico * Jincheng There are no disapproving votes. Thanks everyone! Cheers, Jincheng

Re: [VOTE] Release flink-shaded 7.0, release candidate 3

2019-05-29 Thread jincheng sun
Hi, All Thanks to everyone for checking the release and voting! I’ll tally the results in a separate email. :) Best, Jincheng jincheng sun 于2019年5月29日周三 下午4:52写道: > > +1 (non-binding) > > @Nico, Great thanks for your detail check! > @Chesnay Great thanks for your explanation! > > I also do so

Re: [VOTE] Release flink-shaded 7.0, release candidate 3

2019-05-29 Thread jincheng sun
+1 (non-binding) @Nico, Great thanks for your detail check! @Chesnay Great thanks for your explanation! I also do some check regarding the change which Nico mentioned above, share my result here: - Jackson 2.7.9 upgrade to 2.9.8 brings some changes, including fewer classes in `snakeanaml`. This

Re: [VOTE] Release flink-shaded 7.0, release candidate 3

2019-05-28 Thread Nico Kruber
ok, thanks for the investigation/clarification On 28/05/2019 16:28, Chesnay Schepler wrote: > So from what I found jackson pre 2.8 was including a relocated version > of snakeyaml, without creating a dependency-reduced pom. > As a result we always bundled it twice, with the second one not being >

Re: [VOTE] Release flink-shaded 7.0, release candidate 3

2019-05-28 Thread Chesnay Schepler
So from what I found jackson pre 2.8 was including a relocated version of snakeyaml, without creating a dependency-reduced pom. As a result we always bundled it twice, with the second one not being used at all (I guess?) They have now removed the inclusion, meaning they now work against the sn

Re: [VOTE] Release flink-shaded 7.0, release candidate 3

2019-05-28 Thread Nico Kruber
this is a bit different here: flink-shaded-jackson-2.7.9-6.0/org/apache/flink/shaded/jackson2/com/fasterxml/jackson/dataformat/yaml/snakeyaml> find . . ./DumperOptions$FlowStyle.class ./DumperOptions$LineBreak.class ./DumperOptions$ScalarStyle.class ./DumperOptions$Version.class ./DumperOptions.cl

Re: [VOTE] Release flink-shaded 7.0, release candidate 3

2019-05-28 Thread Chesnay Schepler
@Nico I still see snakeyaml in the flink-shaded-jackson jars, and in the dependency tree. It even takes up more space than before. AFAIK we do not work directly against the contained snakeyaml version, so we should be fine in any case. On 27/05/2019 16:45, Nico Kruber wrote: +1 (mod jackson sn

Re: [VOTE] Release flink-shaded 7.0, release candidate 3

2019-05-28 Thread Nico Kruber
+1 (mod jackson snakeyaml support; see below) - checked release notes - verified signatures (sha512, asc) - verified "mvn clean package -Pinclude-netty-tcnative-static" - compared contents and verified changes of + flink-shaded-asm-6*.jar + flink-shaded-guava-18.0*.jar + flink-shaded-netty-4

Re: [VOTE] Release flink-shaded 7.0, release candidate 3

2019-05-28 Thread Till Rohrmann
+1 (binding) * verified checksum and signature Cheers, Till On Mon, May 27, 2019 at 4:24 PM Hequn Cheng wrote: > +1 (non-binding) > > - Release notes are correct. > - Built from source archive successfully. > - Signatures and hash are correct. > - All artifacts(11 artifacts including flink-sha

Re: [VOTE] Release flink-shaded 7.0, release candidate 3

2019-05-27 Thread Hequn Cheng
+1 (non-binding) - Release notes are correct. - Built from source archive successfully. - Signatures and hash are correct. - All artifacts(11 artifacts including flink-shaded) have been deployed to the maven central repository. - javax annotations are not included in the slim&uber jar any more.

Re: [VOTE] Release flink-shaded 7.0, release candidate 3

2019-05-27 Thread Timo Walther
I quickly scanned the changes and could not spot any issues. +1 Am 27.05.19 um 13:36 schrieb Chesnay Schepler: +1 * git tag exists * no binaries in release * relocated jackson no longer bundled twice in hadoop jars * jackson dependency tree exists * netty-tcnative-static not part of release *

Re: [VOTE] Release flink-shaded 7.0, release candidate 3

2019-05-27 Thread Chesnay Schepler
+1 * git tag exists * no binaries in release * relocated jackson no longer bundled twice in hadoop jars * jackson dependency tree exists * netty-tcnative-static not part of release * artifacts present for each hadoop version * compared contents of each hadoop jar with the current ones, no signif

[VOTE] Release flink-shaded 7.0, release candidate 3

2019-05-26 Thread jincheng sun
Hi all, Please review and vote on the release candidate #3 for the version 7.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], * the of