this is a bit different here: flink-shaded-jackson-2.7.9-6.0/org/apache/flink/shaded/jackson2/com/fasterxml/jackson/dataformat/yaml/snakeyaml> find . . ./DumperOptions$FlowStyle.class ./DumperOptions$LineBreak.class ./DumperOptions$ScalarStyle.class ./DumperOptions$Version.class ./DumperOptions.class ./TypeDescription.class ... (many more!)
flink-shaded-jackson-2.9.8-7.0/org/apache/flink/shaded/jackson2/com/fasterxml/jackson/dataformat/yaml/snakeyaml> find . . ./error ./error/Mark.class ./error/MarkedYAMLException.class ./error/YAMLException.class The same is true in the artifacts that were built for maven central [4] Nico [4] https://repository.apache.org/content/repositories/orgapacheflink-1219 On 28/05/2019 14:57, Chesnay Schepler wrote: > @Nico I still see snakeyaml in the flink-shaded-jackson jars, and in the > dependency tree. It even takes up more space than before. > AFAIK we do not work directly against the contained snakeyaml version, > so we should be fine in any case. > > On 27/05/2019 16:45, Nico Kruber wrote: >> +1 (mod jackson snakeyaml support; see below) >> >> - checked release notes >> - verified signatures (sha512, asc) >> - verified "mvn clean package -Pinclude-netty-tcnative-static" >> - compared contents and verified changes of >> + flink-shaded-asm-6*.jar >> + flink-shaded-guava-18.0*.jar >> + flink-shaded-netty-4.1.32.Final*.jar >> + flink-shaded-jackson*.jar >> -> this appears to not support snakeyaml anymore (a lot of classes are >> dropped in our packages)? Will this be a problem? >> + flink-shaded-jackson-module-jsonSchema*.jar >> >> On 27/05/2019 15:48, Timo Walther wrote: >>> I quickly scanned the changes and could not spot any issues. >>> >>> +1 >>> >>> Am 27.05.19 um 13:36 schrieb Chesnay Schepler: >>>> +1 >>>> >>>> * git tag exists >>>> * no binaries in release >>>> * relocated jackson no longer bundled twice in hadoop jars >>>> * jackson dependency tree exists >>>> * netty-tcnative-static not part of release >>>> * artifacts present for each hadoop version >>>> * compared contents of each hadoop jar with the current ones, no >>>> significant differences >>>> >>>> On 27/05/2019 03:23, jincheng sun wrote: >>>>> Hi all, >>>>> >>>>> Please review and vote on the release candidate #3 for the version >>>>> 7.0, as >>>>> follows: >>>>> >>>>> [ ] +1, Approve the release >>>>> [ ] -1, Do not approve the release (please provide specific comments) >>>>> >>>>> The complete staging area is available for your review, which >>>>> includes: >>>>> * JIRA release notes [1], >>>>> * the official Apache source release to be deployed to >>>>> dist.apache.org [2], >>>>> which are signed with the key with fingerprint >>>>> 8FEA1EE9D0048C0CCC70B7573211B0703B79EA0E [3], >>>>> * all artifacts to be deployed to the Maven Central Repository [4], >>>>> * source code tag "release-7.0-rc3" [5], >>>>> * website pull request listing the new release [6]. >>>>> >>>>> The vote will be open for at least 72 hours. It is adopted by majority >>>>> approval, with at least 3 PMC affirmative votes. >>>>> >>>>> Thanks, >>>>> Jincheng >>>>> >>>>> [1] >>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345226&styleName=Html&projectId=12315522&Create=Create&atl_token=A5KQ-2QAV-T4JA-FDED%7C8ba061049bec0c5a72dc0191c47bb53a73b82cb4%7Clin >>>>> >>>>> >>>>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-shaded-7.0-rc3/ >>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >>>>> [4] >>>>> https://repository.apache.org/content/repositories/orgapacheflink-1219 >>>>> [5] https://github.com/apache/flink-shaded/tree/release-7.0-rc3 >>>>> [6] https://github.com/apache/flink-web/pull/209 >>>>> > -- Nico Kruber | Solutions Architect Follow us @VervericaData Ververica -- Join Flink Forward - The Apache Flink Conference Stream Processing | Event Driven | Real Time -- Data Artisans GmbH | Invalidenstrasse 115, 10115 Berlin, Germany -- Data Artisans GmbH Registered at Amtsgericht Charlottenburg: HRB 158244 B Managing Directors: Dr. Kostas Tzoumas, Dr. Stephan Ewen
signature.asc
Description: OpenPGP digital signature
