Re: [VOTE] Release flink-connector-pulsar, release candidate #1

2023-05-08 Thread Martijn Visser
(Apologies for the previous email, that's a copy & paste error from the email above where I had already voted) Thanks all. This vote is now closed, I'll announce the results in a separate thread. On Mon, May 8, 2023 at 2:07 PM Martijn Visser wrote: > +1 (binding) > > - Validated hashes > - Veri

Re: [VOTE] Release flink-connector-pulsar, release candidate #1

2023-05-08 Thread Martijn Visser
+1 (binding) - Validated hashes - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven - Verified licenses - Verified web PRs On Thu, May 4, 2023 at 5:17 AM Leonard Xu wrote: > +1 (binding) > > - built from source code succeeded > - verified

Re: [VOTE] Release flink-connector-pulsar, release candidate #1

2023-05-03 Thread Leonard Xu
+1 (binding) - built from source code succeeded - verified signatures - verified hashsums - checked Github release tag - checked release notes - reviewed the web PR and left minor comment Best, Leonard > 2023年4月24日 下午5:13,Danny Cranmer 写道: > > +1 (binding) > > - Release notes look ok > - Ve

Re: [VOTE] Release flink-connector-pulsar, release candidate #1

2023-04-24 Thread Danny Cranmer
+1 (binding) - Release notes look ok - Verified signature and hashes of source archive - Tag is present in Github - Reviewed Web PR - Contents of MAven repo look good - No binaries in the source archive - Built source with Maven - Verified NOTICE files Some observations - Nightly CI is failing bu

Re: [VOTE] Release flink-connector-pulsar, release candidate #1

2023-04-19 Thread Martijn Visser
@Yufan can you make sure that these changes are properly included in the closed Jira tickets, under "Release Notes" ? +1 (binding) - Validated hashes - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven - Verified licenses - Verified web PRs

Re: [VOTE] Release flink-connector-pulsar, release candidate #1

2023-04-13 Thread Yufan Sheng
+1 from the developer of flink-connector-pulsar I just want to add the comments here for the newly introduced breaking changes in 4.0.0 Breaking Changes Some classes and interfaces which are annotated with @PublicEvolving have been changed in this release. And this may affect the end-users. Pul

[VOTE] Release flink-connector-pulsar, release candidate #1

2023-04-13 Thread Martijn Visser
Hi everyone, Please review and vote on the release candidate #1 for the version 4.0.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], *