Re: [VOTE] Release flink-connector-kafka 3.0.0 for Flink 1.17, release candidate #2

2023-04-21 Thread Maximilian Michels
Thanks for driving the release Gordon! -Max On Fri, Apr 21, 2023 at 12:33 AM Tzu-Li (Gordon) Tai wrote: > > We have unanimously approved this release. > > There are 6 approving votes, 3 of which are binding: > > * Alexander Sorokoumov > * Martijn Visser (binding) > * Tzu-Li (Gordon) Tai (binding

Re: [VOTE] Release flink-connector-kafka 3.0.0 for Flink 1.17, release candidate #2

2023-04-20 Thread Tzu-Li (Gordon) Tai
We have unanimously approved this release. There are 6 approving votes, 3 of which are binding: * Alexander Sorokoumov * Martijn Visser (binding) * Tzu-Li (Gordon) Tai (binding) * Danny Cranmer (binding) * Ahmed Hamdy * Mason Chen Thanks so much everyone for testing and voting! I will now finali

Re: [VOTE] Release flink-connector-kafka 3.0.0 for Flink 1.17, release candidate #2

2023-04-20 Thread Mason Chen
+1 (non-binding) * Verified hashes and signatures * Verified no binaries * Verified LICENSE and NOTICE files, pointing to 2023 as well * Verified poms point to 3.0.0 * Reviewed web PR * Built from source * Verified git tag Best, Mason On Thu, Apr 20, 2023 at 10:04 AM Ahmed Hamdy wrote: > +1 (n

Re: [VOTE] Release flink-connector-kafka 3.0.0 for Flink 1.17, release candidate #2

2023-04-20 Thread Ahmed Hamdy
+1 (non-binding) - Release notes look good. - verified signatures and checksums are correct. - Verified no binaries in source archive. - Built from source - Approved Web PR (no comments if we are supporting 1.17+) Best Regards Ahmed On Thu, 20 Apr 2023 at 17:08, Danny Cranmer wrote: > +1 (bindi

Re: [VOTE] Release flink-connector-kafka 3.0.0 for Flink 1.17, release candidate #2

2023-04-20 Thread Danny Cranmer
+1 (binding) - +1 on skipping 1.16 - Release notes look ok - Verified signature/hashes of source archive - Verified there are no binaries in the source archive - Built from source - Contents of Maven repo look good - Verified NOTICE files - Tag exists in Github - Reviewed web PR (looks good apart

Re: [VOTE] Release flink-connector-kafka 3.0.0 for Flink 1.17, release candidate #2

2023-04-18 Thread Tzu-Li (Gordon) Tai
+1 (binding) - Checked hashes and signatures - Built from source mvn clean install -Pcheck-convergence -Dflink.version=1.17.0 - Eyeballed NOTICE license files - Started a Flink 1.17.0 cluster + Kafka 3.2.3 cluster, submitted a SQL statement using the Kafka connector under exactly-once mode. Checkp

Re: [VOTE] Release flink-connector-kafka 3.0.0 for Flink 1.17, release candidate #2

2023-04-14 Thread Martijn Visser
+1 (binding) - Validated hashes - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven via mvn clean install -Pcheck-convergence -Dflink.version=1.17.0 - Verified licenses - Verified web PR - Started a cluster and the Flink SQL client, successful

Re: [VOTE] Release flink-connector-kafka 3.0.0 for Flink 1.17, release candidate #2

2023-04-13 Thread Alexander Sorokoumov
+1 (nb). Checked: - checksums are correct - source code builds (JDK 8+11) - release notes are correct Best, Alex On Wed, Apr 12, 2023 at 5:07 PM Tzu-Li (Gordon) Tai wrote: > A few important remarks about this release candidate: > > - As mentioned in the previous voting thread of RC

Re: [VOTE] Release flink-connector-kafka 3.0.0 for Flink 1.17, release candidate #2

2023-04-12 Thread Tzu-Li (Gordon) Tai
A few important remarks about this release candidate: - As mentioned in the previous voting thread of RC1 [1], we've decided to skip releasing a version of the externalized Flink Kafka Connector matching with Flink 1.16.x since the original vote thread stalled, and meanwhile we've already complete

[VOTE] Release flink-connector-kafka 3.0.0 for Flink 1.17, release candidate #2

2023-04-12 Thread Tzu-Li (Gordon) Tai
Hi everyone, Please review and vote on release candidate #2 for version 3.0.0 of the Apache Flink Kafka Connector, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: