+1 (binding) - +1 on skipping 1.16 - Release notes look ok - Verified signature/hashes of source archive - Verified there are no binaries in the source archive - Built from source - Contents of Maven repo look good - Verified NOTICE files - Tag exists in Github - Reviewed web PR (looks good apart from the open comment from Martijn)
On Tue, Apr 18, 2023 at 6:38 PM Tzu-Li (Gordon) Tai <tzuli...@apache.org> wrote: > +1 (binding) > > - Checked hashes and signatures > - Built from source mvn clean install -Pcheck-convergence > -Dflink.version=1.17.0 > - Eyeballed NOTICE license files > - Started a Flink 1.17.0 cluster + Kafka 3.2.3 cluster, submitted a SQL > statement using the Kafka connector under exactly-once mode. Checkpointing > and restoring works, with or without throughput on the Kafka topic. > > Thanks, > Gordon > > On Fri, Apr 14, 2023 at 2:13 AM Martijn Visser <martijnvis...@apache.org> > wrote: > > > +1 (binding) > > > > - Validated hashes > > - Verified signature > > - Verified that no binaries exist in the source archive > > - Build the source with Maven via mvn clean install -Pcheck-convergence > > -Dflink.version=1.17.0 > > - Verified licenses > > - Verified web PR > > - Started a cluster and the Flink SQL client, successfully read and wrote > > with the Kafka connector to Confluent Cloud with AVRO and Schema Registry > > enabled > > > > On Fri, Apr 14, 2023 at 12:24 AM Alexander Sorokoumov > > <asorokou...@confluent.io.invalid> wrote: > > > > > +1 (nb). > > > > > > Checked: > > > > > > - checksums are correct > > > - source code builds (JDK 8+11) > > > - release notes are correct > > > > > > > > > Best, > > > Alex > > > > > > > > > On Wed, Apr 12, 2023 at 5:07 PM Tzu-Li (Gordon) Tai < > tzuli...@apache.org > > > > > > wrote: > > > > > > > A few important remarks about this release candidate: > > > > > > > > - As mentioned in the previous voting thread of RC1 [1], we've > decided > > to > > > > skip releasing a version of the externalized Flink Kafka Connector > > > matching > > > > with Flink 1.16.x since the original vote thread stalled, and > meanwhile > > > > we've already completed externalizing all Kafka connector code as of > > > Flink > > > > 1.17.0. > > > > > > > > - As such, this RC is basically identical to the Kafka connector code > > > > bundled with the Flink 1.17.0 release, PLUS a few critical fixes for > > > > exactly-once violations, namely FLINK-31305, FLINK-31363, and > > FLINK-31620 > > > > (please see release notes [2]). > > > > > > > > - As part of preparing this RC, I've also deleted the original v3.0 > > > branch > > > > and re-named the v4.0 branch to replace it instead. Effectively, this > > > > resets the versioning numbers for the externalized Flink Kafka > > Connector > > > > code repository, so that this first release of the repo starts from > > > v3.0.0. > > > > > > > > Thanks, > > > > Gordon > > > > > > > > [1] https://lists.apache.org/thread/r97y5qt8x0c72460vs5cjm5c729ljmh6 > > > > [2] > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352577 > > > > > > > > On Wed, Apr 12, 2023 at 4:55 PM Tzu-Li (Gordon) Tai < > > tzuli...@apache.org > > > > > > > > wrote: > > > > > > > > > Hi everyone, > > > > > > > > > > Please review and vote on release candidate #2 for version 3.0.0 of > > the > > > > > Apache Flink Kafka Connector, as follows: > > > > > [ ] +1, Approve the release > > > > > [ ] -1, Do not approve the release (please provide specific > comments) > > > > > > > > > > > > > > > The complete staging area is available for your review, which > > includes: > > > > > * JIRA release notes [1], > > > > > * the official Apache source release to be deployed to > > dist.apache.org > > > > > [2], which are signed with the key with fingerprint > > > > > 1C1E2394D3194E1944613488F320986D35C33D6A [3], > > > > > * all artifacts to be deployed to the Maven Central Repository [4], > > > > > * source code tag v3.0.0-rc2 [5], > > > > > * website pull request listing the new release [6]. > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > > majority > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > Thanks, > > > > > Gordon > > > > > > > > > > [1] > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352577 > > > > > [2] > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.0-rc2/ > > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > [4] > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1607 > > > > > [5] > > > > > > > > > https://github.com/apache/flink-connector-kafka/releases/tag/v3.0.0-rc2 > > > > > [6] https://github.com/apache/flink-web/pull/632 > > > > > > > > > > > > > > >
