Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-06-15 Thread Martijn Visser
Hi all, Apologies for the long delay on this one, but with the help of Sergey Nuyanzin and Joao Boto we managed to resolve this issue. To summarize: 1. The vote for this connector is cancelled, due to https://issues.apache.org/jira/browse/FLINK-31770 2. That Jira ticket has now been resolved 3. W

Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-06-06 Thread Chesnay Schepler
I'm a bit concerned that the last 4 CI runs haven't succeeded in the 3.1 branch. Has anyone looked into the failing oracle test (both 1.17/1.18)? https://github.com/apache/flink-connector-jdbc/actions/runs/5058372107/jobs/9078398092 Why is a vote being opened when there's still a blocker ticket

Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-06-01 Thread Sergey Nuyanzin
+1 (non-binding) * built from source * verified signatures and hashsums * checked release notes * reviewed web PR thanks for driving this On Thu, Jun 1, 2023 at 8:15 PM Ahmed Hamdy wrote: > Hi Martijn, > > +1 (non-binding) > > - built from source code succeeded > - verified signatures match yo

Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-06-01 Thread Ahmed Hamdy
Hi Martijn, +1 (non-binding) - built from source code succeeded - verified signatures match yours - verified hashsums - checked release notes - reviewed the web PR Best regards, Ahmed Hamdy On Wed, 31 May 2023 at 09:33, Leonard Xu wrote: > +1 (binding) > > - built from source code succeeded >

Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-05-31 Thread Leonard Xu
+1 (binding) - built from source code succeeded - verified signatures - verified hashsums - checked Github release tag, left one minor comment about the release commit - checked release notes - checked the contents contains jar and pom files in apache repo - reviewed the web PR Best, Leonard

Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-05-29 Thread Yuxin Tan
+1 (non-binding) - Checked sign - Checked the hash - Checked tag - Build from source Best, Yuxin weijie guo 于2023年5月29日周一 14:14写道: > +1 (non-binding) > > - checked sign and checksum > - checked tag in github repository > - compiled from source > - checked the web PR > > BTW, please remember t

Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-05-28 Thread weijie guo
+1 (non-binding) - checked sign and checksum - checked tag in github repository - compiled from source - checked the web PR BTW, please remember to update docs/jdbc.yaml for the v3.1 branch after the release is completed. Best regards, Weijie Jing Ge 于2023年5月29日周一 04:26写道: > +1 (non-binding

Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-05-28 Thread Jing Ge
+1 (non-binding) - checked sign - checked hash - checked repos - checked tag - compiled from source - check the web PR Best regards, Jing On Sun, May 28, 2023 at 4:00 PM Benchao Li wrote: > Thanks Martijn, > > - checked signature/checksum [OK] > - downloaded src, compiled from source [OK] > -

Re: [VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-05-28 Thread Benchao Li
Thanks Martijn, - checked signature/checksum [OK] - downloaded src, compiled from source [OK] - diffed src and tag, no binary files [OK] - gone through nexus staging area, looks good [OK] - run with flink 1.7.1 [OK] One thing I spotted is that the version in `docs/data/jdbc.yml` is still 3.1.0, I

[VOTE] Release flink-connector-jdbc v3.1.1, release candidate #1

2023-05-24 Thread Martijn Visser
Hi everyone, Please review and vote on the release candidate #1 for the version 3.1.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], *