+1 (binding) - built from source code succeeded - verified signatures - verified hashsums - checked Github release tag, left one minor comment about the release commit - checked release notes - checked the contents contains jar and pom files in apache repo - reviewed the web PR
Best, Leonard > On May 30, 2023, at 1:56 PM, Yuxin Tan <tanyuxinw...@gmail.com> wrote: > > +1 (non-binding) > > - Checked sign > - Checked the hash > - Checked tag > - Build from source > > Best, > Yuxin > > > weijie guo <guoweijieres...@gmail.com> 于2023年5月29日周一 14:14写道： > >> +1 (non-binding) >> >> - checked sign and checksum >> - checked tag in github repository >> - compiled from source >> - checked the web PR >> >> BTW, please remember to update docs/jdbc.yaml for the v3.1 branch after the >> release is completed. >> >> Best regards, >> >> Weijie >> >> >> Jing Ge <j...@ververica.com.invalid> 于2023年5月29日周一 04:26写道： >> >>> +1 (non-binding) >>> >>> - checked sign >>> - checked hash >>> - checked repos >>> - checked tag >>> - compiled from source >>> - check the web PR >>> >>> Best regards, >>> Jing >>> >>> >>> On Sun, May 28, 2023 at 4:00 PM Benchao Li <libenc...@apache.org> wrote: >>> >>>> Thanks Martijn, >>>> >>>> - checked signature/checksum [OK] >>>> - downloaded src, compiled from source [OK] >>>> - diffed src and tag, no binary files [OK] >>>> - gone through nexus staging area, looks good [OK] >>>> - run with flink 1.7.1 [OK] >>>> >>>> One thing I spotted is that the version in `docs/data/jdbc.yml` is >> still >>>> 3.1.0, I'm not sure whether this should be a blocker. >>>> >>>> >>>> Martijn Visser <martijnvis...@apache.org> 于2023年5月25日周四 02:55写道： >>>> >>>>> Hi everyone, >>>>> Please review and vote on the release candidate #1 for the version >>> 3.1.1, >>>>> as follows: >>>>> [ ] +1, Approve the release >>>>> [ ] -1, Do not approve the release (please provide specific comments) >>>>> >>>>> >>>>> The complete staging area is available for your review, which >> includes: >>>>> * JIRA release notes [1], >>>>> * the official Apache source release to be deployed to >> dist.apache.org >>>>> [2], >>>>> which are signed with the key with fingerprint >>>>> A5F3BCE4CBE993573EC5966A65321B8382B219AF [3], >>>>> * all artifacts to be deployed to the Maven Central Repository [4], >>>>> * source code tag v3.1.1-rc1 [5], >>>>> * website pull request listing the new release [6]. >>>>> >>>>> The vote will be open for at least 72 hours. It is adopted by >> majority >>>>> approval, with at least 3 PMC affirmative votes. >>>>> >>>>> Thanks, >>>>> Release Manager >>>>> >>>>> [1] >>>>> >>>>> >>>> >>> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353281 >>>>> [2] >>>>> >>>> >>> >> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.1-rc1 >>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >>>>> [4] >>>>> >>> https://repository.apache.org/content/repositories/orgapacheflink-1636/ >>>>> [5] >>>> https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.1-rc1 >>>>> [6] https://github.com/apache/flink-web/pull/654 >>>>> >>>> >>>> >>>> -- >>>> >>>> Best, >>>> Benchao Li >>>> >>> >>
