Re: [VOTE] Release flink-connector-elasticsearch v4.0.0, release candidate #1

2025-04-10 Thread weijie guo
Thanks all This release candidate has been officially cancelled. I will fix the problems with NOTICE and target jdk version in rc2. Best regards, Weijie Yanquan Lv 于2025年4月9日周三 18:04写道: > Hi, Weijie. > > Sorry for reply again, But I found that the major version of the release > jar is 52 usi

Re: [VOTE] Release flink-connector-elasticsearch v4.0.0, release candidate #1

2025-04-09 Thread Yanquan Lv
Hi, Weijie. Sorry for reply again, But I found that the major version of the release jar is 52 using `javap -classpath flink-sql-connector-elasticsearch7-4.0.0-2.0.jar -verbose org.apache.flink.connector.elasticsearch.Elasticsearch7ApiCallBridge | grep version`, Is this not as expected? Do we need

Re: [VOTE] Release flink-connector-elasticsearch v4.0.0, release candidate #1

2025-04-09 Thread Xiqian YU
+1 (non-binding) Checklist: - Verified tarball checksum & signatures are valid - Compiled source code locally with JDK 17 - Ran unit test cases locally and all passed - Confirmed dist jars are targeted to 52.0 (Java 8) - Reviewed release notes and flink-web PR Best Regards, Xiqian > 2025年4月9日 1

Re: [VOTE] Release flink-connector-elasticsearch v4.0.0, release candidate #1

2025-04-08 Thread Yanquan Lv
+1 (non-binding) I checked: - Review JIRA release notes - Verify hashes and verify signatures - Build success from source with JDK11 & maven3.8.6 - Source code artifacts matching the current release - Read the announcement blog and LGTM - Run a datagen to elasticsearch7 test with Flink 2.0 cluster

Re: [VOTE] Release flink-connector-elasticsearch v4.0.0, release candidate #1

2025-04-08 Thread Hongshun Wang
Hi Weijie Should we update NOTICE[1] to 2025 before release? [1] https://github.com/apache/flink-connector-elasticsearch/blob/main/NOTICE Best Hongshun On Mon, Apr 7, 2025 at 8:06 PM Zakelly Lan wrote: > +1 (binding) > > I have verified: > > - Checksum and signature > - There are no binaries

Re: [VOTE] Release flink-connector-elasticsearch v4.0.0, release candidate #1

2025-04-07 Thread Zakelly Lan
+1 (binding) I have verified: - Checksum and signature - There are no binaries in the source archive - Release tag and staging jars - Built from source - Release notes and web PR not a blocker: better update the NOTICE to year 2025 On Thu, Apr 3, 2025 at 2:12 PM weijie guo wrote: > Hi ev

[VOTE] Release flink-connector-elasticsearch v4.0.0, release candidate #1

2025-04-05 Thread weijie guo
Hi everyone, Please review and vote on the release candidate #1 for v4.0.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) This release is mainly for flink 2.0. The complete staging area is available for your review, which inclu