+1 (non-binding) Checklist:
- Verified tarball checksum & signatures are valid - Compiled source code locally with JDK 17 - Ran unit test cases locally and all passed - Confirmed dist jars are targeted to 52.0 (Java 8) - Reviewed release notes and flink-web PR Best Regards, Xiqian > 2025年4月9日 11:18，Hongshun Wang <loserwang1...@gmail.com> 写道： > > Hi Weijie > > Should we update NOTICE[1] to 2025 before release? > [1] https://github.com/apache/flink-connector-elasticsearch/blob/main/NOTICE > > Best > Hongshun > > On Mon, Apr 7, 2025 at 8:06 PM Zakelly Lan <zakelly....@gmail.com> wrote: > >> +1 (binding) >> >> I have verified: >> >> - Checksum and signature >> - There are no binaries in the source archive >> - Release tag and staging jars >> - Built from source >> - Release notes and web PR >> >> not a blocker: better update the NOTICE to year 2025 >> >> On Thu, Apr 3, 2025 at 2:12 PM weijie guo <guoweijieres...@gmail.com> >> wrote: >> >>> Hi everyone, >>> >>> >>> Please review and vote on the release candidate #1 for v4.0.0, as >> follows: >>> >>> [ ] +1, Approve the release >>> >>> [ ] -1, Do not approve the release (please provide specific comments) >>> >>> >>> This release is mainly for flink 2.0. >>> >>> >>> The complete staging area is available for your review, which includes: >>> >>> * JIRA release notes [1], >>> >>> * the official Apache source release to be deployed to dist.apache.org >>> [2], >>> >>> which are signed with the key with fingerprint >>> 8D56AE6E7082699A4870750EA4E8C4C05EE6861F [3], >>> >>> * all artifacts to be deployed to the Maven Central Repository [4], >>> >>> * source code tag v4.0.0-rc1 [5], >>> >>> * website pull request listing the new release [6]. >>> >>> * CI build of tag [7]. >>> >>> >>> The vote will be open for at least 72 hours. It is adopted by majority >>> >>> approval, with at least 3 PMC affirmative votes. >>> >>> >>> Thanks, >>> >>> Weijie >>> >>> [1] >>> >>> >>> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12355810 >>> >>> [2] >>> >>> >>> >> https://dist.apache.org/repos/dist/dev/flink/flink-connector-elasticsearch-4.0.0-rc1/ >>> >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >>> >>> [4] >>> https://repository.apache.org/content/repositories/orgapacheflink-1796/ >>> >>> [5] >>> >>> >>> >> https://github.com/apache/flink-connector-elasticsearch/releases/tag/v4.0.0-rc1 >>> >>> [6] https://github.com/apache/flink-web/pull/786 >>> >>> [7] >>> >>> >>> >> https://github.com/apache/flink-connector-elasticsearch/actions/runs/14215074324 >>> >>
