Re: [RESULT] [VOTE] Release 1.8.0, release candidate #5

Very happy to see flink1.8 can be released! Thank you very much for your efforts. @Aljoscha Krettek ! Because I just ran all the tests, so sorry for the late vote! Although the vote is over, I still share the results of my inspection. :) The check for new changes(RC4 -> RC5): 1). Run Kafka09I

[RESULT] [VOTE] Release 1.8.0, release candidate #5

I'm happy to announce that we have unanimously approved this release. There are 5 approving votes, 4 of which are binding: * Rong * Chesnay * Thomas * Gordon * Aljoscha (I’m hereby +1’ing) There are no disapproving votes. Thanks everyone! > On 9. Apr 2019, at 10:22, Aljoscha Krettek wrote:

Re: [VOTE] Release 1.8.0, release candidate #5

Thanks everyone for checking the release and voting! I’ll tally the results in a separate email. > On 8. Apr 2019, at 10:04, Aljoscha Krettek wrote: > > @Thomas There is a note about this in the documentation release notes: > https://github.com/apache/flink/blob/5d46437fee92a6e1ec8c0653849a6b2

Re: [VOTE] Release 1.8.0, release candidate #5

@Thomas There is a note about this in the documentation release notes: https://github.com/apache/flink/blob/5d46437fee92a6e1ec8c0653849a6b27733e99ad/docs/release-notes/flink-1.8.md#change-in-the-maven-modules-of-table-api-flink-11064

Re: [VOTE] Release 1.8.0, release candidate #5

+1 (binding) Carried over from previous vote on earlier RC, with the following additional tests: - Verified a few upgrade scenarios for the key / namespace serializer in RocksDB state backend - Verified checksums and signatures - Built source (without Hadoop, Scala 2.11 + Scala 2.12) with success

Re: [VOTE] Release 1.8.0, release candidate #5

+1 (binding) * verified checksums and signatures * run release build, built internal packages, run few internal tests Couple observations: Table API artifact change: https://issues.apache.org/jira/browse/FLINK-11064 JIRA mentions the change, but should we be more explicit and add that info into

Re: [VOTE] Release 1.8.0, release candidate #5

Missed that one :/ On 06/04/2019 08:29, Aljoscha Krettek wrote: Ah, the first two are not on 1.8.0-rc5, but FLINK-11855 is. On 6. Apr 2019, at 08:23, Aljoscha Krettek wrote: Thanks, Chesnay! I had that tab open already and was prepared to do it but it’s good you also thought about it. :-) W

Re: [VOTE] Release 1.8.0, release candidate #5

Ah, the first two are not on 1.8.0-rc5, but FLINK-11855 is. > On 6. Apr 2019, at 08:23, Aljoscha Krettek wrote: > > Thanks, Chesnay! I had that tab open already and was prepared to do it but > it’s good you also thought about it. :-) What about these three issues, > though: > https://issues.a

Re: [VOTE] Release 1.8.0, release candidate #5

Thanks, Chesnay! I had that tab open already and was prepared to do it but it’s good you also thought about it. :-) What about these three issues, though: https://issues.apache.org/jira/issues/?filter=12334772&jql=project%20%3D%20FLINK%20AND%20fixVersion%20%3D%201.8.1%20and%20resolution%20!%3D%20

Re: [VOTE] Release 1.8.0, release candidate #5

Went through JIRA and update the versions. On 05/04/2019 13:57, Chesnay Schepler wrote: +1 We'll have to comb through JIRA again as I already found a number of tickets that were marked as fixed for 1.8.1, but are included in this RC. On 05/04/2019 07:10, Rong Rong wrote: +1 (non-binding) *

Re: [VOTE] Release 1.8.0, release candidate #5

+1 We'll have to comb through JIRA again as I already found a number of tickets that were marked as fixed for 1.8.1, but are included in this RC. On 05/04/2019 07:10, Rong Rong wrote: +1 (non-binding) * Verified checksums and GPG files matches release files * Verified that the source archive

Re: [VOTE] Release 1.8.0, release candidate #5

+1 (non-binding) * Verified checksums and GPG files matches release files * Verified that the source archives do not contain any binaries * Built the source with Maven to ensure all source files have Apache headers * Checked that all POM files point to the same version * `mvn clean verify` against

[VOTE] Release 1.8.0, release candidate #5

Hi everyone, Please review and vote on the release candidate 5 for Flink 1.8.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], * the off