I'm happy to announce that we have unanimously approved this release. There are 5 approving votes, 4 of which are binding: * Rong * Chesnay * Thomas * Gordon * Aljoscha (I’m hereby +1’ing) There are no disapproving votes. Thanks everyone!
> On 9. Apr 2019, at 10:22, Aljoscha Krettek <aljos...@apache.org> wrote: > > Thanks everyone for checking the release and voting! I’ll tally the results > in a separate email. > >> On 8. Apr 2019, at 10:04, Aljoscha Krettek <aljos...@apache.org> wrote: >> >> @Thomas There is a note about this in the documentation release notes: >> https://github.com/apache/flink/blob/5d46437fee92a6e1ec8c0653849a6b27733e99ad/docs/release-notes/flink-1.8.md#change-in-the-maven-modules-of-table-api-flink-11064 >> >> <https://github.com/apache/flink/blob/5d46437fee92a6e1ec8c0653849a6b27733e99ad/docs/release-notes/flink-1.8.md#change-in-the-maven-modules-of-table-api-flink-11064>. >> I’ll add this to the release blog post. >> >> The shaded hadoop2 version number is like this to satisfy our build infra. >> If it were the other way round we would have >> flink-shaded-hadoop2-1.9-SNAPSHOT-2.8.3, and I think the nightly maven >> snapshot repos don’t accept that as a snapshot version and our nightly >> releases were not built for a while because of this. >> >> Aljoscha >> >>> On 8. Apr 2019, at 08:54, Tzu-Li (Gordon) Tai <tzuli...@apache.org> wrote: >>> >>> +1 (binding) >>> >>> Carried over from previous vote on earlier RC, with the following >>> additional tests: >>> >>> - Verified a few upgrade scenarios for the key / namespace serializer in >>> RocksDB state backend >>> - Verified checksums and signatures >>> - Built source (without Hadoop, Scala 2.11 + Scala 2.12) with success >>> - Ran end-to-end tests locally >>> >>> Cheers, >>> Gordon >>> >>> On Mon, Apr 8, 2019 at 5:36 AM Thomas Weise <t...@apache.org> wrote: >>> >>>> +1 (binding) >>>> >>>> * verified checksums and signatures >>>> * run release build, built internal packages, run few internal tests >>>> >>>> Couple observations: >>>> >>>> Table API artifact change: >>>> https://issues.apache.org/jira/browse/FLINK-11064 >>>> >>>> JIRA mentions the change, but should we be more explicit and add that info >>>> into the release blog/notes? >>>> >>>> The version number for shaded hadoop2 surprised me: >>>> >>>> Example: flink-shaded-hadoop2-2.8.3-1.8.0.jar >>>> >>>> If 2.8.3 is part of the version number (vs. artifactId), then shouldn't the >>>> version number be 1.8.0-2.8.3? (Alternatively, the hadoop version could be >>>> included into artifactId.) >>>> >>>> Thomas >>>> >>>> On Sun, Apr 7, 2019 at 12:15 PM Chesnay Schepler <ches...@apache.org> >>>> wrote: >>>> >>>>> Missed that one :/ >>>>> >>>>> On 06/04/2019 08:29, Aljoscha Krettek wrote: >>>>>> Ah, the first two are not on 1.8.0-rc5, but FLINK-11855 is. >>>>>> >>>>>>> On 6. Apr 2019, at 08:23, Aljoscha Krettek <aljos...@apache.org> >>>> wrote: >>>>>>> >>>>>>> Thanks, Chesnay! I had that tab open already and was prepared to do it >>>>> but it’s good you also thought about it. :-) What about these three >>>> issues, >>>>> though: >>>>> >>>> https://issues.apache.org/jira/issues/?filter=12334772&jql=project%20%3D%20FLINK%20AND%20fixVersion%20%3D%201.8.1%20and%20resolution%20!%3D%20unresolved%20ORDER%20BY%20updated%20DESC >>>>> < >>>>> >>>> https://issues.apache.org/jira/issues/?filter=12334772&jql=project%20=%20FLINK%20AND%20fixVersion%20=%201.8.1%20and%20resolution%20!=%20unresolved%20ORDER%20BY%20updated%20DESC >>>>>> >>>>>>> >>>>>>> Aljoscha >>>>>>> >>>>>>>> On 5. Apr 2019, at 14:05, Chesnay Schepler <ches...@apache.org> >>>> wrote: >>>>>>>> >>>>>>>> Went through JIRA and update the versions. >>>>>>>> >>>>>>>> On 05/04/2019 13:57, Chesnay Schepler wrote: >>>>>>>>> +1 >>>>>>>>> >>>>>>>>> We'll have to comb through JIRA again as I already found a number of >>>>> tickets that were marked as fixed for 1.8.1, but are included in this RC. >>>>>>>>> >>>>>>>>> On 05/04/2019 07:10, Rong Rong wrote: >>>>>>>>>> +1 (non-binding) >>>>>>>>>> >>>>>>>>>> * Verified checksums and GPG files matches release files >>>>>>>>>> * Verified that the source archives do not contain any binaries >>>>>>>>>> * Built the source with Maven to ensure all source files have >>>> Apache >>>>> headers >>>>>>>>>> * Checked that all POM files point to the same version >>>>>>>>>> * `mvn clean verify` against scala-2.11 and scala-2.12 >>>>>>>>>> - Also verified rest.port setting is taking effect after >>>>>>>>>> YarnClusterEntryUtils change >>>>>>>>>> * Verified quickstart-scala and quickstart-java are working with >>>> the >>>>> staging >>>>>>>>>> repository. >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Rong >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Wed, Apr 3, 2019 at 11:22 PM Aljoscha Krettek < >>>>> aljos...@apache.org> >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Hi everyone, >>>>>>>>>>> Please review and vote on the release candidate 5 for Flink 1.8.0, >>>>> as >>>>>>>>>>> follows: >>>>>>>>>>> [ ] +1, Approve the release >>>>>>>>>>> [ ] -1, Do not approve the release (please provide specific >>>>> comments) >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> The complete staging area is available for your review, which >>>>> includes: >>>>>>>>>>> * JIRA release notes [1], >>>>>>>>>>> * the official Apache source release and binary convenience >>>>> releases to be >>>>>>>>>>> deployed to dist.apache.org [2], which are signed with the key >>>> with >>>>>>>>>>> fingerprint F2A67A8047499BBB3908D17AA8F4FD97121D7293 [3], >>>>>>>>>>> * all artifacts to be deployed to the Maven Central Repository >>>> [4], >>>>>>>>>>> * source code tag "release-1.8.0-rc5" [5], >>>>>>>>>>> * website pull request listing the new release [6] >>>>>>>>>>> * website pull request adding announcement blog post [7]. >>>>>>>>>>> >>>>>>>>>>> The vote will be open for at least 72 hours. It is adopted by >>>>> majority >>>>>>>>>>> approval, with at least 3 PMC affirmative votes. >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Aljoscha >>>>>>>>>>> >>>>>>>>>>> [1] >>>>>>>>>>> >>>>> >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12344274 >>>>>>>>>>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.8.0-rc5/ >>>>>>>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >>>>>>>>>>> [4] >>>>> https://repository.apache.org/content/repositories/orgapacheflink-1216 >>>>>>>>>>> [5] >>>>>>>>>>> >>>>> >>>> https://gitbox.apache.org/repos/asf?p=flink.git;a=tag;h=33943b15f9eca3fafbd88b9315cf9f0a083b6381 >>>>>>>>>>> [6] https://github.com/apache/flink-web/pull/180 >>>>>>>>>>> [7] https://github.com/apache/flink-web/pull/179 >>>>>>>>>>> >>>>>>>>>>> P.S. The difference to the previous RCs is small, you can fetch >>>> the >>>>> tags >>>>>>>>>>> and do a "git log release-1.8.0-rc1..release-1.8.0-rc5” to see the >>>>>>>>>>> difference in commits. Its fixes for the issues that led to the >>>>>>>>>>> cancellation of the previous RCs plus smaller fixes. Most >>>>>>>>>>> verification/testing that was carried out should apply as is to >>>>> this RC. >>>>>>>>>>> Any functional verification that you did on previous RCs should >>>>> therefore >>>>>>>>>>> easily carry over to this one. This does add one new feature for >>>>> the Kafka >>>>>>>>>>> connector that was on master for quite a while but not on >>>>> release-1.8 >>>>>>>>>>> because of discussions. The NOTICE-binary file is updated to >>>>> reflect the >>>>>>>>>>> slight change in ordering; shaded-guava now appears at a different >>>>> part in >>>>>>>>>>> the dependency tree. >>>>>>>>> >>>>>>>>> >>>>>> >>>>> >>>>> >>>> >> >
