[RESULT][VOTE] Release 1.6.2, release candidate #1

2018-10-29 Thread Chesnay Schepler
|I'm happy to announce that we have unanimously approved this release. There are 4 approving votes, 3 of which are binding: * Chesnay (binding) * Gordon (binding) * Till (binding) * vino (non-binding) There are no disapproving votes. Thanks everyone!||| || | | On 18.10.2018 13:18, Chesnay Schep

Re: [VOTE] Release 1.6.2, release candidate #1

2018-10-28 Thread vino yang
+1 - checked the PR of the announcement blog post and the version number. - compiled the source code (without test) - ran table/sql test cases - started a standalone flink cluster with a example job Thanks, vino. Till Rohrmann 于2018年10月26日周五 下午11:34写道: > +1 (binding) > > - Built Flink 1.6.2 f

Re: [VOTE] Release 1.6.2, release candidate #1

2018-10-26 Thread Till Rohrmann
+1 (binding) - Built Flink 1.6.2 from sources and ran all tests - Ran all end-to-end tests - Executed the Jepsen test suite with the Hadoop 2.8 binaries Cheers, Till On Fri, Oct 26, 2018 at 8:12 AM Tzu-Li (Gordon) Tai wrote: > +1 > > - Verified signature and hashes > - Built locally, with Scal

Re: [VOTE] Release 1.6.2, release candidate #1

2018-10-25 Thread Tzu-Li (Gordon) Tai
+1 - Verified signature and hashes - Built locally, with Scala 2.11, Hadoop free. Build passes without errors. - Ran e2e tests locally overnight in a loop, no attempts were failing - No missing artifacts in the release staging area. I also agree that the OS-incompatibility in ES shouldn’t be bloc

Re: [VOTE] Release 1.6.2, release candidate #1

2018-10-25 Thread Chesnay Schepler
+1 - ran a local cluster - submitted multiple jobs through WebUI - verified availability of metrics - verified that latency marks are still enabled by default but configurable via configuration On 18.10.2018 13:18, Chesnay Schepler wrote: Hi everyone, Please review and vote on the release can

Re: [VOTE] Release 1.6.2, release candidate #1

2018-10-19 Thread Fabian Hueske
Thanks Chesnay! Withdrawing my -1 for this RC. Cheers, Fabian Am Fr., 19. Okt. 2018 um 15:19 Uhr schrieb Chesnay Schepler < ches...@apache.org>: > To summarize: > > The RAT issue exists since 1.6.0, but it does highlight some issues in > our rat-plugin setup, namely that it is run before any mo

Re: [VOTE] Release 1.6.2, release candidate #1

2018-10-19 Thread Chesnay Schepler
To summarize: The RAT issue exists since 1.6.0, but it does highlight some issues in our rat-plugin setup, namely that it is run before any module is compiled/tested. The first ES5 issue (ClassNotFoundException) is not new nor causes a build failure. The second ES5 issue is an OS-incompati

Re: [VOTE] Release 1.6.2, release candidate #1

2018-10-19 Thread Chesnay Schepler
This appears to be an OS-incompatibility issue in ES. https://github.com/opensensorhub/osh-persistence/issues/2 https://github.com/elastic/elasticsearch/issues/23218 On 19.10.2018 13:33, Fabian Hueske wrote: I've run the build again. You were right Chesnay. The build failed due to an AssertionE

Re: [VOTE] Release 1.6.2, release candidate #1

2018-10-19 Thread Fabian Hueske
I've run the build again. You were right Chesnay. The build failed due to an AssertionError raised by Elasticsearch (see below). Best, Fabian --- Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.824 sec <<< FAILURE! - in org.apache.flink.streaming.connectors.elasticsearch5.Elast

Re: [VOTE] Release 1.6.2, release candidate #1

2018-10-19 Thread Fabian Hueske
Thanks Chesnay, I'll check again on the error that failed the build. Am Fr., 19. Okt. 2018 um 12:13 Uhr schrieb Chesnay Schepler < ches...@apache.org>: > This issue should also be present in 1.6.0 and 1.6.1 (since the avro > test was added in 1.6.0) so I wouldn't block the release on it. > >

Re: [VOTE] Release 1.6.2, release candidate #1

2018-10-19 Thread Chesnay Schepler
This issue should also be present in 1.6.0 and 1.6.1 (since the avro test was added in 1.6.0) so I wouldn't block the release on it. On 19.10.2018 10:44, Chesnay Schepler wrote: I've opened https://issues.apache.org/jira/browse/FLINK-10608 for the RAT issue. On 19.10.2018 10:38, Fabian Hueske

Re: [VOTE] Release 1.6.2, release candidate #1

2018-10-19 Thread Chesnay Schepler
I do get the same ClassNotFoundException locally, but my build is not marked as failed. This exception also occurs on master but doesn't fail the build. Did you get another exception, or could it be that the build only failed due to the RAT issue? On 18.10.2018 23:16, Fabian Hueske wrote: Hi

Re: [VOTE] Release 1.6.2, release candidate #1

2018-10-19 Thread Chesnay Schepler
I've opened https://issues.apache.org/jira/browse/FLINK-10608 for the RAT issue. On 19.10.2018 10:38, Fabian Hueske wrote: It's these two: * Files with unapproved licenses: flink-end-to-end-tests/flink-datastream-allround-test/src/main/java

Re: [VOTE] Release 1.6.2, release candidate #1

2018-10-19 Thread Fabian Hueske
It's these two: * Files with unapproved licenses: flink-end-to-end-tests/flink-datastream-allround-test/src/main/java/org/apache/flink/streaming/tests/avro/ComplexPayloadAvro.java flink-end-to-end-tests/flink-datastream-allround-test/src/main

Re: [VOTE] Release 1.6.2, release candidate #1

2018-10-19 Thread Chesnay Schepler
do you have a list of the generated files that don't have the license header? On 18.10.2018 23:16, Fabian Hueske wrote: Hi, Thanks Chesnay for preparing the RC1 for Flink 1.6.2. I checked a few things, but there seem to be some issues with the release candidate. * no dependencies added or ch

Re: [VOTE] Release 1.6.2, release candidate #1

2018-10-18 Thread Fabian Hueske
Hi, Thanks Chesnay for preparing the RC1 for Flink 1.6.2. I checked a few things, but there seem to be some issues with the release candidate. * no dependencies added or changed since Flink 1.6.1 * building the source distribution without tests succeeds, however, a second build fails due to gene

[VOTE] Release 1.6.2, release candidate #1

2018-10-18 Thread Chesnay Schepler
Hi everyone, Please review and vote on the release candidate #1 for the version 1.6.2, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1],