To summarize:
The RAT issue exists since 1.6.0, but it does highlight some issues in
our rat-plugin setup, namely that it is run before any module is
compiled/tested.
The first ES5 issue (ClassNotFoundException) is not new nor causes a
build failure.
The second ES5 issue is an OS-incompatibility caused by ES. This issue
should not be new since we didn't modify the ES5 version in 2 years.
Given that no listed issue is new in this release I would not cancel the RC.
On 18.10.2018 23:16, Fabian Hueske wrote:
Hi,
Thanks Chesnay for preparing the RC1 for Flink 1.6.2.
I checked a few things, but there seem to be some issues with the release
candidate.
* no dependencies added or changed since Flink 1.6.1
* building the source distribution without tests succeeds, however, a
second build fails due to generated files without approved license header
* building the source distribution with tests failed (see exception below).
Can anybody verify the failure?
-1 for releasing RC1.
We should add the generated files to the rat exclusion list and validate
that Flink can be build with tests from the source distribution.
Best, Fabian
---
ERROR StatusLogger Unable to create class
org.apache.flink.streaming.connectors.elasticsearch5.shaded.org.apache.logging.slf4j.SLF4JLoggerContextFactory
specified in
file:/home/fhueske/Downloads/flink-1.6.2/flink-connectors/flink-connector-elasticsearch5/target/classes/META-INF/log4j-provider.properties
java.lang.ClassNotFoundException:
org.apache.flink.streaming.connectors.elasticsearch5.shaded.org.apache.logging.slf4j.SLF4JLoggerContextFactory
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at
org.apache.logging.log4j.spi.Provider.loadLoggerContextFactory(Provider.java:96)
at org.apache.logging.log4j.LogManager.<clinit>(LogManager.java:91)
at
org.elasticsearch.common.logging.ESLoggerFactory.getLogger(ESLoggerFactory.java:49)
at org.elasticsearch.common.logging.Loggers.getLogger(Loggers.java:105)
at org.elasticsearch.node.Node.<init>(Node.java:237)
at
org.apache.flink.streaming.connectors.elasticsearch.EmbeddedElasticsearchNodeEnvironmentImpl$PluginNode.<init>(EmbeddedElasticsearchNodeEnvironmentImpl.java:78)
at
org.apache.flink.streaming.connectors.elasticsearch.EmbeddedElasticsearchNodeEnvironmentImpl.start(EmbeddedElasticsearchNodeEnvironmentImpl.java:54)
at
org.apache.flink.streaming.connectors.elasticsearch.ElasticsearchSinkTestBase.prepare(ElasticsearchSinkTestBase.java:72)
Am Do., 18. Okt. 2018 um 13:18 Uhr schrieb Chesnay Schepler <
ches...@apache.org>:
Hi everyone,
Please review and vote on the release candidate #1 for the version
1.6.2, as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release and binary convenience releases to
be deployed to dist.apache.org [2], which are signed with the key with
fingerprint 11D464BA [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag "release-1.6.2-rc1" [5],
* website pull request listing the new release and adding announcement
blog post [6].
The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.
Thanks,
Release Manager
[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12344110
[2] https://dist.apache.org/repos/dist/dev/flink/flink-1.6.2/
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1186
[5]
https://gitbox.apache.org/repos/asf?p=flink.git;a=tag;h=refs/tags/release-1.6.2-rc1
[6] https://github.com/apache/flink-web/pull/128
