Re: Kinesis Performance Issue (was [VOTE] Release 1.11.0, release candidate #4)

2020-08-14 Thread Piotr Nowojski
o verify? > >>>>>> > > > > > [1] https://issues.apache.org/jira/browse/FLINK-17496 > >>>>>> > > > > > [2] https://issues.apache.org/jira/browse/FLINK-14881 > >>>>>> > > > > > > >>>&g

Re: Kinesis Performance Issue (was [VOTE] Release 1.11.0, release candidate #4)

2020-08-13 Thread Thomas Weise
--- >>>>>> > > > > > From:Thomas Weise >>>>>> > > > > > Send Time:2020年7月17日(星期五) 05:29 >>>>>> > > > > > To:dev >>>>>> > > > >

Re: Kinesis Performance Issue (was [VOTE] Release 1.11.0, release candidate #4)

2020-08-13 Thread Roman Khachatryan
;> > > > > > > I will investigate further today. >>>>> > > > > > > >>>>> > > > > > > >>>>> > > > > > > On Wed, Jul 8, 2020 at 4:42 AM Aljoscha Krettek < >>>>> >

Re: Kinesis Performance Issue (was [VOTE] Release 1.11.0, release candidate #4)

2020-08-08 Thread Roman Khachatryan
;>> wangzhijiang...@aliyun.com >>>> > > > > .invalid> >>>> > > > > wrote: >>>> > > > > >>>> > > > > > Hi Thomas, >>>> > > > > > >>>> > > > > &g

Re: Kinesis Performance Issue (was [VOTE] Release 1.11.0, release candidate #4)

2020-08-07 Thread Thomas Weise
ctually I was also suspicious of the point of #snapshotState >>> in >>> > > > previous >>> > > > > > discussions since it indeed cost much time to block normal >>> operator >>> > > > > > processing. >>> >

Re: Kinesis Performance Issue (was [VOTE] Release 1.11.0, release candidate #4)

2020-08-07 Thread Thomas Weise
fect. >> > > > > > >> > >> > > > > > >> > I think we need to find out whether it has other symptoms >> > > changed >> > > > > > >> besides the performance regression to further fig

Re: Kinesis Performance Issue (was [VOTE] Release 1.11.0, release candidate #4)

2020-08-07 Thread Roman Khachatryan
> > > > > > > > > > > + dev@ for visibility > > > > > > > > > > > > > > I will investigate further today. > > > > > > > > > > > > > > > > > > > > > On Wed, Jul

Re: Kinesis Performance Issue (was [VOTE] Release 1.11.0, release candidate #4)

2020-08-06 Thread Thomas Weise
t; > > operations > > > > > inside KinesisProducer implementation provided by amazonaws, which > I > > am > > > > not > > > > > quite familiar with. > > > > > But I noticed there were two upgrades related to it in >

Re: Kinesis Performance Issue (was [VOTE] Release 1.11.0, release candidate #4)

2020-08-01 Thread Roman Khachatryan
upgrading amazon-kinesis-producer to 0.14.0 [1] and another is > > for > > > > upgrading aws-sdk-version to 1.11.754 [2]. > > > > You mentioned that you already reverted the SDK upgrade to verify no > > > > changes. Did you also revert the [1] to verify? &

Re: Kinesis Performance Issue (was [VOTE] Release 1.11.0, release candidate #4)

2020-07-30 Thread Thomas Weise
the [1] to verify? > > > [1] https://issues.apache.org/jira/browse/FLINK-17496 > > > [2] https://issues.apache.org/jira/browse/FLINK-14881 > > > > > > Best, > > > Zhijiang > > > --

Re: Kinesis Performance Issue (was [VOTE] Release 1.11.0, release candidate #4)

2020-07-23 Thread Kurt Young
; You mentioned that you already reverted the SDK upgrade to verify no > > changes. Did you also revert the [1] to verify? > > [1] https://issues.apache.org/jira/browse/FLINK-17496 > > [2] https://issues.apache.org/jira/browse/FLINK-14881 > > > > Best, > > Zhijiang > > -- >

Re: Kinesis Performance Issue (was [VOTE] Release 1.11.0, release candidate #4)

2020-07-23 Thread Thomas Weise
From:Thomas Weise > Send Time:2020年7月17日(星期五) 05:29 > To:dev > Cc:Zhijiang ; Stephan Ewen ; > Arvid Heise ; Aljoscha Krettek > Subject:Re: Kinesis Performance Issue (was [VOTE] Release 1.11.0, release > candidate #4) > > Sorry for the delay. > > I confirmed that the r

Re: Kinesis Performance Issue (was [VOTE] Release 1.11.0, release candidate #4)

2020-07-16 Thread Zhijiang
t:Re: Kinesis Performance Issue (was [VOTE] Release 1.11.0, release candidate #4) Sorry for the delay. I confirmed that the regression is due to the sink (unsurprising, since another job with the same consumer, but not the producer, runs as expected). As promised I did CPU profiling on th

Re: Kinesis Performance Issue (was [VOTE] Release 1.11.0, release candidate #4)

2020-07-16 Thread Thomas Weise
> Zhijiang >> > >> > >> > -- >> > From:Thomas Weise >> > Send Time:2020年7月7日(星期二) 23:01 >> > To:Stephan Ewen >> > Cc:Aljoscha Krettek ; Arvid Heise < >> ar...@v

Re: Kinesis Performance Issue (was [VOTE] Release 1.11.0, release candidate #4)

2020-07-13 Thread Thomas Weise
Best, > > Zhijiang > > > > > > -- > > From:Thomas Weise > > Send Time:2020年7月7日(星期二) 23:01 > > To:Stephan Ewen > > Cc:Aljoscha Krettek ; Arvid Heise < > ar...@ververica.com>; Zhijiang &

[RESULT] [VOTE] Release 1.11.0, release candidate #4

2020-07-06 Thread Zhijiang
I'm happy to announce that we have unanimously approved the 1.11.0 release. There are 17 approving votes, 8 of which are binding: - Stephan (binding) - Till (binding) - Aljoscha (binding) - Robert (binding) - Chesnay (binding) - Dawid (binding) - Jark (binding) - Jincheng (binding) - Leonard Xu (

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-05 Thread Yang Wang
result soon in a separate email. > > Best, > Zhijiang > > > -- > From:Jingsong Li > Send Time:2020年7月6日(星期一) 12:11 > To:dev > Subject:Re: [VOTE] Release 1.11.0, release candidate #4 > > +1

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-05 Thread Zhijiang
期一) 12:11 To:dev Subject:Re: [VOTE] Release 1.11.0, release candidate #4 +1 (non-binding) - verified signature and checksum - build from source - checked webui and log sanity - played with filesystem and new connectors - played with Hive connector Best, Jingsonga On Mon, Jul 6, 2020 at 9:50 AM

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-05 Thread Jingsong Li
; the > > > changes above, and it is only indicating the duration for calling > > > `Operation.snapshotState`. > > > If this duration is beyond your expectation, you can check or debug > > > whether the source/sink operations might take more time to finish > > > `snapshotState` in practice. E.g. you can > > >

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-05 Thread Xintong Song
the implementation of this method as empty to further verify the > > effect. > > > > Best, > > Zhijiang > > > > > > -- > > From:Thomas Weise > > Send Time:2020年7月5日(星期日) 12:22

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-05 Thread Benchao Li
might take more time to finish > `snapshotState` in practice. E.g. you can > make the implementation of this method as empty to further verify the > effect. > > Best, > Zhijiang > > > ---------- > From:Thomas Wei

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-04 Thread Zhijiang
ntation of this method as empty to further verify the effect. Best, Zhijiang -- From:Thomas Weise Send Time:2020年7月5日(星期日) 12:22 To:dev ; Zhijiang Cc:Yingjie Cao Subject:Re: [VOTE] Release 1.11.0, release candidate #4 Hi Zhijia

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-04 Thread Jark Wu
r case based on the current > analysis. > > If we really conclude anything need to be resolved after the final > > release, then we can also make the next minor release-1.11.1 come soon. > > > > [1] https://issues.apache.org/jira/browse/FLINK-18433 > > > > Bes

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-04 Thread Thomas Weise
Best, > Zhijiang > > > ------ > From:Thomas Weise > Send Time:2020年7月4日(星期六) 12:26 > To:dev ; Zhijiang > Cc:Yingjie Cao > Subject:Re: [VOTE] Release 1.11.0, release candidate #4 > > Hi Zhijiang, > &g

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-04 Thread Congxian Qiu
elease-1.11.1 come soon. > > > > [1] https://issues.apache.org/jira/browse/FLINK-18433 > > > > Best, > > Zhijiang > > > > > > -- > > From:Thomas Weise > > Send Time:2020年7月4日(星期

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-04 Thread Steven Wu
e the next minor release-1.11.1 come soon. > > [1] https://issues.apache.org/jira/browse/FLINK-18433 > > Best, > Zhijiang > > > ------ > From:Thomas Weise > Send Time:2020年7月4日(星期六) 12:26 > To:dev ; Zhiji

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-04 Thread Zhijiang
iang -- From:Thomas Weise Send Time:2020年7月4日(星期六) 12:26 To:dev ; Zhijiang Cc:Yingjie Cao Subject:Re: [VOTE] Release 1.11.0, release candidate #4 Hi Zhijiang, It will probably be best if we connect next week and discuss the issue directly since this could be quite difficult to reproduce. Before

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-03 Thread Thomas Weise
sharing, I guess these three vertex parallelism task would > probably be deployed into the same slot, then the data shuffle is by memory > queue, not network stack. If so, the above [2] should no effect. > - I also saw some Jira changes for kinesis in this release, could you > confi

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-03 Thread Yingjie Cao
; > other? > > The checkpoint mode is exactly-once with rocksDB state backend? > > The backpressure happened in this case? > > How much percentage regression in this case? > > > > Best, > > Zhijiang > > > > > > > > ---

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-03 Thread Xingbo Huang
+1 (non-binding) - check wheel package consistency with the built from the source code - test the built from the wheel package in mac os with python 3.6 - verify the performance for PyFlink UDFs including Python General UDF and Pandas UDF - test Python UDTF Best, Xingbo Dian Fu 于2020年7月3日周五 下午8

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-03 Thread Dian Fu
+1 (non-binding) - built from source with scala 2.11 successfully - checked the signature and checksum of the binary packages - installed PyFlink on MacOS, Windows and Linux successfully - tested the functionality of Pandas UDF and the conversion between PyFlink Table and Pandas DataFrame - verif

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-03 Thread jincheng sun
+1(binding) Checks: - check wheel package consistency - test the built from the wheel package - checked the signature and checksum - pip installed the Python package `apache_flink-1.11.0-cp37-cp37m-macosx_10_9_x86_64.whl` successfully and run a simple word count example successfully

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-03 Thread Leonard Xu
+1 (non-binding) - checked/verified signatures and hashes - built from source sing scala 2.11 succeeded - go through all issues which "fixVersion" property is 1.11.0, there is no blocker. - checked that there are no missing artifacts - test SQL connector Elasticsearch7/JDBC/HBase/Kafka (new conne

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-03 Thread Yingjie Cao
; > other? > > The checkpoint mode is exactly-once with rocksDB state backend? > > The backpressure happened in this case? > > How much percentage regression in this case? > > > > Best, > > Zhijiang > > > > > > > > ---

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-03 Thread Dawid Wysakowicz
By slot sharing, I guess these three vertex parallelism task would >> probably be deployed into the same slot, then the data shuffle is by memory >> queue, not network stack. If so, the above [2] should no effect. >> - I also saw some Jira changes for kinesis in this release, could y

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-03 Thread Till Rohrmann
y be deployed into the same slot, then the data shuffle is by memory > queue, not network stack. If so, the above [2] should no effect. > - I also saw some Jira changes for kinesis in this release, could you > confirm that these changes would not effect the performance? > > Bes

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-02 Thread Zhijiang
ack. If so, the above [2] should no effect. - I also saw some Jira changes for kinesis in this release, could you confirm that these changes would not effect the performance? Best, Zhijiang -- From:Thomas Weise Send Time:2020年7月3日(

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-02 Thread Dawid Wysakowicz
oint. Maybe we should adjust the vote template accordingly in >>>> the respective wiki to guide the following release processes. >>>> >>>> Regarding the performance regression, could you provide some more details >>>> for our better measurement

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-02 Thread Aljoscha Krettek
n in this case? Best, Zhijiang -- From:Thomas Weise Send Time:2020年7月2日(星期四) 09:54 To:dev Subject:Re: [VOTE] Release 1.11.0, release candidate #4 Hi Till, Yes, we don't have the setting in flink-conf.yaml. Generally, we carry forward the existing configuration and any change to default configura

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-02 Thread Kostas Kloudas
gt; E.g. I guess the topology only includes two vertexes source and sink? > > > What is the parallelism for every vertex? > > > The upstream shuffles data to the downstream via rebalance partitioner or > > > other? > > > The checkpoint mode is exactly-once with rocksDB state

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-02 Thread Robert Metzger
> > The upstream shuffles data to the downstream via rebalance partitioner or > > other? > > The checkpoint mode is exactly-once with rocksDB state backend? > > The backpressure happened in this case? > > How much percentage regression in this case? > > > >

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-02 Thread Thomas Weise
int mode is exactly-once with rocksDB state backend? > The backpressure happened in this case? > How much percentage regression in this case? > > Best, > Zhijiang > > > > -- > From:Thomas Weise > S

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-02 Thread Till Rohrmann
egarding the performance regression, if possible we can reproduce to >> >>> analysis the reason based on Thomas's feedback, then we can evaluate >> its >> >>> effect. >> >>> >> >>> Regarding the FLINK-18461, after syncing with Jark offline, the bug >> would >> >>> effect one o

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-02 Thread Till Rohrmann
rio is actually the most commonly used way by users. > >>> My suggestion is to merge it into release-1.11 ATM since the PR already > >>> open for review, then let's further finalize the conclusion later. If > >> this > >>> issue is the only one after RC4 goi

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-02 Thread Chesnay Schepler
necessary to be resolved soon, then it is no doubt to cover all of them in next RC5. Best, Zhijiang -- From:Till Rohrmann Send Time:2020年7月2日(星期四) 16:46 To:dev Cc:Zhijiang Subject:Re: [VOTE] Release 1.11.0, release candidate #4

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-02 Thread Robert Metzger
ver it in next release-1.11.1 as Robert suggested, as we can prepare > for > > the next minor release soon. If there are other blockers issues during > > voting and necessary to be resolved soon, then it is no doubt to cover > all > > of them in next RC5. > > > > Best, > > Zh

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-02 Thread Chesnay Schepler
other blockers issues during voting and necessary to be resolved soon, then it is no doubt to cover all of them in next RC5. Best, Zhijiang -- From:Till Rohrmann Send Time:2020年7月2日(星期四) 16:46 To:dev Cc:Zhijiang Subject:Re: [VOTE]

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-02 Thread Stephan Ewen
g and necessary to be resolved soon, then it is no doubt to cover all > of them in next RC5. > > Best, > Zhijiang > > > ---------- > From:Till Rohrmann > Send Time:2020年7月2日(星期四) 16:46 > To:dev > Cc:Zhijiang >

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-02 Thread Zhijiang
g and necessary to be resolved soon, then it is no doubt to cover all of them in next RC5. Best, Zhijiang -- From:Till Rohrmann Send Time:2020年7月2日(星期四) 16:46 To:dev Cc:Zhijiang Subject:Re: [VOTE] Release 1.11.0, release candid

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-02 Thread Till Rohrmann
vertexes source and sink? > > > What is the parallelism for every vertex? > > > The upstream shuffles data to the downstream via rebalance partitioner > or > > > other? > > > The checkpoint mode is exactly-once with rocksDB state backend? > >

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-02 Thread Robert Metzger
rebalance partitioner or > > other? > > The checkpoint mode is exactly-once with rocksDB state backend? > > The backpressure happened in this case? > > How much percentage regression in this case? > > > > Best, > > Zhijiang > > > > >

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-01 Thread Jark Wu
--- > From:Thomas Weise > Send Time:2020年7月2日(星期四) 09:54 > To:dev > Subject:Re: [VOTE] Release 1.11.0, release candidate #4 > > Hi Till, > > Yes, we don't have the setting in flink-conf.yaml. > > Generally, we carry forward the existi

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-01 Thread Zhijiang
] Release 1.11.0, release candidate #4 Hi Till, Yes, we don't have the setting in flink-conf.yaml. Generally, we carry forward the existing configuration and any change to default configuration values would impact the upgrade. Yes, since it is an incompatible change I would state it in the re

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-01 Thread Thomas Weise
Hi Till, Yes, we don't have the setting in flink-conf.yaml. Generally, we carry forward the existing configuration and any change to default configuration values would impact the upgrade. Yes, since it is an incompatible change I would state it in the release notes. Thanks, Thomas BTW I found

Re: [VOTE] Release 1.11.0, release candidate #4

2020-07-01 Thread Till Rohrmann
Hi Thomas, just to confirm: When starting the image in local mode, then you don't have any of the JobManager memory configuration settings configured in the effective flink-conf.yaml, right? Does this mean that you have explicitly removed `jobmanager.heap.size: 1024m` from the default configuratio

Re: [VOTE] Release 1.11.0, release candidate #4

2020-06-30 Thread Thomas Weise
Thanks for preparing another RC! As mentioned in the previous RC thread, it would be super helpful if the release notes that are part of the documentation can be included [1]. It's a significant time-saver to have read those first. I found one more non-backward compatible change that would be wor

Re: [VOTE] Release 1.11.0, release candidate #4

2020-06-30 Thread Chesnay Schepler
- source does not contain binaries - started a local cluster, logs are fine, examples run - web submission works _in general_ However, a number of batch examples fail when submitted through the WebUI with the following error: Caused by: org.apache.flink.api.common.InvalidProgramException: Job

[VOTE] Release 1.11.0, release candidate #4

2020-06-30 Thread Zhijiang
Hi everyone, Please review and vote on the release candidate #4 for the version 1.11.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1],