Re: [VOTE] Release 1.10.0, release candidate #2

2020-02-07 Thread Gary Yao
Hi everyone, I am hereby canceling the vote due to: FLINK-15917 FLINK-15918 FLINK-15935 FLINK-15937 RC3 will be created later today. Best, Gary On Thu, Feb 6, 2020 at 4:39 PM Andrey Zagrebin wrote: > alright, thanks for confirming this Benchao! > > On Thu, Feb 6, 2020 at 6:36

Re: [VOTE] Release 1.10.0, release candidate #2

2020-02-06 Thread Andrey Zagrebin
alright, thanks for confirming this Benchao! On Thu, Feb 6, 2020 at 6:36 PM Benchao Li wrote: > Hi Andrey, > > I noticed that 1.10 has changed to enabling background cleanup by default > just after I posted to this email. > So it won't affect 1.10 any more, just affect 1.9.x. We can move to the

Re: [VOTE] Release 1.10.0, release candidate #2

2020-02-06 Thread Benchao Li
Hi Andrey, I noticed that 1.10 has changed to enabling background cleanup by default just after I posted to this email. So it won't affect 1.10 any more, just affect 1.9.x. We can move to the Jira ticket to discuss further more. Andrey Zagrebin 于2020年2月6日周四 下午11:30写道: > Hi Benchao, > > Do you o

Re: [VOTE] Release 1.10.0, release candidate #2

2020-02-06 Thread Andrey Zagrebin
Hi Benchao, Do you observe this issue FLINK-15938 with 1.9 or 1.10? If with 1.9, I suggest to check with 1.10. Thanks, Andrey On Thu, Feb 6, 2020 at 4:07 PM Benchao Li wrote: > Hi all, > > I found another issue[1], I don't know if it should be a blocker. But it > does affects joins without win

Re: [VOTE] Release 1.10.0, release candidate #2

2020-02-06 Thread Benchao Li
Hi all, I found another issue[1], I don't know if it should be a blocker. But it does affects joins without window in blink planner. [1] https://issues.apache.org/jira/browse/FLINK-15938 Jeff Zhang 于2020年2月6日周四 下午5:05写道: > Hi Jingsong, > > Thanks for the suggestion. It works for running it in

Re: [VOTE] Release 1.10.0, release candidate #2

2020-02-06 Thread Jeff Zhang
Hi Jingsong, Thanks for the suggestion. It works for running it in IDE, but for downstream project like Zeppelin where I will include flink jars in classpath. it only works when I specify the jars one by one explicitly in classpath, using * doesn't work. e.g. The following command where I use *

Re: [VOTE] Release 1.10.0, release candidate #2

2020-02-06 Thread Jingsong Li
Hi Jeff, For FLINK-15935 [1], I try to think of it as a non blocker. But it's really an important issue. The problem is the class loading order. We want to load the class in the blink-planner.jar, but actually load the class in the flink-planner.jar. First of all, the order of class loading

Re: [VOTE] Release 1.10.0, release candidate #2

2020-02-06 Thread jincheng sun
There is a blocker issue: https://issues.apache.org/jira/browse/FLINK-15937 Best, Jincheng Jeff Zhang 于2020年2月6日周四 下午3:09写道: > -1, I just found one critical issue > https://issues.apache.org/jira/browse/FLINK-15935 > This ticket means user unable to use watermark in sql if he specify both > f

Re: [VOTE] Release 1.10.0, release candidate #2

2020-02-05 Thread Jeff Zhang
-1, I just found one critical issue https://issues.apache.org/jira/browse/FLINK-15935 This ticket means user unable to use watermark in sql if he specify both flink planner and blink planner in pom.xml org.apache.flink flink-table-planner_${scala.binary.version} ${project.version} o

Re: [VOTE] Release 1.10.0, release candidate #2

2020-02-05 Thread Thomas Weise
I deployed commit 81cf2f9e59259389a6549b07dcf822ec63c899a4 and can confirm that the dataformat-cbor and checkpoint alignment metric issues are resolved. On Wed, Feb 5, 2020 at 11:26 AM Gary Yao wrote: > Note that there is currently an ongoing discussion about whether > FLINK-15917 > and FLINK-1

Re: [VOTE] Release 1.10.0, release candidate #2

2020-02-05 Thread Gary Yao
Note that there is currently an ongoing discussion about whether FLINK-15917 and FLINK-15918 should be fixed in 1.10.0 [1]. [1] http://mail-archives.apache.org/mod_mbox/flink-dev/202002.mbox/%3CCA%2B5xAo3D21-T5QysQg3XOdm%3DL9ipz3rMkA%3DqMzxraJRgfuyg2A%40mail.gmail.com%3E On Wed, Feb 5, 2020 at 8:

[VOTE] Release 1.10.0, release candidate #2

2020-02-05 Thread Gary Yao
Hi everyone, Please review and vote on the release candidate #2 for the version 1.10.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], *