Re: [VOTE] NEW FLIP-102: Add More Metrics to TaskManager

2020-10-25 Thread Yadong Xie
Hi all, The voting time has past and there are enough +1 votes to consider the FLIP-102 approved. Thanks to everyone for giving great feedback! Best, Yadong Xintong Song 于2020年10月23日周五 下午7:41写道: > I'm aware that many steps are already done. But I believe not all of them > are done, as the FLI

Re: [VOTE] NEW FLIP-102: Add More Metrics to TaskManager

2020-10-23 Thread Xintong Song
I'm aware that many steps are already done. But I believe not all of them are done, as the FLIP doc currently shows, unless the FLIP is already completed. Taking a closer look at the issues, I believe step 5 should point to FLINK-19764, rather than FLINK-15328 which is closed for duplication. Any

Re: [VOTE] NEW FLIP-102: Add More Metrics to TaskManager

2020-10-23 Thread Andrey Zagrebin
Thanks a lot for this nice UI guys! +1 and for closed issues that is just because many steps have been already done. Best, Andrey On Fri, Oct 23, 2020 at 11:12 AM Till Rohrmann wrote: > Thanks for reviving this Flip Yadong! The changes look good to me and the > new memory UI looks awesome :-)

Re: [VOTE] NEW FLIP-102: Add More Metrics to TaskManager

2020-10-23 Thread Till Rohrmann
Thanks for reviving this Flip Yadong! The changes look good to me and the new memory UI looks awesome :-) I think the reason why the REST issues are closed is because they are already done. In that sense some of the work already finished. +1 for adopting this FLIP and moving forward with updating

Re: [VOTE] NEW FLIP-102: Add More Metrics to TaskManager

2020-10-22 Thread Jark Wu
+1 Thanks for the work. Best, Jark On Fri, 23 Oct 2020 at 10:13, Xintong Song wrote: > Thanks Yadong, Mattias and Lining for reviving this FLIP. > > I've seen so many users confused by the current webui page of task manager > metrics. This FLIP should definitely help them understand the memory

Re: [VOTE] NEW FLIP-102: Add More Metrics to TaskManager

2020-10-22 Thread Xintong Song
Thanks Yadong, Mattias and Lining for reviving this FLIP. I've seen so many users confused by the current webui page of task manager metrics. This FLIP should definitely help them understand the memory footprints and tune the configurations for task managers. The design part of this proposal look

[VOTE] NEW FLIP-102: Add More Metrics to TaskManager

2020-10-22 Thread Yadong Xie
Hi all I want to start a new vote for FLIP-102, which proposes to add more metrics to the task manager in web UI. The new FLIP-102 was revisited and adapted following the old ML discussion