I'm aware that many steps are already done. But I believe not all of them are done, as the FLIP doc currently shows, unless the FLIP is already completed.
Taking a closer look at the issues, I believe step 5 should point to FLINK-19764, rather than FLINK-15328 which is closed for duplication. Anyway, +1 on the proposed changes. Thank you~ Xintong Song On Fri, Oct 23, 2020 at 6:59 PM Andrey Zagrebin <azagre...@apache.org> wrote: > Thanks a lot for this nice UI guys! > > +1 and for closed issues that is just because many steps have been > already done. > > Best, > Andrey > > On Fri, Oct 23, 2020 at 11:12 AM Till Rohrmann <trohrm...@apache.org> > wrote: > > > Thanks for reviving this Flip Yadong! The changes look good to me and the > > new memory UI looks awesome :-) > > > > I think the reason why the REST issues are closed is because they are > > already done. In that sense some of the work already finished. > > > > +1 for adopting this FLIP and moving forward with updating the web UI > > accordingly. > > > > Cheers, > > Till > > > > On Fri, Oct 23, 2020 at 8:58 AM Jark Wu <imj...@gmail.com> wrote: > > > > > +1 > > > > > > Thanks for the work. > > > > > > Best, > > > Jark > > > > > > On Fri, 23 Oct 2020 at 10:13, Xintong Song <tonysong...@gmail.com> > > wrote: > > > > > > > Thanks Yadong, Mattias and Lining for reviving this FLIP. > > > > > > > > I've seen so many users confused by the current webui page of task > > > manager > > > > metrics. This FLIP should definitely help them understand the memory > > > > footprints and tune the configurations for task managers. > > > > > > > > The design part of this proposal looks really good to me. The UI is > > clear > > > > and easy to understand. The metrics look correct to me. > > > > > > > > KIND REMINDER: I think the section `Implementation Proposal` in the > > FLIP > > > > doc needs to be updated, so that we can vote on this FLIP. Currently, > > all > > > > the tickets listed are closed. > > > > > > > > Thank you~ > > > > > > > > Xintong Song > > > > > > > > > > > > > > > > On Thu, Oct 22, 2020 at 5:53 PM Yadong Xie <vthink...@gmail.com> > > wrote: > > > > > > > > > Hi all > > > > > > > > > > I want to start a new vote for FLIP-102, which proposes to add more > > > > metrics > > > > > to the task manager in web UI. > > > > > > > > > > The new FLIP-102 was revisited and adapted following the old ML > > > > discussion > > > > > < > > > > > > > > > > > > > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/VOTE-FLIP-102-Add-More-Metrics-to-TaskManager-td37898.html > > > > > > > > > > > . > > > > > > > > > > Thanks to Matthias and Lining's effort, more metrics are available. > > We > > > > can > > > > > match most of the effective configuration to the metrics just as > > Flink > > > > Doc > > > > > < > > > > > > > > > > > > > > > https://ci.apache.org/projects/flink/flink-docs-release-1.11/ops/memory/mem_setup_tm.html#detailed-memory-model > > > > > > > > > > > describes now. > > > > > > > > > > The vote will last for at least 72 hours, following the consensus > > > voting. > > > > > > > > > > > > > > > FLIP-102 wiki: > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-102%3A+Add+More+Metrics+to+TaskManager > > > > > > > > > > > > > > > Discussion thread: > > > > > > > > > > > > > > > > > > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/VOTE-FLIP-102-Add-More-Metrics-to-TaskManager-td37898.html > > > > > > > > > > > > > > > > > > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-75-Flink-Web-UI-Improvement-Proposal-td33540.html > > > > > > > > > > Thanks, > > > > > > > > > > Yadong > > > > > > > > > > > > > > >
