Re: [VOTE] FLIP-103: Better TM/JM Log Display

2020-04-28 Thread Till Rohrmann
Hi Yadong, this sounds like a good solution to me. Cheers, Till On Tue, Apr 28, 2020 at 4:18 AM Forward Xu wrote: > +1 > > best, > Forward > > Yadong Xie 于2020年4月28日周二 上午10:03写道: > > > Hi all > > > > sorry for we have an issue that was not discovered in advance > > > > When users run multiple

Re: [VOTE] FLIP-103: Better TM/JM Log Display

2020-04-27 Thread Forward Xu
+1 best, Forward Yadong Xie 于2020年4月28日周二 上午10:03写道: > Hi all > > sorry for we have an issue that was not discovered in advance > > When users run multiple standalone TMs on the same host, the JM log list > may confuse the users since all JM and TM logs are stored in the same > folder, and they

Re: [VOTE] FLIP-103: Better TM/JM Log Display

2020-04-27 Thread Yadong Xie
Hi all sorry for we have an issue that was not discovered in advance When users run multiple standalone TMs on the same host, the JM log list may confuse the users since all JM and TM logs are stored in the same folder, and they will appear on the same list. I have a discussion with Gary and Lin

Re: [VOTE] FLIP-103: Better TM/JM Log Display

2020-02-28 Thread Till Rohrmann
Hi Yadong, Gary might be able to help with this effort. Cheers, Till On Fri, Feb 28, 2020 at 11:08 AM Yadong Xie wrote: > Hi Till > > In addition to the front end, the FLIP-103 would also include some rest API > changes. > Could you assign one PMC or committer to help us review the pull reques

Re: [VOTE] FLIP-103: Better TM/JM Log Display

2020-02-28 Thread Yadong Xie
Hi Till In addition to the front end, the FLIP-103 would also include some rest API changes. Could you assign one PMC or committer to help us review the pull request and drive this FLIP forward? We will start to create PR as soon as possible, thanks! Till Rohrmann 于2020年2月25日周二 下午6:03写道: > late

Re: [VOTE] FLIP-103: Better TM/JM Log Display

2020-02-25 Thread Till Rohrmann
late +1 (binding) Cheers, Till On Tue, Feb 25, 2020 at 4:46 AM Yadong Xie wrote: > Thanks all for the votes. > > So far, we have > > - 4 binding +1 votes (Kurt, Jark, jincheng, Zhu Zhu) > - 5 non-binding +1 votes (Yang Wang, Xintong Song, lining, Yangze, zhenya) > - No -1 votes > > The voting t

Re: [VOTE] FLIP-103: Better TM/JM Log Display

2020-02-24 Thread Yadong Xie
Thanks all for the votes. So far, we have - 4 binding +1 votes (Kurt, Jark, jincheng, Zhu Zhu) - 5 non-binding +1 votes (Yang Wang, Xintong Song, lining, Yangze, zhenya) - No -1 votes The voting time has past and there are enough +1 votes to consider the FLIP-103 approved. Thank you all. Zhu Zh

Re: [VOTE] FLIP-103: Better TM/JM Log Display

2020-02-23 Thread Zhu Zhu
+1 (binding) It can be very helpful to check GC state when GC logging is enabled. Thanks, Zhu Zhu zhenya Sun 于2020年2月24日周一 下午3:51写道: > 1 > > > able-sun > > > On 02/24/2020 15:45,jincheng sun wrote: > +1(binding) Thank you for driving this Yadong! > > Best, > Jincheng > > Yangze Guo 于2020年2月21

Re: [VOTE] FLIP-103: Better TM/JM Log Display

2020-02-23 Thread zhenya Sun
1 able-sun On 02/24/2020 15:45,jincheng sun wrote: +1(binding) Thank you for driving this Yadong! Best, Jincheng Yangze Guo 于2020年2月21日周五 下午3:08写道: +1 (non-binding) It will make debugging more convenient and hence improve usability. Best, Yangze Guo On Fri, Feb 21, 2020 at 2:50 PM Yang W

Re: [VOTE] FLIP-103: Better TM/JM Log Display

2020-02-23 Thread jincheng sun
+1(binding) Thank you for driving this Yadong! Best, Jincheng Yangze Guo 于2020年2月21日周五 下午3:08写道: > +1 (non-binding) > > It will make debugging more convenient and hence improve usability. > > Best, > Yangze Guo > > On Fri, Feb 21, 2020 at 2:50 PM Yang Wang wrote: > > > > Hi Jark, > > > > The G

Re: [VOTE] FLIP-103: Better TM/JM Log Display

2020-02-20 Thread Yangze Guo
+1 (non-binding) It will make debugging more convenient and hence improve usability. Best, Yangze Guo On Fri, Feb 21, 2020 at 2:50 PM Yang Wang wrote: > > Hi Jark, > > The GC log is not enabled by default. If the users want, he/she should > configure it by the following config option. > env.jav

Re: [VOTE] FLIP-103: Better TM/JM Log Display

2020-02-20 Thread Yang Wang
Hi Jark, The GC log is not enabled by default. If the users want, he/she should configure it by the following config option. env.java.opts.jobmanager: -XX:+PrintGCDetails -XX:+PrintGCDateStamps -Xloggc:/opt/flink/log/jobmanager-gc.log -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=2 -XX:GCLogFil

Re: [VOTE] FLIP-103: Better TM/JM Log Display

2020-02-20 Thread Jark Wu
+1 (binding) A minor question: I didn't find the GC log in the POC web. Is it only generated when some configuration is enabled? Best, Jark On Fri, 21 Feb 2020 at 11:40, Kurt Young wrote: > +1 (binding) > > > On Fri, Feb 21, 2020 at 11:25 AM lining jing > wrote: > > > +1 (non-binding) > > It

Re: [VOTE] FLIP-103: Better TM/JM Log Display

2020-02-20 Thread Kurt Young
+1 (binding) On Fri, Feb 21, 2020 at 11:25 AM lining jing wrote: > +1 (non-binding) > It lists all log files, the user could see the GC log. > > Xintong Song 于2020年2月21日周五 上午10:44写道: > > > +1 (non-binding) > > > > I like the ideas of having a list of all log files, and make them > > downloadab

Re: [VOTE] FLIP-103: Better TM/JM Log Display

2020-02-20 Thread lining jing
+1 (non-binding) It lists all log files, the user could see the GC log. Xintong Song 于2020年2月21日周五 上午10:44写道: > +1 (non-binding) > > I like the ideas of having a list of all log files, and make them > downloadable. > > Thank you~ > > Xintong Song > > > > On Fri, Feb 21, 2020 at 10:24 AM Yang Wan

Re: [VOTE] FLIP-103: Better TM/JM Log Display

2020-02-20 Thread Xintong Song
+1 (non-binding) I like the ideas of having a list of all log files, and make them downloadable. Thank you~ Xintong Song On Fri, Feb 21, 2020 at 10:24 AM Yang Wang wrote: > +1 non-binding > > The log files list are shown in the new design. I like the idea. Since the > user defined logs(e.g.

Re: [VOTE] FLIP-103: Better TM/JM Log Display

2020-02-20 Thread Yang Wang
+1 non-binding The log files list are shown in the new design. I like the idea. Since the user defined logs(e.g. my-log.file) could be found here now. Best, Yang Yadong Xie 于2020年2月20日周四 下午5:56写道: > Hi all > > I want to start the vote for FLIP-103, which proposes to provide better > user log

[VOTE] FLIP-103: Better TM/JM Log Display

2020-02-20 Thread Yadong Xie
Hi all I want to start the vote for FLIP-103, which proposes to provide better user log display UI in task manager and job manager. To help everyone better understand the proposal, we spent some efforts on making an online POC Task manager: previous web: http://101.132.122.69:8081/#/task-manage