late +1 (binding) Cheers, Till
On Tue, Feb 25, 2020 at 4:46 AM Yadong Xie <vthink...@gmail.com> wrote: > Thanks all for the votes. > > So far, we have > > - 4 binding +1 votes (Kurt, Jark, jincheng, Zhu Zhu) > - 5 non-binding +1 votes (Yang Wang, Xintong Song, lining, Yangze, zhenya) > - No -1 votes > > The voting time has past and there are enough +1 votes to consider the > FLIP-103 approved. > Thank you all. > > Zhu Zhu <reed...@gmail.com> 于2020年2月24日周一 下午3:56写道: > > > +1 (binding) > > > > It can be very helpful to check GC state when GC logging is enabled. > > > > Thanks, > > Zhu Zhu > > > > zhenya Sun <toke...@126.com> 于2020年2月24日周一 下午3:51写道: > > > > > 1 > > > > > > > > > able-sun > > > > > > > > > On 02/24/2020 15:45,jincheng sun<sunjincheng...@gmail.com> wrote: > > > +1(binding) Thank you for driving this Yadong! > > > > > > Best, > > > Jincheng > > > > > > Yangze Guo <karma...@gmail.com> 于2020年2月21日周五 下午3:08写道: > > > > > > +1 (non-binding) > > > > > > It will make debugging more convenient and hence improve usability. > > > > > > Best, > > > Yangze Guo > > > > > > On Fri, Feb 21, 2020 at 2:50 PM Yang Wang <danrtsey...@gmail.com> > wrote: > > > > > > Hi Jark, > > > > > > The GC log is not enabled by default. If the users want, he/she should > > > configure it by the following config option. > > > env.java.opts.jobmanager: -XX:+PrintGCDetails -XX:+PrintGCDateStamps > > > -Xloggc:/opt/flink/log/jobmanager-gc.log -XX:+UseGCLogFileRotation > > > -XX:NumberOfGCLogFiles=2 -XX:GCLogFileSize=512M > > > > > > Best, > > > Yang > > > > > > Jark Wu <imj...@gmail.com> 于2020年2月21日周五 下午2:19写道: > > > > > > +1 (binding) > > > > > > A minor question: I didn't find the GC log in the POC web. Is it only > > > generated when some configuration is enabled? > > > > > > Best, > > > Jark > > > > > > On Fri, 21 Feb 2020 at 11:40, Kurt Young <k...@apache.org> wrote: > > > > > > +1 (binding) > > > > > > > > > On Fri, Feb 21, 2020 at 11:25 AM lining jing <jinglini...@gmail.com> > > > wrote: > > > > > > +1 (non-binding) > > > It lists all log files, the user could see the GC log. > > > > > > Xintong Song <tonysong...@gmail.com> 于2020年2月21日周五 上午10:44写道: > > > > > > +1 (non-binding) > > > > > > I like the ideas of having a list of all log files, and make them > > > downloadable. > > > > > > Thank you~ > > > > > > Xintong Song > > > > > > > > > > > > On Fri, Feb 21, 2020 at 10:24 AM Yang Wang < > > > danrtsey...@gmail.com> > > > wrote: > > > > > > +1 non-binding > > > > > > The log files list are shown in the new design. I like the > > > idea. > > > Since > > > the > > > user defined logs(e.g. my-log.file) > > > could be found here now. > > > > > > > > > Best, > > > Yang > > > > > > Yadong Xie <vthink...@gmail.com> 于2020年2月20日周四 下午5:56写道: > > > > > > Hi all > > > > > > I want to start the vote for FLIP-103, which proposes to > > > provide > > > better > > > user log display UI in task manager and job manager. > > > > > > To help everyone better understand the proposal, we spent > > > some > > > efforts > > > on > > > making an online POC > > > > > > Task manager: > > > > > > previous web: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://101.132.122.69:8081/#/task-manager/6df6c5f37b2bff125dbc3a7388128559/logs > > > POC web: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://101.132.122.69:8081/web/#/task-manager/6df6c5f37b2bff125dbc3a7388128559/log > > > > > > Job manager: > > > > > > previous web: http://101.132.122.69:8081/#/job-manager/logs > > > POC web: http://101.132.122.69:8081/web/#/job-manager/log > > > > > > > > > The vote will last for at least 72 hours, following the > > > consensus > > > voting > > > process. > > > > > > FLIP wiki: > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=147427143 > > > > > > Discussion thread: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-75-Flink-Web-UI-Improvement-Proposal-td33540.html > > > > > > Thanks, > > > > > > Yadong > > > > > > > > > > > > > > > > > > > > > > > > > > >