Thanks Robert, I think these supplements are quite instructive and make the
whole process more clear.
nit: it surprised me a little bit that this voting thread of a canceled RC
is revived so I edited the subject in this reply.
Best Regards,
Yu
On Mon, 4 May 2020 at 22:48, Robert Metzger wrote:
I think I conceptually added everything Stephan mentioned into the Wiki:
https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=97552147&selectedPageVersions=5&selectedPageVersions=3
I'm looking forward to any comments or corrections.
On Wed, Apr 1, 2020 at 12:20 PM Chesnay Sch
Let's add this information to the licensing wiki page.
https://cwiki.apache.org/confluence/display/FLINK/Licensing
On 01/04/2020 12:16, Yu Li wrote:
Thanks Stephan, this is enlightening!
Best Regards,
Yu
On Wed, 1 Apr 2020 at 16:30, Stephan Ewen wrote:
@Yu - there is nothing magic behind
Thanks Stephan, this is enlightening!
Best Regards,
Yu
On Wed, 1 Apr 2020 at 16:30, Stephan Ewen wrote:
> @Yu - there is nothing magic behind the license check, but I can share
> what I did there.
>
> Source distribution:
> - This means code copied into the repo.
> - The Java source code i
This vote thread is cancelled.
Please refer to the new RC5:
http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/VOTE-Apache-Flink-Stateful-Functions-Release-2-0-0-release-candidate-5-td39648.html
.
On Wed, Apr 1, 2020 at 4:39 PM Tzu-Li (Gordon) Tai
wrote:
> Thanks for all the efforts
Thanks for all the efforts on checking the licenses.
It seems that we're now on a good state to start a new RC with the various
license fixes.
Will post the RC5 vote thread shortly after.
On Wed, Apr 1, 2020 at 4:30 PM Stephan Ewen wrote:
> @Yu - there is nothing magic behind the license check,
@Yu - there is nothing magic behind the license check, but I can share what
I did there.
Source distribution:
- This means code copied into the repo.
- The Java source code is usually fine, committers copying code verbatim
usually comment on that directly.
- Most important are other files, l
+1 to include the changes (modulo the PR comments) and create a new RC.
Best,
Stephan
On Wed, Apr 1, 2020 at 4:55 AM Tzu-Li (Gordon) Tai
wrote:
> All issues FLINK-16891 to FLINK-16897 have been resolved, with Stephan's
> PR, including the hard blocker on the missing jquery license.
>
> I have
Thanks Gordon and everyone else for addressing the various licensing issues!
+1 to include these fixies and create a new RC.
Thanks,
Igal.
On Wednesday, April 1, 2020, Tzu-Li (Gordon) Tai
wrote:
> @Yu Li
> I fixed the tagged JIRA versions while closing the issues.
>
> On Wed, Apr 1, 2020 at 10
@Yu Li
I fixed the tagged JIRA versions while closing the issues.
On Wed, Apr 1, 2020 at 10:54 AM Tzu-Li (Gordon) Tai
wrote:
> All issues FLINK-16891 to FLINK-16897 have been resolved, with Stephan's
> PR, including the hard blocker on the missing jquery license.
>
> I have some final licensing
All issues FLINK-16891 to FLINK-16897 have been resolved, with Stephan's
PR, including the hard blocker on the missing jquery license.
I have some final licensing touches as well here (non of which are blockers
to the release, but nonetheless nice to fix if we're going have a new RC):
https://gith
Hi Stephan,
Could you also share the method of license check, so more people could help
in future votes? And maybe adding some instructions into our wiki [1]? I
skipped the licensing check in my vote because not aware of a good way to
do it thoroughly, not sure whether I'm the only one having such
I did a release check for license issues - all in all, we need a new RC.
The only blocker I found was the missing jquery license file.
Another somewhat critical thing is that "statefun-flink-distribution"
bundles many unwanted dependencies.
- Because the shading merges the notice files, this is
I have found a few things, am preparing a joint PR to fix them.
So far, only the missing jquery license would have been a release blocker.
On Tue, Mar 31, 2020 at 6:24 PM Chesnay Schepler wrote:
> The jquery license is in fact missing from the master/release-1.10
> branches. https://issues.apac
The jquery license is in fact missing from the master/release-1.10
branches. https://issues.apache.org/jira/browse/FLINK-16888
On 31/03/2020 12:18, Chesnay Schepler wrote:
For Kafka we traditionally exclude the NOTICE file since as far as we
can tell it is misleading anyway, see the flink-sql-
Agree, an additional thorough licensing check would be good here.
I am doing one right now, will post the results soon...
On Tue, Mar 31, 2020 at 12:18 PM Chesnay Schepler
wrote:
> For Kafka we traditionally exclude the NOTICE file since as far as we
> can tell it is misleading anyway, see the f
For Kafka we traditionally exclude the NOTICE file since as far as we
can tell it is misleading anyway, see the flink-sql-connector-kafka modules.
@Robert for the Flink project the jquery license is in the source at
licenses/LICENSE.jquery
I'm a bit concerned just how many licensing issues ar
On Tue, Mar 31, 2020 at 5:57 PM Robert Metzger wrote:
> Thanks a lot Gordon!
>
> Checked:
> - files in the staging repository seem to be ok (no unexpected files,
> versions set correctly, quickstart archetype looks ok)
> - statefun-ridesharing-example-simulator-2.0.0.jar (and
>
> /org/apache/flin
Thanks a lot Gordon!
Checked:
- files in the staging repository seem to be ok (no unexpected files,
versions set correctly, quickstart archetype looks ok)
- statefun-ridesharing-example-simulator-2.0.0.jar (and
/org/apache/flink/statefun-flink-distribution/2.0.0/statefun-flink-distribution-2.0.0.j
=== NOTICE ===
For your testing, please continue to use this staging area for the Maven
artifacts:
https://repository.apache.org/content/repositories/orgapacheflink-1344/
The only difference between this staging repo and the original repo posted
in this thread (
https://repository.apache.
Sounds good, I'll post a new link to this vote thread, which will have the
problem fixed in a new maven staging repository.
On Tue, Mar 31, 2020 at 2:51 PM Robert Metzger wrote:
> Thank you for looking into this.
>
> I'm fine with keeping this RC open, but re-vote on a new maven staging
> reposi
Thank you for looking into this.
I'm fine with keeping this RC open, but re-vote on a new maven staging
repository.
On Tue, Mar 31, 2020 at 8:42 AM Tzu-Li (Gordon) Tai
wrote:
> Found the culprit:
>
> The Stateful Functions project uses the Apache POM as the parent POM, and
> uses the `apache-re
Found the culprit:
The Stateful Functions project uses the Apache POM as the parent POM, and
uses the `apache-release` build profile to build the staging jars.
The problem arises because the `apache-release` build profile itself
bundles a source release distribution to be released to Maven.
This
Hi Robert,
I think you're right. There should be no tarballs / jars packaged for
statefun-parent actually, only the pom file since that's the parent module
which only has pom packaging.
I'm looking into it.
On Tue, Mar 31, 2020 at 2:23 PM Robert Metzger wrote:
> While checking the release, I fo
While checking the release, I found a 77
MB statefun-parent-2.0.0-source-release.zip file in the maven staging repo:
https://repository.apache.org/content/repositories/orgapacheflink-1343/org/apache/flink/statefun-parent/2.0.0/
It seems that the file contains all ruby dependencies in docs/ from je
+1 (binding)
** Legal **
- checksums and GPG files match corresponding release files
- Source distribution does not contain binaries, contents are sane (no
.git* / .travis* / generated html content files)
- Bundled source LICENSEs and NOTICE looks good. Mentions bundled
font-awesome dependency in
FYI - I've also updated the website Downloads page to include this release.
Please also consider that for your reviews:
https://github.com/apache/flink-web/pull/318
On Tue, Mar 31, 2020 at 3:42 AM Konstantin Knauf
wrote:
> Hi Gordon,
>
> +1 (non-binding)
>
> * Maven build from source...check
> *
+1 (non-binding)
Checked sums and signatures: OK
Checked no binaries in source distribution: OK
Checked RAT and end-to-end tests (8u101, 11.0.4): OK
Checked version in pom/README/setup.py files: OK
Checked quick start: OK
Checked Greeter local docker-compose examples: OK
Checked Ridesharing local
Hi Gordon,
+1 (non-binding)
* Maven build from source...check
* Python build from source...check
* Went through Walkthrough based on local builds...check
Cheers,
Konstantin
On Mon, Mar 30, 2020 at 5:52 AM Tzu-Li (Gordon) Tai
wrote:
> Hi everyone,
>
> Please review and vote on the *release ca
Hi everyone,
Please review and vote on the *release candidate #4* for the version 2.0.0
of Apache Flink Stateful Functions,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
**Testing Guideline**
You can find here [1] a doc that we can
30 matches
Mail list logo
