; which means without implication. I guess it would save some efforts.
>
> My above concern is tiny and might not be the key motivation of this
> discussion. Just share my thoughts by this chance. :)
>
> Best,
> Zhijiang
>
>
> -----------------
--
From:Yangze Guo
Send Time:2020 Feb. 21 (Fri.) 16:16
To:dev
Subject:Re: [Discuss] Update the pull request description template.
In my experience, the template is helpful. Especially for the people
just joined the community and give their first PR. I don'
In my experience, the template is helpful. Especially for the people
just joined the community and give their first PR. I don't know how
many people have read the contributor guide entirely before they
commit their first PR, but I should admit that I did not read it word
by word for the first time,
I second xintong's suggestion. When i open a PR, i also check the item list
in the template. It help to
know whether i should test the PR in a real cluster(Yarn/K8s/Mesos). Or i
should be more careful
when touching the per-record code paths.If we have some dependencies
changes, i will need to check
Thanks for the feedbacks, Chesnay and Till. And thanks for the pointer,
Congxian.
I don't know how often committers and reviewers checks and benefits from
the PR description. From your feedbacks and the number of responses to this
discussion, it's probably not often.
However, as a contributor and
I actually wanted to second Chesnay but apparently my impression is a bit
wrong. Out of the last 10 closed PRs (admittedly a small sample size) only
2 did not fill out the template. I did not check for correctness though.
Assuming that people use the template, I believe it is a good idea to
update
JFYI, there is an issue[1] which I think is related to this thread
[1] https://issues.apache.org/jira/browse/FLINK-15977
Best,
Congxian
Chesnay Schepler 于2020年2月17日周一 下午9:08写道：
> I think it should just be removed since 99% of pull requests ignore it
> anyway.
>
> On 17/02/2020 13:31, Xintong S
I think it should just be removed since 99% of pull requests ignore it
anyway.
On 17/02/2020 13:31, Xintong Song wrote:
Hi all,
It seems our PR description template is a bit outdated, and I would like to
propose updating it.
I was working on a Kubernetes related PR, and realized that our PR
d
Hi all,
It seems our PR description template is a bit outdated, and I would like to
propose updating it.
I was working on a Kubernetes related PR, and realized that our PR
description does not mention the new Kubernetes integration questioning
about deployment related changes. Currently is is as
