I actually wanted to second Chesnay but apparently my impression is a bit wrong. Out of the last 10 closed PRs (admittedly a small sample size) only 2 did not fill out the template. I did not check for correctness though.
Assuming that people use the template, I believe it is a good idea to update it. One thing to consider is whether we wanna keep the S3 item or want to generalize it. I think there was some reason why we explicitly added it to the template but I cannot really remember. Cheers, Till On Mon, Feb 17, 2020 at 3:02 PM Congxian Qiu <qcx978132...@gmail.com> wrote: > JFYI, there is an issue[1] which I think is related to this thread > [1] https://issues.apache.org/jira/browse/FLINK-15977 > > Best, > Congxian > > > Chesnay Schepler <ches...@apache.org> 于2020年2月17日周一 下午9:08写道： > > > I think it should just be removed since 99% of pull requests ignore it > > anyway. > > > > On 17/02/2020 13:31, Xintong Song wrote: > > > Hi all, > > > > > > It seems our PR description template is a bit outdated, and I would > like > > to > > > propose updating it. > > > > > > I was working on a Kubernetes related PR, and realized that our PR > > > description does not mention the new Kubernetes integration questioning > > > about deployment related changes. Currently is is as follows: > > > > > >> Anything that affects deployment or recovery: JobManager (and its > > >> components), Checkpointing, Yarn/Mesos, ZooKeeper: > > >> > > > In addition to outdated contents, there might be other stuff that we > want > > > to add to the template. For example, I would suggest add a question > about > > > whether there are any memory allocation introduced by the PR, so we > > review > > > them carefully and avoid problems due to un-accounted memory > allocations > > > like FLINK-15981. (To be fair, for FLINK-15981 the memory allocation > was > > > introduced before we start to account for everything memory usage, but > > > noticing such memory allocations early should help us prevent similar > > > problems in the future). > > > > > > Therefore, I'd also like to collect ideas on how do you think the > > template > > > should be updated in this discussion thread. > > > > > > Looking forward to your feedback~! > > > > > > Thank you~ > > > > > > Xintong Song > > > > > > > >
