Re: [Discuss] Some questions on flink-table-store micro benchmark

2023-02-27 Thread Yun Tang
: Monday, February 27, 2023 18:02 To: dev@flink.apache.org Subject: Re: [Discuss] Some questions on flink-table-store micro benchmark Hi Yun and Shammon, > track the performance changes of the micro benchmark I think we can create a github action for this. Print results everyday. Best, Jingsong

Re: [Discuss] Some questions on flink-table-store micro benchmark

2023-02-27 Thread Jingsong Li
Hi Yun and Shammon, > track the performance changes of the micro benchmark I think we can create a github action for this. Print results everyday. Best, Jingsong On Mon, Feb 27, 2023 at 5:59 PM Shammon FY wrote: > > Hi jingsong > > Getting rid of JMH is a good idea. For the second point, how c

Re: [Discuss] Some questions on flink-table-store micro benchmark

2023-02-27 Thread Shammon FY
Hi jingsong Getting rid of JMH is a good idea. For the second point, how can we track the performance changes of the micro benchmark? What do you think? Best, Shammon On Mon, Feb 27, 2023 at 10:57 AM Jingsong Li wrote: > Thanks Yun. > > Another way is we can get rid of JMH, something like Spar

Re: [Discuss] Some questions on flink-table-store micro benchmark

2023-02-26 Thread Jingsong Li
Thanks Yun. Another way is we can get rid of JMH, something like Spark `org.apache.spark.benchmark.Benchmark` can replace JMH. Best, Jingsong On Mon, Feb 27, 2023 at 1:24 AM Yun Tang wrote: > > Hi dev, > > I just noticed that flink-table-store had introduced the micro benchmark > module [1] to

[Discuss] Some questions on flink-table-store micro benchmark

2023-02-26 Thread Yun Tang
Hi dev, I just noticed that flink-table-store had introduced the micro benchmark module [1] to test the basic performance. And I have two questions here. First of all, we might not be able to keep the micro benchmark, which is based on JMH, in the main repo of flink-table-store. This is because