Great suggestion and observation Max.
+1 Yes, we should also splitting PRs into right and logical commits
that will definitely help with review.
Like you said some PRs are just large in nature and splitting it into
pieces may not work well so doing right commits should go hand in hand
with small P
+1 to that, Ufuk.
Making JIRA more descriptive and contain design would make it better
to review b4 jumping to the diff in the PRs.
On Thu, Mar 19, 2015 at 2:17 AM, Ufuk Celebi wrote:
>
> On 19 Mar 2015, at 09:43, Stephan Ewen wrote:
>
>> I like this proposal very much. We should do that as mu
Yeah, renaming totally will contain large file changes.
On Thu, Mar 19, 2015 at 1:43 AM, Stephan Ewen wrote:
> I like this proposal very much. We should do that as much as possible.
>
> Pull requests with renaming easily add up to many files, it is harder there.
> Am 18.03.2015 19:39 schrieb "Hen
I agree with you, Henry. Reviewing hundreds of changes class files is a
difficult and a nearly impossible task to do exhaustive.
However, splitting up pull requests also has some drawbacks. For example,
discussions and comments are also split up and harder to keep up with.
Also, pull requests migh
On 19 Mar 2015, at 09:43, Stephan Ewen wrote:
> I like this proposal very much. We should do that as much as possible.
Same here. Makes it also easier to track progress.
(I think this should go hand in hand with better design descriptions in the
corresponding JIRAs.)
I like this proposal very much. We should do that as much as possible.
Pull requests with renaming easily add up to many files, it is harder there.
Am 18.03.2015 19:39 schrieb "Henry Saputra" :
> Hi All,
>
> Recently there have been some PRs with massive changes which include
> multiple JIRA tick
Hi All,
Recently there have been some PRs with massive changes which include
multiple JIRA tickets.
It is getting tougher to review and also to back port changes if needed.
To help reviewers to help review the changes lets try to submit small
but often PRs to make it easier to review.
Not to men
