Yeah, renaming totally will contain large file changes.
On Thu, Mar 19, 2015 at 1:43 AM, Stephan Ewen <se...@apache.org> wrote: > I like this proposal very much. We should do that as much as possible. > > Pull requests with renaming easily add up to many files, it is harder there. > Am 18.03.2015 19:39 schrieb "Henry Saputra" <henry.sapu...@gmail.com>: > >> Hi All, >> >> Recently there have been some PRs with massive changes which include >> multiple JIRA tickets. >> >> It is getting tougher to review and also to back port changes if needed. >> >> To help reviewers to help review the changes lets try to submit small >> but often PRs to make it easier to review. >> Not to mention Github UI suffers with diff changes over 200 files and >> thousands lines of code changes =) >> >> When committing to ASF git it should be fine to combine one day of >> work but PRs should as isolated as possible. >> >> Exception such as new module like Gelly or ML maybe ok, but others >> that require changes to the execution flow should be done if smaller >> batches if possible. >> >> Thanks, >> >> Henry >>
