Re: [DISCUSS] Move flink-orc to flink-formats from flink-connectors

2019-10-30 Thread Fabian Hueske
+1 from my side as well. Am Mi., 30. Okt. 2019 um 04:51 Uhr schrieb Jingsong Li < jingsongl...@gmail.com>: > Thanks jark for reminding me. > I will start a vote thread. > > On Wed, Oct 30, 2019 at 11:40 AM Jark Wu wrote: > > > Hi Jingsong, > > > > Do we need a formal vote? Or do we need to wait

Re: [DISCUSS] Move flink-orc to flink-formats from flink-connectors

2019-10-29 Thread Jingsong Li
Thanks jark for reminding me. I will start a vote thread. On Wed, Oct 30, 2019 at 11:40 AM Jark Wu wrote: > Hi Jingsong, > > Do we need a formal vote? Or do we need to wait for "Lazy > Majority" approval [1] which requires 3 binding votes? > > Best, > Jark > > [1]: > https://cwiki.apache.org/con

Re: [DISCUSS] Move flink-orc to flink-formats from flink-connectors

2019-10-29 Thread Jark Wu
Hi Jingsong, Do we need a formal vote? Or do we need to wait for "Lazy Majority" approval [1] which requires 3 binding votes? Best, Jark [1]: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=120731026 On Wed, 30 Oct 2019 at 11:12, Jingsong Li wrote: > Hi bowen, > I think the r

Re: [DISCUSS] Move flink-orc to flink-formats from flink-connectors

2019-10-29 Thread Jingsong Li
Hi bowen, I think the reason is that flink-orc was developed earlier than flink-formats. Thanks the responses of everyone, I will create JIRA to do it. On Wed, Oct 30, 2019 at 10:27 AM Danny Chan wrote: > +1 to move to flink-format. > > Best, > Danny Chan > 在 2019年10月29日 +0800 AM11:10,dev@flink

Re: [DISCUSS] Move flink-orc to flink-formats from flink-connectors

2019-10-29 Thread Danny Chan
+1 to move to flink-format. Best, Danny Chan 在 2019年10月29日 +0800 AM11:10,dev@flink.apache.org,写道: > > +1 to move to flink-format.

Re: [DISCUSS] Move flink-orc to flink-formats from flink-connectors

2019-10-29 Thread Jark Wu
+1 to move to flink-format. Best, Jark On Wed, 30 Oct 2019 at 02:27, Bowen Li wrote: > Hi Jingsong, > > Thanks for bringing it up. I found flink-orc lives under flink-connectors > instead of flink-formats to be confusing too. > > I wonder why it's that way in the beginning? If there's no good r

Re: [DISCUSS] Move flink-orc to flink-formats from flink-connectors

2019-10-29 Thread Bowen Li
Hi Jingsong, Thanks for bringing it up. I found flink-orc lives under flink-connectors instead of flink-formats to be confusing too. I wonder why it's that way in the beginning? If there's no good reason to remain that way, +1 to move flink-orc to flink-formats Bowen On Mon, Oct 28, 2019 at 11

Re: [DISCUSS] Move flink-orc to flink-formats from flink-connectors

2019-10-28 Thread Zhenghua Gao
+1 to move flink-orc to flink-formats. Since we have put other file-based formats(flink-avro, flink-json, flink-parquet, flink-json, flink-csv, flink-sequence-file) in flink-formats, flink-orc should be the same. *Best Regards,* *Zhenghua Gao* On Tue, Oct 29, 2019 at 11:10 AM Jingsong Lee wrote

[DISCUSS] Move flink-orc to flink-formats from flink-connectors

2019-10-28 Thread Jingsong Lee
Hi devs, I found that Orc is still in connectors, but we already have the parent model of formats. - Is it better to put flink-orc in flink-formats? - Is there a compatibility issue with the move? Looks like only the parent model needs to be changed, and no other changes are needed. -- Best, Jin