+1 to move to flink-format. Best, Jark
On Wed, 30 Oct 2019 at 02:27, Bowen Li <bowenl...@gmail.com> wrote: > Hi Jingsong, > > Thanks for bringing it up. I found flink-orc lives under flink-connectors > instead of flink-formats to be confusing too. > > I wonder why it's that way in the beginning? If there's no good reason to > remain that way, +1 to move flink-orc to flink-formats > > Bowen > > > On Mon, Oct 28, 2019 at 11:26 PM Zhenghua Gao <doc...@gmail.com> wrote: > > > +1 to move flink-orc to flink-formats. > > Since we have put other file-based formats(flink-avro, flink-json, > > flink-parquet, flink-json, flink-csv, flink-sequence-file) > > in flink-formats, flink-orc should be the same. > > > > *Best Regards,* > > *Zhenghua Gao* > > > > > > On Tue, Oct 29, 2019 at 11:10 AM Jingsong Lee <lzljs3620...@apache.org> > > wrote: > > > > > Hi devs, > > > > > > I found that Orc is still in connectors, but we already have the parent > > > model of formats. > > > - Is it better to put flink-orc in flink-formats? > > > - Is there a compatibility issue with the move? Looks like only the > > parent > > > model needs to be changed, and no other changes are needed. > > > > > > -- > > > Best, Jingsong Lee > > > > > >
