Re: [DISCUSS] Merge flink-connector-testing into flink-connector-test-utils

2022-01-19 Thread Qingsheng Ren
Thank you all for the feedback! I created FLINK-25712 [1] for merging these two modules. [1] https://issues.apache.org/jira/browse/FLINK-25712 Best, Qingsheng > On Jan 19, 2022, at 4:14 PM, Martijn Visser wrote: > > Thanks for bringing this up, +1 to merge the modules to simplify the > la

Re: [DISCUSS] Merge flink-connector-testing into flink-connector-test-utils

2022-01-19 Thread Martijn Visser
Thanks for bringing this up, +1 to merge the modules to simplify the landscape for the users. Best regards, Martijn On Wed, 19 Jan 2022 at 04:30, Jingsong Li wrote: > +1 to merge the two modules. > > Merging them I don't see any problem, not merging them I feel will > only increase the complexi

Re: [DISCUSS] Merge flink-connector-testing into flink-connector-test-utils

2022-01-18 Thread Jingsong Li
+1 to merge the two modules. Merging them I don't see any problem, not merging them I feel will only increase the complexity of the dependencies. Best, Jingsong On Wed, Jan 19, 2022 at 11:19 AM Jark Wu wrote: > > +1 to merge the two modules. This can avoid confusion when developers test > conne

Re: [DISCUSS] Merge flink-connector-testing into flink-connector-test-utils

2022-01-18 Thread Jark Wu
+1 to merge the two modules. This can avoid confusion when developers test connectors. Please also remember to add a release note that the "flink-connector-testing" is removed and should use "flink-connector-test-utils" instead. Best, Jark On Tue, 18 Jan 2022 at 21:28, Leonard Xu wrote: > Than

Re: [DISCUSS] Merge flink-connector-testing into flink-connector-test-utils

2022-01-18 Thread Leonard Xu
Thanks @Qingsheng for driving this. +1 to use one connector test utils module flink-connector-test-utils. Using single tool module dependency is more friendly to connector developers, especially external connector devs. Putting E2E test utils and units test utils in one module also makes sense

[DISCUSS] Merge flink-connector-testing into flink-connector-test-utils

2022-01-13 Thread Qingsheng Ren
Hi all, I’d like to start a discussion about merging two utilization modules "flink-connector-testing" and "flink-connector-test-utils". Both modules are designed for providing connector testing infrastructures and helper classes, so merging these two modules could simplify dependencies of conn