Thanks for bringing this up, +1 to merge the modules to simplify the landscape for the users.
Best regards, Martijn On Wed, 19 Jan 2022 at 04:30, Jingsong Li <jingsongl...@gmail.com> wrote: > +1 to merge the two modules. > > Merging them I don't see any problem, not merging them I feel will > only increase the complexity of the dependencies. > > Best, > Jingsong > > On Wed, Jan 19, 2022 at 11:19 AM Jark Wu <imj...@gmail.com> wrote: > > > > +1 to merge the two modules. This can avoid confusion when developers > test > > connectors. > > > > Please also remember to add a release note that the > > "flink-connector-testing" is removed and should use > > "flink-connector-test-utils" instead. > > > > Best, > > Jark > > > > On Tue, 18 Jan 2022 at 21:28, Leonard Xu <xbjt...@gmail.com> wrote: > > > > > Thanks @Qingsheng for driving this. > > > > > > +1 to use one connector test utils module flink-connector-test-utils. > > > > > > Using single tool module dependency is more friendly to connector > > > developers, especially external connector devs. > > > > > > Putting E2E test utils and units test utils in one module also makes > sense > > > to devs from my side. > > > > > > As flink-connector-testing is introduced since Flink 1.14 as > experimental > > > purpose and I also checked no external connector use this dependency, > > > I think we can create an issue to merge them if no objections. > > > > > > > > > Best, > > > Leonard > > > > > > > 2022年1月13日 下午4:37，Qingsheng Ren <renqs...@gmail.com> 写道： > > > > > > > > Hi all, > > > > > > > > I’d like to start a discussion about merging two utilization modules > > > "flink-connector-testing" and "flink-connector-test-utils". Both > modules > > > are designed for providing connector testing infrastructures and helper > > > classes, so merging these two modules could simplify dependencies of > > > connectors and reduce the complexity of Flink project. > > > > > > > > The plan is to move classes in flink-connector-testing to > > > flink-connector-test-utils, since the latter one have been existing > for a > > > longer time in the projects, and flink-connector-testing is in > experimental > > > status now. > > > > > > > > Currently these two modules work as follows: > > > > > > > > "flink-connector-test-utils" provides utilization classes supporting > > > unit tests for connector, such as TestingReaderContext and > > > TestingSplitEnumeratorContext, and a test suite SourceReaderTestBase > with > > > general test cases for source readers. > > > > > > > > "flink-connector-testing" is the experimental connector testing > > > framework, aiming to support connector’s end-to-end tests and provide > > > standard test suites with general E2E cases. > > > > > > > > Looking forward to your feedback! > > > > > > > > Best regards, > > > > > > > > Qingsheng Ren > > > > > > >
