Hi Danny,
Thanks for updating the documentation, I really like this design. But I
have two more suggestions:
1) As "STORED" keyword is not in the MVP, I would like to remove the
optional "[VIRTUAL]" keyword as well.
Because this optional keyword is useless for now, all the computed columns
are vi
The updated doc looks good to me now, +1 to kick off a voting thread.
Best,
Kurt
On Fri, Oct 25, 2019 at 8:46 PM Danny Chan wrote:
> Thanks, I have removed the contents about the “STORED” keyword, we may
> introduce that in the future if there is requests.
>
> Also thanks all the reviewers for
Thanks, I have removed the contents about the “STORED” keyword, we may
introduce that in the future if there is requests.
Also thanks all the reviewers for the design doc, I have resolved all the
questions/suggestions in the doc at this time.
I will kick off a voting thread shortly as there wer
If we move "STORED" to future work section, it is still unclear that
whether we should have an consensu on the design of "STORED"?
1) no consensus needed, we just put the design effort in the future part to
continue the work if we want to support it in the future. So the vote on
this FLIP dosen't
Yes. I think it makes sense to move to "Future Work" section.
Best,
Jark
On Thu, 24 Oct 2019 at 17:11, Kurt Young wrote:
> +1 to move to a future section. By deleting it I mean remove from
> the content describing the current processing procedure.
>
> Best,
> Kurt
>
>
> On Thu, Oct 24, 2019 at
+1 to move to a future section. By deleting it I mean remove from
the content describing the current processing procedure.
Best,
Kurt
On Thu, Oct 24, 2019 at 5:01 PM Timo Walther wrote:
> Having an MVP and a limited scope sounds good to me. But I would not
> remove the STORED keyword entirely
Having an MVP and a limited scope sounds good to me. But I would not
remove the STORED keyword entirely from the document.
It shows that we have a long-term vision. Instead of deleting this
content, I would move it to a Outlook/Future Work section.
Regards,
Timo
On 24.10.19 10:55, Jark Wu w
+1 to remove “STORED” related content. We can add them when user requires.
Others looks good to me in general.
Thanks,
Jark
> 在 2019年10月24日，14:58，Kurt Young 写道：
>
> Hi Danny,
>
> Thanks for preparing this design document. IMO It's a very useful
> feature, especially combined with time attri
Hi Danny,
Thanks for preparing this design document. IMO It's a very useful
feature, especially combined with time attribute support to specify
watermark in DDL.
The design doc looks quite good, but I would suggest to reduce the
scope of the first version. Like we don't have to support "STORED"
i
Fantastic! We're also very interested in this feature.
+Boxiu
On Tue, Sep 17, 2019 at 11:31 AM Danny Chan wrote:
> In umbrella task FLINK-10232 we have introduced CREATE TABLE grammar in
> our new module flink-sql-parser. And we proposed to use computed column to
> describe the time attribute o
In umbrella task FLINK-10232 we have introduced CREATE TABLE grammar in our new
module flink-sql-parser. And we proposed to use computed column to describe the
time attribute of process time in the design doc FLINK SQL DDL, so user may
create a table with process time attribute as follows:
creat
11 matches
Mail list logo
