Re: [DISCUSS] FLIP-478: Introduce Config Option Scope

2024-10-16 Thread Junrui Lee
Hi, devs After discussing offline with Lincoln Lee and Shengkai Fang, we realized that some SQL config options, like table.sql-dialect, may also server DDL in which case no Flink job will run. Including these options under the JOB scope is not accurate. So we propose introducing a new SQL_EXECUTI

Re: [DISCUSS] FLIP-478: Introduce Config Option Scope

2024-10-09 Thread Rui Fan
Thanks Junrui for the quick clarification! Sounds good to me, +1 for this FLIP. Best, Rui On Thu, Oct 10, 2024 at 10:52 AM Junrui Lee wrote: > Hi Rui, > > Thank you for your response. Here are my replies to your questions: > > Regarding question 1: We plan to label the config options on the Fl

Re: [DISCUSS] FLIP-478: Introduce Config Option Scope

2024-10-09 Thread Junrui Lee
Hi Rui, Thank you for your response. Here are my replies to your questions: Regarding question 1: We plan to label the config options on the Flink configuration page in the upcoming 2.0 version. In the long term, our goal is to ensure that all config options visible to users are properly labeled.

Re: [DISCUSS] FLIP-478: Introduce Config Option Scope

2024-10-09 Thread Rui Fan
Thanks Junrui for driving this proposal! It's valuable for users to distinguish all flink options. I have 2 minor questions about this proposal: 1. Does this FLIP enrich the scope for all old flink options? 2. If the option is configured at the wrong level, could we output some warn log to remind

Re: [DISCUSS] FLIP-478: Introduce Config Option Scope

2024-10-09 Thread Yanquan Lv
Thanks Junrui for starting this discussion! Prior to this, it takes some experience to correctly distinguish whether a configuration item is effective at CLUSTER or JOB level, and this proposal avoids such a burden. And the FLIP looks good to me. Best, Yanquan Zhu Zhu 于2024年10月9日周三 17:14写道: >

Re: [DISCUSS] FLIP-478: Introduce Config Option Scope

2024-10-09 Thread Zhu Zhu
Thanks Junrui for starting this discussion! +1 for the proposal Clarifying the scopes of config options can be beneficial for users. Even Flink developers occasionally encounter confusion regarding the scopes of various configurations, such as attempting to retrieve job-specific settings from `Tas

[DISCUSS] FLIP-478: Introduce Config Option Scope

2024-10-08 Thread Junrui Lee
Hi devs, I would like to initiate a discussion about FLIP-478: Introduce Config Option Scope Currently, Flink can be configured in various ways. Taking a session job as an example: 1. When the session cluster starts, the JobManager (JM) and TaskManager (TM) load the configuration files config.ya