The FLIP looks good to me now, let's start the vote.
Dawid Wysakowicz 于2023年11月20日周一 22:36写道：
>
> @Benchao I added an example to the page.
>
> If there are no further comments, I'll start a vote on the FLIP tomorrow or
> the next day.
>
> Best,
> Dawid
>
> On Fri, 17 Nov 2023 at 12:20, xiangyu fe
@Benchao I added an example to the page.
If there are no further comments, I'll start a vote on the FLIP tomorrow or
the next day.
Best,
Dawid
On Fri, 17 Nov 2023 at 12:20, xiangyu feng wrote:
> >After this FLIP is done, FLINK-25015() can utilize this ability to set
> > job name for queries.
>
>After this FLIP is done, FLINK-25015() can utilize this ability to set
> job name for queries.
+1 for this. Currently, when users submit sql jobs through table api, we
can't see the complete SQL string on flink ui. It would be easy for us to
finish this feature if we can get serialized sql from Q
That sounds good to me, I'm looking forward to it!
After this FLIP is done, FLINK-25015 can utilize this ability to set
job name for queries.
Dawid Wysakowicz 于2023年11月16日周四 21:16写道：
>
> Yes, the idea is to convert the QueryOperation tree into a
> proper/compilable query. To be honest I didn't t
Yes, the idea is to convert the QueryOperation tree into a
proper/compilable query. To be honest I didn't think it could be done
differently, sorry if I wasn't clear enough. Yes, it is very much like
SqlNode#toSqlString you mentioned. I'll add an example of a single
QueryOperation tree to the FLIP.
Sorry that I wasn't expressing it clearly.
Since the FLIP talks about two things: ResolvedExpression and
QueryOperation, and you have illustrated how to serialize
ResolvedExpression into SQL string. I'm wondering how you'll gonna to
convert QueryOperation into SQL string.
I was thinking that you
I think the FLIP covers all public contracts that are necessary to be
discussed at that level.
If you meant you could not find a method that would be called to trigger
the translation then it is already there. It's just not implemented yet:
QueryOperation#asSerializableString[1]. As I mentioned th
+1 for the idea of choosing SQL as the serialization format for
QueryOperation, thanks for Dawid for driving this FLIP.
Regarding the implementation, I didn't see the proposal for how to
translate QueryOperation to SQL yet, am I missing something? Or the
FLIP is still in preliminary state, you jus
Hi,
I would like to propose a follow-up improvement to some of the work that
has been done over the years to the Table API. I posted the proposed
changes in the FLIP-393. I'd like to get to know what others think of
choosing SQL as the serialization format for QueryOperations.
Regards,
Dawid Wysako
