Re: [DISCUSS] FLIP-335: Removing Flink's Time classes as part of Flink 2.0

2023-12-04 Thread weijie guo
Thanks for driving this FLIP, Matthias. I'm +1 for this. Best regards, Weijie Matthias Pohl 于2023年7月19日周三 22:32写道: > The overall Scala-related plan for this FLIP is to ignore the Scala API > because of FLIP-265. The CEP Java/Scala version > parity (through the PatternScalaAPICompletenessTest

Re: [DISCUSS] FLIP-335: Removing Flink's Time classes as part of Flink 2.0

2023-07-19 Thread Matthias Pohl
The overall Scala-related plan for this FLIP is to ignore the Scala API because of FLIP-265. The CEP Java/Scala version parity (through the PatternScalaAPICompletenessTest) requires us to touch the Scala API, though, because we want to offer an alternative to the deprecated API in FLink 1.x. I want

Re: [DISCUSS] FLIP-335: Removing Flink's Time classes as part of Flink 2.0

2023-07-17 Thread Chesnay Schepler
I don't understand this bit:/ "One minor Scala change is necessary, though: We need to touch the Scala implementation of the Pattern class (in flink-cep). Pattern requires a new method which needs to be implemented in the Scala Pattern class as well to comply with PatternScalaAPICompletenessTe

Re: [DISCUSS] FLIP-335: Removing Flink's Time classes as part of Flink 2.0

2023-07-16 Thread Xintong Song
Thanks for creating this FLIP, Matthias. +1 from my side. BTW, it's impressive how this FLIP clearly states the proposed API changes and impacts on other classes / APIs, which makes it much easier for others to evaluate the proposal. Nice work~! Best, Xintong On Thu, Jul 13, 2023 at 9:11 PM J

Re: [DISCUSS] FLIP-335: Removing Flink's Time classes as part of Flink 2.0

2023-07-13 Thread Jing Ge
yeah, saw that thread. Thanks for starting the discussion! Best regards, Jing On Thu, Jul 13, 2023 at 2:15 PM Matthias Pohl wrote: > Thanks Jing. About your question regarding FLIPs: The FLIP is necessary > when these classes touch user-facing API (which should be the case if we're > preparing

Re: [DISCUSS] FLIP-335: Removing Flink's Time classes as part of Flink 2.0

2023-07-13 Thread Matthias Pohl
Thanks Jing. About your question regarding FLIPs: The FLIP is necessary when these classes touch user-facing API (which should be the case if we're preparing it for 2.0). I created a dedicated discussion thread [1] to discuss this topic because it's more general and independent of FLIP-335. Best,

Re: [DISCUSS] FLIP-335: Removing Flink's Time classes as part of Flink 2.0

2023-07-13 Thread Jing Ge
Hi Matthias, Thanks for raising this up! I saw your conversation with Chesnay in the PR and after reading the historical discussions, there should be no doubt to deprecate Time classes. +1 I just have a related question: Do we need to create a FLIP each time when we want to deprecate any classes?

[DISCUSS] FLIP-335: Removing Flink's Time classes as part of Flink 2.0

2023-07-13 Thread Matthias Pohl
The 2.0 feature list includes the removal of Flink's Time classes in favor of the JDKs java.time.Duration class. There was already a discussion about it in [1] and FLINK-14068 [2] was created as a consequence of this discussion. I started working on marking the APIs as deprecated in FLINK-32570 [3