Thanks for driving this FLIP, Matthias. I'm +1 for this.
Best regards, Weijie Matthias Pohl <matthias.p...@aiven.io.invalid> 于2023年7月19日周三 22:32写道： > The overall Scala-related plan for this FLIP is to ignore the Scala API > because of FLIP-265. The CEP Java/Scala version > parity (through the PatternScalaAPICompletenessTest) requires us to touch > the Scala API, though, because we want to offer an alternative to the > deprecated API in FLink 1.x. I wanted to point that out in that paragraph. > > The alternative would have been to add an exclusion for the newly added > method. That sounded like a worse option. Deprecating the Scala API should > be independent from the parity of Java and Scala API in Flink 1.x. > > I rewrote this paragraph in the FLIP. I hope it helps. > > Matthias > > On Mon, Jul 17, 2023 at 11:23 AM Chesnay Schepler <ches...@apache.org> > wrote: > > > I don't understand this bit:/ > > > > "One minor Scala change is necessary, though: We need to touch the Scala > > implementation of the Pattern class (in flink-cep). Pattern requires a > > new method which needs to be implemented in the Scala Pattern class as > > well to comply with PatternScalaAPICompletenessTest." > > > > /FLIP-265//states that /all/ Scala APIs will be removed, which should > > also cover CEP. > > // > > On 13/07/2023 12:08, Matthias Pohl wrote: > > > The 2.0 feature list includes the removal of Flink's Time classes in > > favor > > > of the JDKs java.time.Duration class. There was already a discussion > > about > > > it in [1] and FLINK-14068 [2] was created as a consequence of this > > > discussion. > > > > > > I started working on marking the APIs as deprecated in FLINK-32570 [3] > > > where Chesnay raised a fair point that there isn't a FLIP, yet, to > > > formalize this public API change. Therefore, I went ahead and created > > > FLIP-335 [4] to have this change properly documented. > > > > > > I'm not 100% sure whether there are better ways of checking whether > we're > > > covering everything Public API-related. There are even classes which I > > > think might be user-facing but are not labeled accordingly (e.g. > > > flink-cep). But I don't have the proper knowledge in these parts of the > > > code. Therefore, I would propose marking these methods as deprecated, > > > anyway, to be on the safe side. > > > > > > I'm open to any suggestions on improving the Test Plan of this change. > > > > > > I'm looking forward to feedback on this FLIP. > > > > > > Best, > > > Matthias > > > > > > [1]https://lists.apache.org/thread/76yywnwf3lk8qn4dby0vz7yoqx7f7pkj > > > [2]https://issues.apache.org/jira/browse/FLINK-14068 > > > [3]https://issues.apache.org/jira/browse/FLINK-32570 > > > [4] > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-335%3A+Removing+Flink%27s+Time+classes > > > > > >
