Re: [DISCUSS] FLIP-165: Operator's Flame Graphs

Thanks Alex. From my perspective we could continue with the vote now. Cheers, Till On Thu, Mar 4, 2021 at 9:15 PM Alexander Fedulov wrote: > @Till, I've added the proposed ThreadInfoSamplesRequest and updated the > FLIP and the PR accordingly. > > Best, > > -- > > Alexander Fedulov | Solutions

Re: [DISCUSS] FLIP-165: Operator's Flame Graphs

@Till, I've added the proposed ThreadInfoSamplesRequest and updated the FLIP and the PR accordingly. Best, -- Alexander Fedulov | Solutions Architect Follow us @VervericaData -- Join Flink Forward - The Apache Flink Conference Stream

Re: [DISCUSS] FLIP-165: Operator's Flame Graphs

Added docs to the PR. @David, thanks for the tip, it seems like a good place to put them. -- Alexander Fedulov | Solutions Architect Follow us @VervericaData On Wed, Mar 3, 2021 at 12:10 PM David Anderson wrote: > This is going to make performance analysis and

Re: [DISCUSS] FLIP-165: Operator's Flame Graphs

This is going to make performance analysis and optimization much more accessible. I can't wait to include this in our training courses. +1 Seth suggested putting the docs for this feature under Operations/Monitoring, but there's already a page in the docs under Operations/Debugging for Applicatio

Re: [DISCUSS] FLIP-165: Operator's Flame Graphs

Cool feature +1 There is a subsection called monitoring in the operations section of the docs. It would fit nicely there. Seth On Tue, Mar 2, 2021 at 4:23 PM Alexander Fedulov wrote: > Hi Piotr, > > Thanks for the comments - all valid points. > We should definitely document how the Flame Graph

Re: [DISCUSS] FLIP-165: Operator's Flame Graphs

Hi Piotr, Thanks for the comments - all valid points. We should definitely document how the Flame Graphs are constructed - I will work on the docs. Do you have a proposition about the part of which page/section they should become? I would like to also mention here that I plan to work on further im

Re: [DISCUSS] FLIP-165: Operator's Flame Graphs

Nice feature +1 from my side for it. In the PR I think we are missing documentation. I think it's especially important to mention the limitations of this approach for performance analysis. If we make it easy for the user to get such kind of data, it's important they do not proverbially shoot thems

Re: [DISCUSS] FLIP-165: Operator's Flame Graphs

Ah ok. Thanks for the clarification Alex. Cheers, Till On Tue, Mar 2, 2021 at 2:02 PM Alexander Fedulov wrote: > It is passed back as part of the response to the asynchronous callback > within the coordinator and is used to decide if all outstanding requests to > the parallel instances of a par

Re: [DISCUSS] FLIP-165: Operator's Flame Graphs

It is passed back as part of the response to the asynchronous callback within the coordinator and is used to decide if all outstanding requests to the parallel instances of a particular operator returned successfully. If so, the request is considered successful, sub-results are combined and the thr

Re: [DISCUSS] FLIP-165: Operator's Flame Graphs

Why does the caller of TaskExecutorGateway.requestThreadInfoSamples need to specify the request id? Is it because the caller can send a second request with the same id? Or can the caller query the result of a previous request by specifying the requestId? If the TaskExecutor does not need to know a

Re: [DISCUSS] FLIP-165: Operator's Flame Graphs

Hi Till, Thanks for your comments. * What is the requestId used for in the RPC call? It is the handle that is used as the key in the ThreadInfoRequestCoordinator's pending responses Map. I believe it was called sampleId in the StackTraceSampleCoordinator, but I decided to rename it because ther

Re: [DISCUSS] FLIP-165: Operator's Flame Graphs

Thanks for starting this discussion Alex. I really like this feature because it gives better insights into what a Flink job is doing. Quick question on the TaskExecutorGateway extension: * What is the requestId used for in the RPC call? * Would it make sense to group numSubSamples, delayBetweenSa

Re: [DISCUSS] FLIP-165: Operator's Flame Graphs

Thanks Henry, I have some issues with subscribing with our domain (it is an alias). @All, this thread is a duplicate caused by some technical issues, sorry for that. Please ignore it and use the previous one with the same title instead for the discussion: http://apache-flink-mailing-list-archive.

Re: [DISCUSS] FLIP-165: Operator's Flame Graphs

Hi Alexander, I had to moderate and accept your email to dev@ list. Could you subscribe to dev@ list for Apache Flink [1] to continue getting updates from your discussion thread? Thanks, Henry [1] https://flink.apache.org/community.html#mailing-lists On Mon, Mar 1, 2021 at 3:42 PM Alexander Fe

[DISCUSS] FLIP-165: Operator's Flame Graphs

Hi All, I would like to start a discussion for FLIP-165: Operator's Flame Graphs [1] A Flame Graph [2] is a visualization that is very effective for providing answers to the questions like: - Which methods are currently consuming CPU resources? - How CPU utilization by one method compares to the

[DISCUSS] FLIP-165: Operator's Flame Graphs

Hi All, I would like to start a discussion for FLIP-165: Operator's Flame Graphs [1] A Flame Graph [2] is a visualization that is very effective for providing answers to the questions like: - Which methods are currently consuming CPU resources? - How CPU utilization by one method compares to the