It is passed back as part of the response to the asynchronous callback within the coordinator and is used to decide if all outstanding requests to the parallel instances of a particular operator returned successfully. If so, the request is considered successful, sub-results are combined and the thread info result future for an operator completes.
https://github.com/apache/flink/pull/15054/commits/281188a025077849efd630f1f7aa801ff79a9afd#diff-20a1c89043e8d480e7af6dd36596b3558be9c6e64f6f4cf065df97fe76411c50R150 https://github.com/apache/flink/pull/15054/commits/281188a025077849efd630f1f7aa801ff79a9afd#diff-20a1c89043e8d480e7af6dd36596b3558be9c6e64f6f4cf065df97fe76411c50R277 Best, -- Alexander Fedulov | Solutions Architect <https://www.ververica.com/> Follow us @VervericaData On Tue, Mar 2, 2021 at 12:28 PM Till Rohrmann <trohrm...@apache.org> wrote: > Why does the caller of TaskExecutorGateway.requestThreadInfoSamples need to > specify the request id? Is it because the caller can send a second request > with the same id? Or can the caller query the result of a previous request > by specifying the requestId? > > If the TaskExecutor does not need to know about the id, then we might be > able to drop it. > > Cheers > Till > > On Tue, Mar 2, 2021 at 9:42 AM Alexander Fedulov <alexan...@ververica.com> > wrote: > > > Hi Till, > > > > Thanks for your comments. > > > > * What is the requestId used for in the RPC call? > > > > It is the handle that is used as the key in the > > ThreadInfoRequestCoordinator's pending responses Map. I believe it was > > called sampleId in the StackTraceSampleCoordinator, but I decided to > rename > > it because there is also a ThreadInfoSampleService which is actually > > responsible for sampling the JVM numSamples number of times. I found that > > the notion of what a sample is was a bit confusing. Now one thread info > > request corresponds to gathering numSamples from a corresponding Task. > Hope > > that makes sense. > > > > * Would it make sense to group numSubSamples, delayBetweenSamples and > > maxStackTraceDepth into a ThreadSamplesRequest class? This would decrease > > the number of parameters and group those which are closely related > > together. > > > > Good point. I will rework it accordingly. > > > > Best, > > -- > > > > Alexander Fedulov | Solutions Architect > > Follow us @VervericaData > > > > > > > > -- > > Sent from: > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/ > > >
