Re: [DISCUSS] FLIP-162 follow-up discussion

2021-03-09 Thread Leonard Xu
Thank you all for your positive feedbacks. Considering that you’re binding votes for this FLIP and all of us agreed to remove this option, Thus I update this section of FLIP-162[1], I’ll start work on it next . Best, Leonard [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-162%3A+Co

Re: [DISCUSS] FLIP-162 follow-up discussion

2021-03-09 Thread Jingsong Li
+1 Let's go straight to the right behavior. Drop the option for the wrong behavior. Best, Jingsong On Tue, Mar 9, 2021 at 4:29 PM Timo Walther wrote: > Hi Leonard, > > I'm fine with dropping the old buggy behavior immediatly. Users can > still implement a UDF with the old bavhior if needed. I

Re: [DISCUSS] FLIP-162 follow-up discussion

2021-03-09 Thread Timo Walther
Hi Leonard, I'm fine with dropping the old buggy behavior immediatly. Users can still implement a UDF with the old bavhior if needed. I hope the new functions will be well-tested so that a fallback to the old functions is not necessary as a workaround. It will definitely avoid confusion for u

Re: [DISCUSS] FLIP-162 follow-up discussion

2021-03-09 Thread Jark Wu
Thanks Leonard, I'm also +1 with not introducing this fallback option. It's error-prone to mix the implementation of wrong behavior and correct behavior. And it's better to educate users the right way in one version instead of spanning multiple versions. Best, Jark On Tue, 9 Mar 2021 at 15:15, K

Re: [DISCUSS] FLIP-162 follow-up discussion

2021-03-08 Thread Kurt Young
Hi Leonard, Thanks for this careful consideration. Given the fallback option will eventually change the behavior twice, which means potentially break user's job twice, I would also +1 to not introduce it. Best, Kurt On Fri, Mar 5, 2021 at 3:00 PM Leonard Xu wrote: > Hi, all > > As the FLIP-16

[DISCUSS] FLIP-162 follow-up discussion

2021-03-04 Thread Leonard Xu
Hi, all As the FLIP-162 discussed, we agreed current time functions’ behavior is incorrect and plan to introduce the option table.exec.fallback-legacy-time-function to enable user fallback to incorrect behavior. (1) The option is convenient for users who want to upgrade to 1.13 but don't wan