Hi, all

As the FLIP-162 discussed,  we agreed current time functions’ behavior is 
incorrect and plan to introduce the option 
table.exec.fallback-legacy-time-function to enable user fallback to incorrect 
behavior.

(1) The option is convenient for users who want to upgrade to 1.13 but don't 
want to change their sql job, user need to config the option value, this is the 
first time users influenced by these wrong functions.

(2) But we didn’t consider that the option will be deleted after one or two 
major versions, users have to change their sql job again at that time point, 
this the second time users influenced by these wrong functions.

(3) Besides, maintaining two sets of functions is prone to bugs.

I’ve discussed with some community developers offline, they tend to solve these 
functions at once i.e. Correct the wrong functions directly and do not 
introduce this option.

Considering that we will delete the configuration eventually,  comparing 
hurting users twice and bothering them for a long time, I would rather hurt 
users once.
Thus I also +1 that we should directly correct these wrong functions and remove 
the wrong functions at the same time.


If we can make a consensus in this thread, I think we can remove this option 
support in FLIP-162.
How do you think?

Best,
Leonard




Reply via email to