Re: Re: [VOTE]FLIP-480: Support to deploy script in application mode

2024-11-12 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Ferenc Csaky 于2024年11月13日周三 02:37写道: > +1 (binding) > > Best, > Ferenc > > > > > On Tuesday, November 12th, 2024 at 03:28, Xuyang > wrote: > > > > > > > +1 (non-binding) > > > > > > -- > > > > Best! > > Xuyang > > > > > > > > > > > > 在 2024-11-12 10:02:27,"Ron Liu" ron

[ANNOUNCE] New Apache Flink Committer - Junrui Li

2024-11-05 Thread Zhu Zhu
Hi everyone, On behalf of the PMC, I'm happy to announce that Junrui Li has become a new Flink Committer! Junrui has been an active contributor to the Apache Flink project for two years. He had been the driver and major developer of 8 FLIPs, contributed 100+ commits with tens of thousands of code

Re: [VOTE] FLIP-478: Introduce Config Option Scope

2024-10-16 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Shengkai Fang 于2024年10月17日周四 10:09写道: > +1(binding) > > Best, > Shengkai > > Rui Fan <1996fan...@gmail.com> 于2024年10月17日周四 10:01写道: > > > +1(binding) > > > > Best, > > Rui > > > > On Thu, Oct 17, 2024 at 10:00 AM Junrui Lee wrote: > > > > > Hi devs, > > > > > > I'd lik

Re: [VOTE] Release 2.0-preview1, release candidate #1

2024-10-15 Thread Zhu Zhu
+1 (binding) - Verified checksums and release tag - Built from source - Run an example job on a local Flink cluster and verified the result - Reviewed web PR and release note Thanks, Zhu Lincoln Lee 于2024年10月16日周三 10:37写道: > +1 (binding) > > - Verified checksums > - Checked release tag > - Bui

Re: [DISCUSS] FLIP-478: Introduce Config Option Scope

2024-10-09 Thread Zhu Zhu
Thanks Junrui for starting this discussion! +1 for the proposal Clarifying the scopes of config options can be beneficial for users. Even Flink developers occasionally encounter confusion regarding the scopes of various configurations, such as attempting to retrieve job-specific settings from `Tas

Re: [VOTE] FLIP-475: Support Adaptive Skewed Join Optimization

2024-09-12 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Lei Yang 于2024年9月12日周四 16:11写道: > Hi everyone, > > Thanks for all the feedback about FLIP-475: Support Adaptive Skewed > Join Optimization[1]. > > The discussion thread can be found here[2]. > > The vote will be open for at least 72 hours unless there are any objections

Re: [DISCUSS] FLIP-475: Support Adaptive Skewed Join Optimization.

2024-08-19 Thread Zhu Zhu
+1 for the FLIP Long-tail tasks caused by skewed data usually pose significant challenges for users. It's great that Flink can mitigate such issues automatically. Thanks, Zhu Lei Yang 于2024年8月16日周五 11:18写道: > Hi devs, > > > Junrui Lee, Xia Sun and I would like to initiate a discussion about >

Re: [VOTE] FLIP-470: Support Adaptive Broadcast Join

2024-08-11 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Lincoln Lee 于2024年8月12日周一 13:09写道: > +1 > > Best, > Lincoln Lee > > > Xia Sun 于2024年8月12日周一 09:57写道: > > > Hi everyone, > > > > Thanks for all the feedback about FLIP-470: Support Adaptive Broadcast > > Join[1]. > > The discussion thread can be found here[2]. > > > > T

Re: [DISCUSS] FLIP-468: Introducing StreamGraph-Based Job Submission.

2024-07-30 Thread Zhu Zhu
Thanks for sharing the thoughts, David! IIUC, there are two goals to make the APIs used for RPCs as versionless as possible? 1. no version mismatch happens if no code changes 2. supports different versioned Flink clients and clusters The first goal can be achieved by explicitly assigning a serialV

Re: [VOTE] FLIP-469: Supports Adaptive Optimization of StreamGraph

2024-07-28 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Ron Liu 于2024年7月29日周一 13:38写道: > +1(binding) > > Best, > Ron > > weijie guo 于2024年7月29日周一 10:03写道: > > > +1(binding) > > > > Best regards, > > > > Weijie > > > > > > Junrui Lee 于2024年7月29日周一 09:38写道: > > > > > Hi everyone, > > > > > > Thanks for all the feedback about

Re: [VOTE] FLIP-468: Introducing StreamGraph-Based Job Submission

2024-07-25 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Ron Liu 于2024年7月26日周五 11:57写道: > +1(binding) > > Best, > Ron > > Rui Fan <1996fan...@gmail.com> 于2024年7月26日周五 11:50写道: > > > Thanks Junrui for driving this proposal! > > > > +1(binding) > > > > Best, > > Rui > > > > On Fri, Jul 26, 2024 at 11:02 AM Junrui Lee wrote: >

Re: [DISCUSS] FLIP-470: Support Adaptive Broadcast Join

2024-07-19 Thread Zhu Zhu
+1 for the FLIP It's a good start to adaptively optimize the logical execution plan with runtime information. Thanks, Zhu Xia Sun 于2024年7月18日周四 18:23写道: > Hi devs, > > Junrui Lee, Lei Yang, and I would like to initiate a discussion about > FLIP-470: Support Adaptive Broadcast Join[1]. > > In g

Re: [DISCUSS] FLIP-469: Supports Adaptive Optimization of StreamGraph

2024-07-17 Thread Zhu Zhu
r information, please feel free to review the public interface > section of FLIP-469 > > Best, > Junrui > > Zhu Zhu 于2024年7月15日周一 10:29写道: > > > +1 for the FLIP > > > > It is useful to adaptively optimize logical execution plans(stream > > operators and

Re: [DISCUSS] FLIP-469: Supports Adaptive Optimization of StreamGraph

2024-07-14 Thread Zhu Zhu
+1 for the FLIP It is useful to adaptively optimize logical execution plans(stream operators and stream edges) for batch jobs. One question: The FLIP already proposed to update the REST API & Web UI to show operators that are not yet converted to job vertices. However, I think it would be better

Re: [DISCUSS] FLIP-468: Introducing StreamGraph-Based Job Submission.

2024-07-11 Thread Zhu Zhu
+1 for the FLIP. With Dataset API removed in Flink 2.0, StreamGraph will be the only operator level DAG of a Flink job. Exposing it directly to the scheduler can be helpful to deliver some exciting features. This FLIP meationed adaptive plan optimization and operator insights. I'm also thinking o

Re: [VOTE] FLIP-459: Support Flink hybrid shuffle integration with Apache Celeborn

2024-06-11 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Yuepeng Pan 于2024年6月11日周二 17:04写道: > +1 (non-binding) > > Best regards, > Yuepeng Pan > > At 2024-06-11 16:34:12, "Rui Fan" <1996fan...@gmail.com> wrote: > >+1(binding) > > > >Best, > >Rui > > > >On Tue, Jun 11, 2024 at 4:14 PM Muhammet Orazov > > wrote: > > > >> +1 (no

Re: [VOTE] FLIP-459: Support Flink hybrid shuffle integration with Apache Celeborn

2024-06-07 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Xintong Song 于2024年6月7日周五 16:08写道: > +1 (binding) > > Best, > > Xintong > > > > On Fri, Jun 7, 2024 at 4:03 PM Yuxin Tan wrote: > > > Hi everyone, > > > > Thanks for all the feedback about the FLIP-459 Support Flink > > hybrid shuffle integration with Apache Celeborn[1

Re: [DISCUSS] FLIP-459: Support Flink hybrid shuffle integration with Apache Celeborn

2024-06-05 Thread Zhu Zhu
+1 Maybe explain in the description of `taskmanager.network.hybrid-shuffle.external-remote-tier-factory.class` that it only accepts Celeborn as the remote shuffle tier at this moment? Thanks, Zhu Junrui Lee 于2024年6月6日周四 13:49写道: > Thanks Yuxin for your answer. +1 for this proposal. > > Best, >

[jira] [Created] (FLINK-35399) Add documents for batch job master failure recovery

2024-05-19 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-35399: --- Summary: Add documents for batch job master failure recovery Key: FLINK-35399 URL: https://issues.apache.org/jira/browse/FLINK-35399 Project: Flink Issue Type: Sub

Re: [VOTE] FLIP-445: Support dynamic parallelism inference for HiveSource

2024-04-25 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Ron Liu 于2024年4月26日周五 13:11写道: > +1(binding) > > Best, > Ron > > Rui Fan <1996fan...@gmail.com> 于2024年4月26日周五 12:55写道: > > > +1(binding) > > > > Best, > > Rui > > > > On Fri, Apr 26, 2024 at 10:26 AM Muhammet Orazov > > wrote: > > > > > Hey Xia, > > > > > > +1 (non-bin

Re: [VOTE] FLIP-442: General Improvement to Configuration for Flink 2.0

2024-04-17 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Yuxin Tan 于2024年4月17日周三 18:36写道: > +1 (non-binding) > > Best, > Yuxin > > > Zakelly Lan 于2024年4月17日周三 16:51写道: > > > +1 binding > > > > > > Best, > > Zakelly > > > > On Wed, Apr 17, 2024 at 2:05 PM Rui Fan <1996fan...@gmail.com> wrote: > > > > > +1(binding) > > > > > >

Re: [DISCUSS] FLIP-445: Support dynamic parallelism inference for HiveSource

2024-04-16 Thread Zhu Zhu
Thanks for creating this FLIP. @Xia +1 for this proposal. Dynamic parallelism inference can be helpful to decide a better parallelism. And it's good to unify the settings of static & dynamic parallelism inference. Thanks, Zhu Xia Sun 于2024年4月16日周二 15:12写道: > Hi everyone, > I would like to sta

Re: [VOTE] FLIP-441: Show the JobType and remove Execution Mode on Flink WebUI

2024-04-09 Thread Zhu Zhu
+1 Thanks, Zhu gongzhongqiang 于2024年4月10日周三 13:11写道: > +1 (non binding) > > > Bests, > > Zhongqiang Gong > > Rui Fan <1996fan...@gmail.com> 于2024年4月10日周三 12:36写道: > > > Hi devs, > > > > Thank you to everyone for the feedback on FLIP-441: Show > > the JobType and remove Execution Mode on Flink W

Re: [VOTE] Release 1.19.0, release candidate #1

2024-03-06 Thread Zhu Zhu
Thank you release managers for confirming the request. The fix of FLINK-34105 is merged into 1.19. Thanks, Zhu Lincoln Lee 于2024年3月6日周三 21:19写道: > Hi Yangze, > > Thanks for letting us know, this has been discussed among rms and we agree > having this fix into 1.19.0. > > Also

Re: [VOTE] Release 1.19.0, release candidate #1

2024-03-06 Thread Zhu Zhu
+1 to include the fix of FLINK-34105 in 1.19.0. Existing large scale jobs, including streaming jobs and batch jobs, may become unstable without the fix. Thanks, Zhu Yangze Guo 于2024年3月6日周三 14:13写道: > Hi, Lincoln, > > We are currently addressing the FLINK-34105, where we have encountered > an Ak

Re: [DISCUSS] FLIP-402: Extend ZooKeeper Curator configurations

2024-01-24 Thread Zhu Zhu
t;> IMHO it would be valuable to add a clear guide. > > > Ah true, I should have checked the HA-related parameters as well. > Initially, I just briefly skimmed over a few ConfigOptions names. > > @Zhu Zhu Is the alignment of the configuration parameter names also part > of t

[jira] [Created] (FLINK-34105) Akka timeout happens in TPC-DS benchmarks

2024-01-15 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-34105: --- Summary: Akka timeout happens in TPC-DS benchmarks Key: FLINK-34105 URL: https://issues.apache.org/jira/browse/FLINK-34105 Project: Flink Issue Type: Bug

Re: [DISCUSS] FLIP-403: High Availability Services for OLAP Scenarios

2024-01-15 Thread Zhu Zhu
Correction: I'm fine to use a void blobService in OLAP scenarios if it works better in most cases. -> I'm fine to use a void blobService in OLAP scenarios *by default* if it works better in most cases. Zhu Zhu 于2024年1月15日周一 17:51写道: > @Yangze > > > (with 128 p

Re: [DISCUSS] FLIP-403: High Availability Services for OLAP Scenarios

2024-01-15 Thread Zhu Zhu
ds good to me. Actually the concept of separating leader election and persistence looks great to me at the first glance. But the shared MaterialProvider makes it more complicated than I had expected. Thanks, Zhu Yangze Guo 于2024年1月11日周四 14:53写道: > Thanks for the comments, Zhu and Matthias. > >

Re: [VOTE] FLIP-405: Migrate string configuration key to ConfigOption

2024-01-11 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Xuannan Su 于2024年1月12日周五 14:24写道: > Hi all, > > I would like to clarify the statement regarding the first improvement > from the previous email, as it was incomplete. To be more specific, we > will also deprecate the getClass(String key, Class > defaultValue, ClassLoade

Re: Re: Re: [VOTE] Accept Flink CDC into Apache Flink

2024-01-11 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Hangxiang Yu 于2024年1月11日周四 14:26写道: > +1 (non-binding) > > On Thu, Jan 11, 2024 at 11:19 AM Xuannan Su wrote: > > > +1 (non-binding) > > > > Best, > > Xuannan > > > > On Thu, Jan 11, 2024 at 10:28 AM Xuyang wrote: > > > > > > +1 (non-binding)-- > > > > > > Best! >

Re: [DISCUSS] FLIP-403: High Availability Services for OLAP Scenarios

2024-01-09 Thread Zhu Zhu
age except for the job graph store. > > WDYT? > > [1] > https://issues.apache.org/jira/browse/FLINK-31816?focusedCommentId=17741054&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17741054 > > Best, > Yangze Guo > > On Mon, Jan 8, 2024 a

Re: [DISCUSS] FLIP-403: High Availability Services for OLAP Scenarios

2024-01-08 Thread Zhu Zhu
Thanks for creating the FLIP and starting the discussion, Yangze. It makes sense to me to improve the job submission performance in OLAP scenarios. I have a few questions regarding the proposed changes: 1. How about skipping the job graph persistence if the proposed config 'high-availability.enab

Re: [VOTE] FLIP-398: Improve Serialization Configuration And Usage In Flink

2023-12-27 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Zhanghao Chen 于2023年12月27日周三 15:41写道: > +1 (non-binding) > > Best, > Zhanghao Chen > > From: Yong Fang > Sent: Wednesday, December 27, 2023 14:54 > To: dev > Subject: [VOTE] FLIP-398: Improve Serialization Configuration And Usage In >

Re: [VOTE] FLIP-364: Update the default value of backoff-multiplier from 1.2 to 1.5

2023-12-19 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Rui Fan <1996fan...@gmail.com> 于2023年12月19日周二 17:17写道: > Hi everyone, > > Thank you to everyone for the feedback on FLIP-364: > Improve the restart-strategy[1] which has been voted in this thread[2]. > > After the vote on FLIP-364, there was some feedback on the user mai

Re: [DISCUSS] Should Configuration support getting value based on String key?

2023-12-14 Thread Zhu Zhu
gt; >> most > >>>>>> effective way is to not allow accessing a specific option with a > >>>>>> string-key, so that developers not awaring of this discussion won't > >>>>>> accidentally use it. On the other hand, case-2 is a m

Re: [VOTE] FLIP-383: Support Job Recovery for Batch Jobs

2023-12-14 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Xintong Song 于2023年12月14日周四 15:36写道: > +1 (binding) > > Best, > > Xintong > > > > On Thu, Dec 14, 2023 at 3:15 PM Lijie Wang > wrote: > > > Hi devs, Thanks for all feedback about the FLIP-383: Support Job Recovery > > for Batch Jobs[1]. This FLIP was discussed in [2].

Re: [DISCUSS] Should Configuration support getting value based on String key?

2023-12-13 Thread Zhu Zhu
parse the config? Pre-defined ConfigOptions are better for configuration maintenance, compared to arbitrary strings Thanks, Zhu Rui Fan <1996fan...@gmail.com> 于2023年12月13日周三 19:27写道: > Thanks Martijn for the quick clarification! > > I see Zhu Zhu and Junrui Lee are working on configur

Re: [VOTE] FLIP-335: Deprecation and removal of Flink's Time classes in favor of Java's Duration

2023-12-12 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Matthias Pohl 于2023年12月12日周二 01:32写道: > Hi everyone, > I'd like to start a vote on FLIP-335 [1]. It covers the deprecation (and > Flink 2.0-related removal) of Flink's Time classes in favor of Java's > Duration class. > > The related discussion thread can be found in [2

Re: [DISCUSS] FLIP-398: Improve Serialization Configuration And Usage In Flink

2023-12-11 Thread Zhu Zhu
Thanks Yong for creating the FLIP and starting the discussion. Having a unified config option for all kinds of serializers can make it much easier for users to set, track and maintain the serializers for jobs. +1 Thanks, Zhu weijie guo 于2023年12月12日周二 14:01写道: > Thanks for driving this, Yong.

Re: [VOTE] FLIP-364: Improve the restart-strategy

2023-11-30 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Zhanghao Chen 于2023年11月30日周四 23:31写道: > +1 (non-binding) > > Best, > Zhanghao Chen > > From: Rui Fan <1996fan...@gmail.com> > Sent: Monday, November 13, 2023 11:01 > To: dev > Subject: [VOTE] FLIP-364: Improve the restart-strategy > > H

Re: [VOTE] FLIP-379: Dynamic source parallelism inference for batch jobs

2023-11-29 Thread Zhu Zhu
+1 Thanks, Zhu Xia Sun 于2023年11月30日周四 11:41写道: > Hi everyone, > > I'd like to start a vote on FLIP-379: Dynamic source parallelism inference > for batch jobs[1] which has been discussed in this thread [2]. > > The vote will be open for at least 72 hours unless there is an objection or > not eno

[jira] [Created] (FLINK-33677) Remove flink-conf.yaml from flink dist

2023-11-28 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-33677: --- Summary: Remove flink-conf.yaml from flink dist Key: FLINK-33677 URL: https://issues.apache.org/jira/browse/FLINK-33677 Project: Flink Issue Type: Sub-task

Re: [VOTE] FLIP-391: Deprecate RuntimeContext#getExecutionConfig

2023-11-27 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Rui Fan <1996fan...@gmail.com> 于2023年11月28日周二 13:11写道: > +1(binding) > > Best, > Rui > > On Tue, Nov 28, 2023 at 12:34 PM Junrui Lee wrote: > > > Hi everyone, > > > > Thank you to everyone for the feedback on FLIP-391: Deprecate > > RuntimeContext#getExecutionConfig[1]

Re: [VOTE] Release flink-shaded 16.2, release candidate #1

2023-11-16 Thread Zhu Zhu
+1 (binding) - verified checksum and signature - verified the source archive does not contain any binary - built from source code successfully - checked the web pr Thanks, Zhu Xintong Song 于2023年11月15日周三 10:42写道: > +1 (binding) > > - verified checksum and signature > - verified license and not

Re: [DISCUSS] FLIP-391: Deprecate RuntimeContext#getExecutionConfig

2023-11-15 Thread Zhu Zhu
Thanks Junrui for creating the FLIP and kicking off this discussion. Exposing a mutable ExecutionConfig which is even shared by multiple operators is truly a defect which can result in weird results. +1 Thanks, Zhu Junrui Lee 于2023年11月15日周三 16:53写道: > Hi all, > > I'd like to start a discussio

Re: [DISCUSS] FLIP-364: Improve the restart-strategy

2023-11-13 Thread Zhu Zhu
s some issues: > >> > > 1. The exponential-delay doesn't have the max attempts mechanism, > >> > > it means that flink will restart indefinitely even if it fails > >> frequently. > >> > > 2. For multi-region streaming jobs and all batch jobs, the failure > o

Re: [VOTE] FLIP-381: Deprecate configuration getters/setters that return/set complex Java objects

2023-11-12 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Xia Sun 于2023年11月13日周一 15:02写道: > +1 (non-binding) > > Best, > Xia > > Samrat Deb 于2023年11月13日周一 12:37写道: > > > +1 (non binding) > > > > Bests, > > Samrat > > > > On Mon, 13 Nov 2023 at 9:10 AM, Yangze Guo wrote: > > > > > +1 (binding) > > > > > > Best, > > > Yangze G

Re: [DISCUSS] FLIP-381: Deprecate configuration getters/setters that return/set complex Java objects

2023-11-02 Thread Zhu Zhu
Thanks Junrui for creating the FLIP and kicking off this discussion. The community has been constantly striving to unify and simplify the configuration layer of Flink. Some progress has already been made, such as FLINK-29379. However, the compatibility of public interfaces poses an obstacle to com

Re: [DISCUSS] FLIP-379: Dynamic source parallelism inference for batch jobs

2023-10-31 Thread Zhu Zhu
1] document for more details about the > proposed design and implementation. > > I also thank Zhu Zhu and LiJie Wang for their suggestions during the > pre-discussion. > Looking forward to your feedback and suggestions, thanks. > > [1] > > https://cwiki.apache.org/confluence

Re: [VOTE] FLIP-370: Support Balanced Tasks Scheduling

2023-10-25 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Yuepeng Pan 于2023年10月25日周三 11:32写道: > +1 (non-binding) > > Regards, > Yuepeng Pan > > On 2023/10/23 08:25:30 xiangyu feng wrote: > > Thanks for driving that. > > +1 (non-binding) > > > > Regards, > > Xiangyu > > > > Yu Chen 于2023年10月23日周一 15:19写道: > > > > > +1 (non-bin

Re: [VOTE] FLIP-366: Support standard YAML for FLINK configuration

2023-10-16 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Jane Chan 于2023年10月13日周五 17:00写道: > +1 (non-binding) > > Best, > Jane > > On Fri, Oct 13, 2023 at 11:20 AM Yuxin Tan wrote: > > > +1(non-binding) > > > > Best, > > Yuxin > > > > > > Zhanghao Chen 于2023年10月13日周五 10:54写道: > > > > > +1 (non-binding) > > > > > > Best, > >

Re: [DISCUSS] FLIP-370 : Support Balanced Tasks Scheduling

2023-10-10 Thread Zhu Zhu
gic of 'Slots' > and > 'Tasks' are exactly the same, it feels a bit strange to define two > enumerations. > And it may cause confusion to users. > > If they are totally the same, how about combining them to SlotsAndTasks? > It can be compatible with '

Re: [DISCUSS] FLIP-370 : Support Balanced Tasks Scheduling

2023-10-09 Thread Zhu Zhu
> example 2 of section 2.2.3 can be resolved. Do I understand it > >> >> > > > correctly? > >> >> > > > >> >> > > The example assigned result is the final allocation result when > flink > >> >> > > us

Re: [DISCUSS] FLIP-370 : Support Balanced Tasks Scheduling

2023-09-27 Thread Zhu Zhu
ined resources. The proposed config option `slot.request.max-interval` then can be renamed to `taskmanager.load-balance.request-stablizing-timeout` to show its relation with the feature. The proposed `slot.sharing-strategy` is not needed, because the configured "Tasks" mode will do the wor

Re: [VOTE] Release 2.0 must-have work items - Round 2

2023-07-26 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Leonard Xu 于2023年7月26日周三 15:40写道: > > Thanks @xingtong for driving the work. > > +1(binding) > > Best, > Leonard > > > On Jul 26, 2023, at 3:18 PM, Konstantin Knauf > > wrote: > > > > Hi Xingtong, > > > > yes, I am fine with the conclusion for SourceFunction. I chatted

Re: [VOTE][2.0] FLIP-336: Remove "now" timestamp field from REST responses

2023-07-25 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Xintong Song 于2023年7月25日周二 09:46写道: > > +1 (binding) > > Best, > > Xintong > > > > On Mon, Jul 24, 2023 at 11:26 PM Jing Ge wrote: > > > +1(binding) > > > > On Mon, Jul 24, 2023 at 8:55 PM Matthias Pohl > > wrote: > > > > > +1 (binding) > > > > > > On Mon, Jul 24, 2023

Re: [VOTE][2.0] FLIP-340: Remove rescale REST endpoint

2023-07-24 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Xintong Song 于2023年7月25日周二 09:46写道: > > +1 (binding) > > Best, > > Xintong > > > > On Mon, Jul 24, 2023 at 11:58 PM Jing Ge wrote: > > > +1 > > > > On Mon, Jul 24, 2023 at 11:43 PM Chesnay Schepler > > wrote: > > > > > I update the endpoint in the FLIP. > > > > > > On

[jira] [Created] (FLINK-32654) Deprecate ExecutionConfig#canEqual(obj)

2023-07-24 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-32654: --- Summary: Deprecate ExecutionConfig#canEqual(obj) Key: FLINK-32654 URL: https://issues.apache.org/jira/browse/FLINK-32654 Project: Flink Issue Type: Technical Debt

Re: [VOTE] FLIP-309: Support using larger checkpointing interval when source is processing backlog

2023-07-19 Thread Zhu Zhu
+1 (binding) Thanks, Zhu yuxia 于2023年7月20日周四 09:23写道: > > +1(binding) > > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "Guowei Ma" > 收件人: "dev" > 发送时间: 星期三, 2023年 7 月 19日 下午 1:54:52 > 主题: Re: [VOTE] FLIP-309: Support using larger checkpointing interval when > source is processing backlog

Re: [DISCUSS][2.0] FLIP-340: Remove rescale REST endpoint

2023-07-18 Thread Zhu Zhu
+1 Thanks, Zhu Jing Ge 于2023年7月18日周二 19:09写道: > > +1 > > On Tue, Jul 18, 2023 at 1:05 PM Maximilian Michels wrote: > > > +1 > > > > On Tue, Jul 18, 2023 at 12:29 PM Gyula Fóra wrote: > > > > > > +1 > > > > > > On Tue, 18 Jul 2023 at 12:12, Xintong Song > > wrote: > > > > > > > +1 > > > > > >

Re: [DISCUSS] Release 2.0 Work Items

2023-07-10 Thread Zhu Zhu
Agreed that we should deprecate affected APIs as soon as possible. But there is not much time before the feature freeze of 1.18, hence I'm a bit concerned that some of the deprecations might not be done 1.18. We are currently looking into the improvements of the configuration layer. Most of the p

Re: Re: [ANNOUNCE] Apache Flink has won the 2023 SIGMOD Systems Award

2023-07-03 Thread Zhu Zhu
Congratulations everyone! Thanks, Zhu Hang Ruan 于2023年7月4日周二 14:06写道: > > Congratulations! > > Best, > Hang > > Jingsong Li 于2023年7月4日周二 13:47写道: > > > Congratulations! > > > > Thank you! All of the Flink community! > > > > Best, > > Jingsong > > > > On Tue, Jul 4, 2023 at 1:24 PM tison wrote:

Re: [VOTE] FLIP-321: introduce an API deprecation process

2023-07-03 Thread Zhu Zhu
+1 (binding) Thanks, Zhu ConradJam 于2023年7月3日周一 22:39写道: > > +1 (no-binding) > > Matthias Pohl 于2023年7月3日周一 22:33写道: > > > Thanks, Becket > > > > +1 (binding) > > > > On Mon, Jul 3, 2023 at 10:44 AM Jing Ge > > wrote: > > > > > +1(binding) > > > > > > On Mon, Jul 3, 2023 at 10:19 AM Stefan Ric

Re: [DISCUSS] FLIP-309: Enable operators to trigger checkpoints dynamically

2023-06-27 Thread Zhu Zhu
Thanks Dong and Yunfeng for creating this FLIP and driving this discussion. The new design looks generally good to me. Increasing the checkpoint interval when the job is processing backlogs is easier for users to understand and can help in more scenarios. I have one comment about the new configur

Re: [VOTE] FLIP-324: Introduce Runtime Filter for Flink Batch Jobs

2023-06-24 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Rui Fan <1996fan...@gmail.com> 于2023年6月24日周六 12:28写道: > > +1(binding), thanks for driving this improvement. > > Best, > Rui Fan > > On Sat, Jun 24, 2023 at 4:55 AM Jing Ge wrote: > > > +1(binding) > > > > Best Regards, > > Jing > > > > On Fri, Jun 23, 2023 at 5:50 PM Lij

[jira] [Created] (FLINK-32384) Remove deprecated configuration keys which violate YAML spec

2023-06-19 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-32384: --- Summary: Remove deprecated configuration keys which violate YAML spec Key: FLINK-32384 URL: https://issues.apache.org/jira/browse/FLINK-32384 Project: Flink Issue

[jira] [Created] (FLINK-32383) 2.0 Breaking configuration changes

2023-06-19 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-32383: --- Summary: 2.0 Breaking configuration changes Key: FLINK-32383 URL: https://issues.apache.org/jira/browse/FLINK-32383 Project: Flink Issue Type: Technical Debt

Re: [VOTE] FLIP-287: Extend Sink#InitContext to expose TypeSerializer, ObjectReuse and JobID

2023-06-18 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Tzu-Li (Gordon) Tai 于2023年6月17日周六 11:32写道: > > +1 (binding) > > On Fri, Jun 16, 2023, 09:53 Jing Ge wrote: > > > +1(binding) > > > > Best Regards, > > Jing > > > > On Fri, Jun 16, 2023 at 10:10 AM Lijie Wang > > wrote: > > > > > +1 (binding) > > > > > > Thanks for driv

Re: [DISCUSS] FLIP-287: Extend Sink#InitContext to expose ExecutionConfig and JobID

2023-04-21 Thread Zhu Zhu
n from `ExecutionConfig` accessible at the operator level. > For 2), would it make sense to create the serializer at the operator level > and then provide it through `InitContext`? > > Thanks, > Gordon > > On Mon, Apr 17, 2023 at 8:23 AM Zhu Zhu wrote: > > > We can let th

Re: DefaultInputSplitAssigner question

2023-04-20 Thread Zhu Zhu
t; > > > Peter > > > > [1] > > https://github.com/apache/iceberg/blob/fe6f3b2325bce0acba4c75f4a9e9edec6021a3b0/flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/FlinkInputFormat.java#L105 > > [2] FLINK-31868: Fix DefaultInputSplitAssigner javadoc for class - > > https://is

Re: [VOTE] FLIP-304: Pluggable Failure Enrichers

2023-04-20 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Anton Kalashnikov 于2023年4月20日周四 20:03写道: > > +1 (binding) > > > Thanks for this FLIP Panos, LGTM. > > -- > Best regards, > Anton Kalashnikov > > On 20.04.23 13:44, Roman Khachatryan wrote: > > +1 (binding) > > > > The FLIP LGTM, thanks Panos! > > > > Regards, > > Roman >

Re: DefaultInputSplitAssigner question

2023-04-19 Thread Zhu Zhu
Hi Peter, Maybe you can try Flink new source[1]? It allows you to customize your own `SplitEnumerator` which can control how to assign splits. DefaultInputSplitAssigner is not a public interface. And currently there is no requirement of the order of splits by Flink itself. Therefore, it looks to

Re: [DISCUSS] FLIP-287: Extend Sink#InitContext to expose ExecutionConfig and JobID

2023-04-17 Thread Zhu Zhu
n2) > > To extend the ExecutionConfig is not simpler to do Option1 (expose > ExecutionConfig directly). > > Regards > > > > On 2023/04/03 09:42:28 Zhu Zhu wrote: > > Hi João, > > > > Thanks for creating this FLIP! > > I'm overall +1 for it to unb

Re: [DISCUSS] FLIP-304: Pluggable failure handling for Apache Flink

2023-04-11 Thread Zhu Zhu
] > https://cwiki.apache.org/confluence/display/FLINK/FLIP-304%3A+Pluggable+Failure+Enrichers > > > Panagiotis > > > On Tue, Mar 28, 2023 at 5:01 AM Zhu Zhu wrote: > > > Hi Panagiotis, > > > > How about to introduce a config option to control which error ha

Re: [DISCUSS] FLIP-287: Extend Sink#InitContext to expose ExecutionConfig and JobID

2023-04-03 Thread Zhu Zhu
Hi João, Thanks for creating this FLIP! I'm overall +1 for it to unblock the migration of sinks to SinkV2. Yet I think it's better to let the `ReadableExecutionConfig` extend `ExecutionConfig`, because otherwise we have to introduce a new method `TypeInformation#createSerializer(ReadableExecution

Re: [ANNOUNCE] Flink Table Store Joins Apache Incubator as Apache Paimon(incubating)

2023-03-28 Thread Zhu Zhu
Congratulations! Cheers, Zhu Jing Zhang 于2023年3月28日周二 23:56写道: > > Congratulations! > > Best, > Jing Zhang > > Rui Fan <1996fan...@gmail.com> 于2023年3月28日周二 22:25写道: > > > Congratulations! > > > > Best, > > Rui Fan > > > > On Tue, Mar 28, 2023 at 15:37 Guowei Ma wrote: > > > > > Congratulations!

Re: [DISCUSS] FLIP-304: Pluggable failure handling for Apache Flink

2023-03-28 Thread Zhu Zhu
a read-only view > of context. In this way we can make sure a handler behaves in > the expected way. > > > On Thu, Mar 23, 2023 at 5:19 PM Zhu Zhu wrote: > > > +1 to support custom restart strategies in a different FLIP. > > > > It's fine to have a dif

Re: [DISCUSS] FLIP-304: Pluggable failure handling for Apache Flink

2023-03-23 Thread Zhu Zhu
gt; > > concern > > > > >> about introducing too many different types of plugins. But I would > > > still > > > > >> favor not extending the FLIP in this regard. A pluggable restart > > > > strategy > > > > >> so

Re: [DISCUSS] FLIP-304: Pluggable failure handling for Apache Flink

2023-03-21 Thread Zhu Zhu
t; > On Mon, Mar 20, 2023 at 11:42 PM Lijie Wang > > > wrote: > > > > > > > Hi Panagiotis, > > > > > > > > Thanks for driving this. > > > > > > > > +1 for supporting custom restart strategy, we did receive such reques

Re: [VOTE] FLIP-301: Hybrid Shuffle supports Remote Storage

2023-03-20 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Xintong Song 于2023年3月20日周一 16:26写道: > > +1 (binding) > > Best, > > Xintong > > > > On Mon, Mar 20, 2023 at 4:07 PM weijie guo > wrote: > > > Thanks Yuxin for driving this. > > > > +1 (binding) > > > > Best regards, > > > > Weijie > > > > > > Junrui Lee 于2023年3月20日周一 14

Re: [DISCUSS] FLIP-304: Pluggable failure handling for Apache Flink

2023-03-20 Thread Zhu Zhu
Hi Panagiotis, Thanks for creating this proposal! It's good to enable Flink to handle different errors in different ways, through a pluggable way. There are requests for flexible restart strategies from time to time, for different strategies of restart backoff time, or to suppress restarting on c

Re: [DISCUSS] FLIP-301: Hybrid Shuffle supports Remote Storage

2023-03-10 Thread Zhu Zhu
Hi Yuxin, Thanks for creating this FLIP! The idea of tiered storage looks good. Instead of choosing one from multiple storages, it can help to balance between performance, cost and stability. It also has the potential to adaptively select proper tiers according to more runtime information, to achi

[jira] [Created] (FLINK-31052) Release Testing: Verify FLINK-30707 Improve slow task detection

2023-02-13 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-31052: --- Summary: Release Testing: Verify FLINK-30707 Improve slow task detection Key: FLINK-31052 URL: https://issues.apache.org/jira/browse/FLINK-31052 Project: Flink Issue

[jira] [Created] (FLINK-31005) Release Testing: Verify FLIP-281 Supports speculative execution of sinks

2023-02-09 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-31005: --- Summary: Release Testing: Verify FLIP-281 Supports speculative execution of sinks Key: FLINK-31005 URL: https://issues.apache.org/jira/browse/FLINK-31005 Project: Flink

[jira] [Created] (FLINK-30904) Update the documentation and configuration description of slow task detector

2023-02-05 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-30904: --- Summary: Update the documentation and configuration description of slow task detector Key: FLINK-30904 URL: https://issues.apache.org/jira/browse/FLINK-30904 Project: Flink

[jira] [Created] (FLINK-30834) SortAggITCase.testLeadLag is unstable in ALL_EXCHANGES_BLOCKING mode

2023-01-30 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-30834: --- Summary: SortAggITCase.testLeadLag is unstable in ALL_EXCHANGES_BLOCKING mode Key: FLINK-30834 URL: https://issues.apache.org/jira/browse/FLINK-30834 Project: Flink

[jira] [Created] (FLINK-30815) BatchTestBase/BatchAbstractTestBase are using Junit4 while some child tests are using JUnit5

2023-01-28 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-30815: --- Summary: BatchTestBase/BatchAbstractTestBase are using Junit4 while some child tests are using JUnit5 Key: FLINK-30815 URL: https://issues.apache.org/jira/browse/FLINK-30815

[jira] [Created] (FLINK-30814) The parallelism&maxParallelism of sort after a global partitioning is forced to be 1

2023-01-28 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-30814: --- Summary: The parallelism&maxParallelism of sort after a global partitioning is forced to be 1 Key: FLINK-30814 URL: https://issues.apache.org/jira/browse/FLINK-30814 Pro

Re: [VOTE] FLIP-281: Sink Supports Speculative Execution For Batch Job

2023-01-10 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Biao Liu 于2023年1月5日周四 10:37写道: > > Hi Martijn, > > Sure, thanks for the reminder about the holiday period. > Looking forward to your feedback! > > Thanks, > Biao /'bɪ.aʊ/ > > > > On Thu, 5 Jan 2023 at 03:07, Martijn Visser > wrote: > > > Hi Biao, > > > > To be honest, I

Re: [VOTE] FLIP-283: Use adaptive batch scheduler as default scheduler for batch jobs

2023-01-10 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Lijie Wang 于2023年1月10日周二 17:48写道: > > +1 (binding) > > Best, > Lijie > > Junrui Lee 于2023年1月10日周二 11:31写道: > > > Hi all, > > > > Thanks for all the feedback so far. > > Based on the discussion[1], we have come to a consensus, > > so I would like to start a vote on FLIP-

Re: [VOTE] FLIP-274: Introduce metric group for OperatorCoordinator

2023-01-10 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Jark Wu 于2023年1月10日周二 17:43写道: > > +1 (binding) > > Best, > Jark > > > 2023年1月10日 12:02,Qingsheng Ren 写道: > > > > Thanks for the FLIP! > > > > +1 (binding) > > > > Best, > > Qingsheng > > > > On Wed, Jan 4, 2023 at 10:08 AM Hang Ruan wrote: > > > >> Hi all, > >> > >> T

Re: [VOTE]FLIP-266: Simplify network memory configurations for TaskManager

2023-01-03 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Xintong Song 于2023年1月4日周三 10:36写道: > > +1 (binding) > > Best, > > Xintong > > > > On Tue, Jan 3, 2023 at 5:57 PM Yuxin Tan wrote: > > > Hi all, > > > > Thanks for all the feedback so far. > > Based on the discussion[1], we have come to a consensus, > > so I would like t

Re: [DISCUSS] Extending the feature freezing date of Flink 1.17

2023-01-02 Thread Zhu Zhu
+1 to extend the feature freeze date to Jan 31st. Thanks, Zhu David Anderson 于2023年1月3日周二 11:41写道: > > I'm also in favor of extending the feature freeze to Jan 31st. > > David > > On Thu, Dec 29, 2022 at 9:01 AM Leonard Xu wrote: > > > Thanks Qingsheng for the proposal, the pandemic has really

Re: [DISCUSS] FLIP-283: Use adaptive batch scheduler as default scheduler for batch jobs

2022-12-29 Thread Zhu Zhu
Hi Junrui, Thanks for creating this FLIP! AdaptiveBatchScheduler is more powerful than DefaultScheduler in batch scheduling, also with some must-have features like speculative execution. It will be great that users can easily use it, without required to knowing the underlying scheduler and config

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2022-12-26 Thread Zhu Zhu
Hi Biao, Thanks for creating this FLIP! Supporting speculative execution of sinks is important. Also In production we see sinks chaining with other operators, e.g. sources in simple ETL jobs, and currently the task cannot do speculative execution due to sinks are not supported. +1 for the proposa

Re: [DISCUSS] FLIP-266: Simplify network memory configurations for TaskManager

2022-12-26 Thread Zhu Zhu
Hi Yuxin, Thanks for creating this FLIP. It's good if Flink does not require users to set a very large network memory, or tune the advanced(hard-to-understand) per-channel/per-gate buffer configs, to avoid "Insufficient number of network buffers" exceptions which can easily happen for large scale

Re: [DISCUSS] FLIP-274 : Introduce metric group for OperatorCoordinator

2022-12-25 Thread Zhu Zhu
gt; Hi everyone, > > As for the Zhu Zhu's problem, I think we should keep the common metrics, > which will help to observe incoming and outgoing events. What do you think, > @Zhu Zhu ? > And @Chesnay, are there any other issues you are more concerned about? > Looking forward to y

Re: [DISCUSS] Release Flink 1.16.1

2022-12-22 Thread Zhu Zhu
Hi Martjin, Thank you for bringing this up! +1 to release 1.16.1. There's a critical problem (FLINK-30334) of HybridSource and a fix is in review. I hope we can include the fix in 1.16.1. Thanks, Zhu yh z 于2022年12月22日周四 16:11写道: > > Hi Martijn, > > +1 > Thank you for bringing this up. There i

[jira] [Created] (FLINK-30480) Add benchmarks for adaptive batch scheduler

2022-12-21 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-30480: --- Summary: Add benchmarks for adaptive batch scheduler Key: FLINK-30480 URL: https://issues.apache.org/jira/browse/FLINK-30480 Project: Flink Issue Type: Improvement

  1   2   3   4   5   >