+1 (binding) Thanks, Zhu
Xuannan Su <suxuanna...@gmail.com> 于2024年1月12日周五 14:24写道： > Hi all, > > I would like to clarify the statement regarding the first improvement > from the previous email, as it was incomplete. To be more specific, we > will also deprecate the getClass(String key, Class<? extends T> > defaultValue, ClassLoader classLoader) and setClass(String key, > Class<?> klazz), as they are intended for internal use only and are no > longer in use. > > To summarize, the first improvement should be as follows: > > We will mark the getBytes(String key, byte[] defaultValue) and > setBytes(String key, byte[] bytes) methods as @Internal, as they are > intended for internal use only. Additionally, we will > deprecatesgetClass(String key, Class<? extends T> defaultValue, > ClassLoader classLoader) and setClass(String key, Class<?> klazz) > methods, as they are intended for internal use only and are no longer > in use. > > I apologize for any confusion caused by the incomplete information. > > Best regards, > Xuannan > > On Fri, Jan 12, 2024 at 1:36 PM Xuannan Su <suxuanna...@gmail.com> wrote: > > > > Hi all, > > > > During voting, we identified two improvements we'd like to make to the > FLIP: > > > > - We will mark the getBytes(String key, byte[] defaultValue) and > > setBytes(String key, byte[] bytes) methods as @Internal, as they are > > intended for internal use only. > > - In addition to marking all getXxx(ConfigOption configOption) methods > > as @Deprecated, we will also mark the getXxx(ConfigOption > > configOption, Xxx overrideDefault) methods as @Deprecated. These will > > be replaced with T get(ConfigOption configOption, T overrideDefault). > > > > We had an offline discussion with all the voters and reached a > > consensus on the above changes. Therefore, we will not initiate > > another voting thread unless there are objections. > > > > Best regards, > > Xuannan > > > > > > On Tue, Jan 9, 2024 at 11:43 AM Xintong Song <tonysong...@gmail.com> > wrote: > > > > > > +1 (binding) > > > > > > Best, > > > > > > Xintong > > > > > > > > > > > > On Mon, Jan 8, 2024 at 1:48 PM Hang Ruan <ruanhang1...@gmail.com> > wrote: > > > > > > > +1(non-binding) > > > > > > > > Best, > > > > Hang > > > > > > > > Rui Fan <1996fan...@gmail.com> 于2024年1月8日周一 13:04写道： > > > > > > > > > +1(binding) > > > > > > > > > > Best, > > > > > Rui > > > > > > > > > > On Mon, Jan 8, 2024 at 1:00 PM Xuannan Su <suxuanna...@gmail.com> > wrote: > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > Thanks for all the feedback about the FLIP-405: Migrate string > > > > > > configuration key to ConfigOption [1] [2]. > > > > > > > > > > > > I'd like to start a vote for it. The vote will be open for at > least 72 > > > > > > hours(excluding weekends,until Jan 11, 12:00AM GMT) unless there > is an > > > > > > objection or an insufficient number of votes. > > > > > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-405%3A+Migrate+string+configuration+key+to+ConfigOption > > > > > > [2] > https://lists.apache.org/thread/zfw1b1g3679yn0ppjbsokfrsx9k7ybg0 > > > > > > > > > > > > > > > > > > Best, > > > > > > Xuannan > > > > > > > > > > > > > > > >
