Re: [DISCUSS] FLIP-489: Add missing dropTable/dropView methods to TableEnvironment

2024-12-06 Thread Jim Hughes
Hi Sergey, Nice! Seems straightforward... While reading it was surprised that the create functions like `createTable` return void. The suggestion to return boolean like the other drop methods seems good. Cheers, Jim On Fri, Dec 6, 2024 at 5:53 PM Sergey Nuyanzin wrote: > Hi all! > > I woul

[DISCUSS] FLIP-489: Add missing dropTable/dropView methods to TableEnvironment

2024-12-06 Thread Sergey Nuyanzin
Hi all! I would like to open up for discussion a new small FLIP-489[1]. Motivation This FLIP is another step in the story of bringing Table API and FlinkSQL closer to each other. It adds missing drop methods to TableEnvironment (alter functionality will be added in follow up FLIP(s)). There are a

[jira] [Created] (FLINK-36862) Implement additional TO_TIMESTAMP_LTZ() functions

2024-12-06 Thread Yiyu Tian (Jira)
Yiyu Tian created FLINK-36862: - Summary: Implement additional TO_TIMESTAMP_LTZ() functions Key: FLINK-36862 URL: https://issues.apache.org/jira/browse/FLINK-36862 Project: Flink Issue Type: Impro

[jira] [Created] (FLINK-36861) CREATE TABLE AS with METADATA columns doesn't work

2024-12-06 Thread Jira
Sergio Peña created FLINK-36861: --- Summary: CREATE TABLE AS with METADATA columns doesn't work Key: FLINK-36861 URL: https://issues.apache.org/jira/browse/FLINK-36861 Project: Flink Issue Type:

Re: Blue/Green Deployments support for Flink

2024-12-06 Thread Alex Nitavsky
Hi Sergio, Thanks for the proposal. There are certainly many corner cases to address when switching from a Green to Blue deployment to keep data active. Some points that I believe haven't been listed yet include: - Should this reusable ProcessFunction filter out data or simply tag them? For

Re: [DISCUSS] FLIP-487: Show history of rescales in Web UI for AdaptiveScheduler

2024-12-06 Thread Eric Xiao
Hi Yuepeng Pan, This would be a very useful feature to have in OSS. One question I have that wasn't outlined in the FLIP or I may have missed it was - How/Where would we store the history of these scaling events? Is there an existing pattern for storing such information in other parts of Flink th

Re: [VOTE] FLIP-484: Add custom metric variables to operators

2024-12-06 Thread Piotr Nowojski
Hi David, no worries and thanks for the feedback! While I agree that the "scope" feels more intuitive, and I think in the first version that's the name I used. However the issue is that there is already a pre-existing naming convention in Flink, where "variable" [1] and "additional variables" [2]

[jira] [Created] (FLINK-36860) Adjust internal state v2 interface hierarchy

2024-12-06 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-36860: --- Summary: Adjust internal state v2 interface hierarchy Key: FLINK-36860 URL: https://issues.apache.org/jira/browse/FLINK-36860 Project: Flink Issue Type: Sub-ta

[jira] [Created] (FLINK-36859) Wrong epoch/watermark firing in async state processing

2024-12-06 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-36859: --- Summary: Wrong epoch/watermark firing in async state processing Key: FLINK-36859 URL: https://issues.apache.org/jira/browse/FLINK-36859 Project: Flink Issue Ty

RE: [VOTE] FLIP-484: Add custom metric variables to operators

2024-12-06 Thread David Radley
Hi, Sorry I am late to this. I have some comments. If I am understanding this correctly, the custom metric is not a new metric that has been customized, it is the ability to add readable useful names / tags as scopes to existing metrics. If this is the case I suggest changing the method name fr

Re: [VOTE] FLIP-481: Introduce Event Reporting

2024-12-06 Thread Rui Fan
+1 (binding) Best, Rui On Fri, Dec 6, 2024 at 5:33 PM Roman Khachatryan wrote: > +1 (binding) > > Regards, > Roman > > > On Fri, Dec 6, 2024 at 10:19 AM Piotr Nowojski > wrote: > > > Hi all! > > > > I would like to open the vote for FLIP-481 [1]. It has been discussed > here > > [2]. > > > > T

Re: [VOTE] FLIP-484: Add custom metric variables to operators

2024-12-06 Thread Yuepeng Pan
+1 (non-binding) Thanks Piotr for driving it ! Best, Yuepeng Pan On 2024/12/06 09:19:46 Piotr Nowojski wrote: > Hi all! > > I would like to open the vote for FLIP-484 [1]. It has been discussed here > [2]. > > The vote will remain open for at least 72 hours (excluding the weekend). > > Best,

Re: [DISCUSS] FLIP-487: Show history of rescales in Web UI for AdaptiveScheduler

2024-12-06 Thread Yuepeng Pan
Thanks Rui for the comments! > I have a minor question for this: could we discuss 2 FLIPs together? > I'm afraid the rest endpoints doesn't work as expected when we discuss > WebUI change in the future. > Clarification: Organize related designs in different FLIP wikis and > discuss them in diffe

Re: [VOTE] FLIP-484: Add custom metric variables to operators

2024-12-06 Thread Rui Fan
+1 (binding) Best, Rui On Fri, Dec 6, 2024 at 5:36 PM Roman Khachatryan wrote: > +1 (binding) > > Regards, > Roman > > > On Fri, Dec 6, 2024 at 10:21 AM Piotr Nowojski > wrote: > > > Hi all! > > > > I would like to open the vote for FLIP-484 [1]. It has been discussed > here > > [2]. > > > > T

Re: [VOTE] FLIP-483: Add support for children Spans

2024-12-06 Thread Rui Fan
+1 (binding) Best, Rui On Fri, Dec 6, 2024 at 5:33 PM Roman Khachatryan wrote: > +1 (binding) > > Regards, > Roman > > > On Fri, Dec 6, 2024 at 10:21 AM Piotr Nowojski > wrote: > > > Hi all! > > > > I would like to open the vote for FLIP-483 [1]. It has been discussed > here > > [2]. > > > > T

Re: [VOTE] FLIP-482: Add OpenTelemetryEventReporter

2024-12-06 Thread Rui Fan
+1 (binding) Best, Rui On Fri, Dec 6, 2024 at 5:32 PM Roman Khachatryan wrote: > +1 (binding) > > Regards, > Roman > > > On Fri, Dec 6, 2024 at 10:18 AM Piotr Nowojski > wrote: > > > Hi all! > > > > I would like to open the vote for FLIP-482 [1]. It has been discussed > here > > [2]. > > > > T

Re: [VOTE] FLIP-481: Introduce Event Reporting

2024-12-06 Thread Roman Khachatryan
+1 (binding) Regards, Roman On Fri, Dec 6, 2024 at 10:19 AM Piotr Nowojski wrote: > Hi all! > > I would like to open the vote for FLIP-481 [1]. It has been discussed here > [2]. > > The vote will remain open for at least 72 hours (excluding the weekend). > > Best, > Piotrek > > [1] https://cwi

Re: [VOTE] FLIP-483: Add support for children Spans

2024-12-06 Thread Roman Khachatryan
+1 (binding) Regards, Roman On Fri, Dec 6, 2024 at 10:21 AM Piotr Nowojski wrote: > Hi all! > > I would like to open the vote for FLIP-483 [1]. It has been discussed here > [2]. > > The vote will remain open for at least 72 hours (excluding the weekend). > > Best, > Piotrek > > [1] https://cwi

Re: [VOTE] FLIP-484: Add custom metric variables to operators

2024-12-06 Thread Roman Khachatryan
+1 (binding) Regards, Roman On Fri, Dec 6, 2024 at 10:21 AM Piotr Nowojski wrote: > Hi all! > > I would like to open the vote for FLIP-484 [1]. It has been discussed here > [2]. > > The vote will remain open for at least 72 hours (excluding the weekend). > > Best, > Piotrek > > [1] https://cwi

Re: [VOTE] FLIP-482: Add OpenTelemetryEventReporter

2024-12-06 Thread Roman Khachatryan
+1 (binding) Regards, Roman On Fri, Dec 6, 2024 at 10:18 AM Piotr Nowojski wrote: > Hi all! > > I would like to open the vote for FLIP-482 [1]. It has been discussed here > [2]. > > The vote will remain open for at least 72 hours (excluding the weekend). > > Best, > Piotrek > > [1] https://cwi

[VOTE] FLIP-484: Add custom metric variables to operators

2024-12-06 Thread Piotr Nowojski
Hi all! I would like to open the vote for FLIP-484 [1]. It has been discussed here [2]. The vote will remain open for at least 72 hours (excluding the weekend). Best, Piotrek [1] https://cwiki.apache.org/confluence/x/44yMEw [2] https://lists.apache.org/thread/1g1n2l8bc27zvw88ljw4l2gqzx6rg5zy

[VOTE] FLIP-483: Add support for children Spans

2024-12-06 Thread Piotr Nowojski
Hi all! I would like to open the vote for FLIP-483 [1]. It has been discussed here [2]. The vote will remain open for at least 72 hours (excluding the weekend). Best, Piotrek [1] https://cwiki.apache.org/confluence/x/4IyMEw [2] https://lists.apache.org/thread/hdrh4nx0zhjzb5q5gkp5w1cqkzb4v6po

[VOTE] FLIP-482: Add OpenTelemetryEventReporter

2024-12-06 Thread Piotr Nowojski
Hi all! I would like to open the vote for FLIP-482 [1]. It has been discussed here [2]. The vote will remain open for at least 72 hours (excluding the weekend). Best, Piotrek [1] https://cwiki.apache.org/confluence/x/3oyMEw [2] https://lists.apache.org/thread/db1v1hjcysxo88cjb6jq5vnrz4s3cdrm

[VOTE] FLIP-481: Introduce Event Reporting

2024-12-06 Thread Piotr Nowojski
Hi all! I would like to open the vote for FLIP-481 [1]. It has been discussed here [2]. The vote will remain open for at least 72 hours (excluding the weekend). Best, Piotrek [1] https://cwiki.apache.org/confluence/x/3IyMEw [2] https://lists.apache.org/thread/0y2yg1y27sv86rkxg0vpj18h5hgy2ppg

Re: [DISCUSS] FLIP-482: Add OpenTelemetryEventReporter

2024-12-06 Thread Piotr Nowojski
As there are no comments, I will open a voting thread later today. Best, Piotrek czw., 14 lis 2024 o 13:38 Roman Khachatryan napisał(a): > Hi Piotr, > > Adding OTel implementation makes sense, +1 for the proposal. > > Thanks > > Regards, > Roman > > > On Thu, Nov 7, 2024 at 2:37 PM Piotr Nowojs

Re: FLIP-484: Add custom metric variables to operators

2024-12-06 Thread Piotr Nowojski
I hope my previous message has clarified the questions. If there are no further comments, I will open a voting thread later today. Best, Piotrek wt., 3 gru 2024 o 12:18 Piotr Nowojski napisał(a): > Hi Romand and Hongshun, > > > 1. The scope of the variables added - is it only the last transfor

Re: [DISCUSS] FLIP-481: Introduce Event Reporting

2024-12-06 Thread Piotr Nowojski
Thanks for the comments! I will open the voting thread later today!. Best, Piotrek śr., 4 gru 2024 o 22:56 Roman Khachatryan napisał(a): > Thanks for updating the FLIP and clarifying. > > > That might have been a good idea, however this is consistent with the > ? already pre-existing traces/`Sp

Re: [DISCUSS] FLIP-483: Add support for children Spans

2024-12-06 Thread Piotr Nowojski
Yes, and again, we are not giving up. If/once we will have a well motivated use case for the distributed tracing, we can then try to figure out how to implement it. Anyway, I will open the voting thread later today! Thanks for the comments. Best, Piotrek śr., 4 gru 2024 o 23:36 Roman Khachatryan