Hi, Sorry I am late to this. I have some comments. If I am understanding this correctly, the custom metric is not a new metric that has been customized, it is the ability to add readable useful names / tags as scopes to existing metrics. If this is the case I suggest changing the method name from “ .addMetricVariable(” to something like “.addMetricScope(“ and docs should refer to metric scope / tag. The name metric variable, to me, implies that it is a variable that is measuring something.
I assume these variables would be most useful if they were unique; is there a way to make enforce uniqueness. >From your example, I assume all the “table_name” could be any literal. If the >main use case for this is to put the table name as the metric scope – could we >not do this automatically in the code without any additional need to add code? Kind regards, David. From: Yuepeng Pan <panyuep...@apache.org> Date: Friday, 6 December 2024 at 10:27 To: dev@flink.apache.org <dev@flink.apache.org> Subject: [EXTERNAL] Re: [VOTE] FLIP-484: Add custom metric variables to operators +1 (non-binding) Thanks Piotr for driving it ! Best, Yuepeng Pan On 2024/12/06 09:19:46 Piotr Nowojski wrote: > Hi all! > > I would like to open the vote for FLIP-484 [1]. It has been discussed here > [2]. > > The vote will remain open for at least 72 hours (excluding the weekend). > > Best, > Piotrek > > [1] https://cwiki.apache.org/confluence/x/44yMEw > [2] https://lists.apache.org/thread/1g1n2l8bc27zvw88ljw4l2gqzx6rg5zy > Unless otherwise stated above: IBM United Kingdom Limited Registered in England and Wales with number 741598 Registered office: Building C, IBM Hursley Office, Hursley Park Road, Winchester, Hampshire SO21 2JN
